Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified REST API docs #3780

Merged
merged 10 commits into from
Oct 3, 2022
Merged

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Sep 28, 2022

Update the docs with new info about the REST API unification.

Key changes:

  • All Admin API docs moved to Swagger. The docs are not trying to be more precise than before. We could refine the Swagger docs further if we need to. Some error examples were removed, because they got outdated, and IMO this was a bit too much detail (it was only for domains).
  • The removal of mod_*commands was documented.
  • The Admin API changed to return JSON values also for error cases. I discovered the issue that it was returning plain text, while Content-Type was application/json. This was a simple change, and all tests pass as before, because they decode JSON automatically. The client API is not changed similarly, because the code would need some refactoring first, and this would be out of scope. The local Swagger UI started working after the change.

@chrzaszcz chrzaszcz changed the base branch from master to feature/unified-rest-api September 28, 2022 12:40
@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 82.92% // Head: 82.90% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (2d4ea88) compared to base (2c13138).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feature/unified-rest-api    #3780      +/-   ##
============================================================
- Coverage                     82.92%   82.90%   -0.03%     
============================================================
  Files                           529      529              
  Lines                         33761    33761              
============================================================
- Hits                          27996    27988       -8     
- Misses                         5765     5773       +8     
Impacted Files Coverage Δ
src/mongoose_admin_api/mongoose_admin_api.erl 95.08% <100.00%> (ø)
src/event_pusher/mod_event_pusher_sns.erl 82.19% <0.00%> (-12.33%) ⬇️
src/mod_roster_riak.erl 96.92% <0.00%> (-1.54%) ⬇️
src/mod_roster.erl 78.94% <0.00%> (-0.72%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/mod_muc.erl 74.47% <0.00%> (+0.23%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.82% <0.00%> (+0.42%) ⬆️
src/async_pools/mongoose_aggregator_worker.erl 70.00% <0.00%> (+1.66%) ⬆️
src/pubsub/node_pep.erl 79.62% <0.00%> (+1.85%) ⬆️
src/mam/mod_mam_muc_rdbms_arch_async.erl 85.71% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 29, 2022

small_tests_24 / small_tests / b7e8518
Reports root / small


small_tests_25 / small_tests / b7e8518
Reports root / small


ldap_mnesia_24 / ldap_mnesia / b7e8518
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b7e8518
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / b7e8518
Reports root/ big
OK: 3805 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / b7e8518
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b7e8518
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b7e8518
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / b7e8518
Reports root/ big
OK: 2112 / Failed: 0 / User-skipped: 625 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b7e8518
Reports root/ big
OK: 2452 / Failed: 0 / User-skipped: 620 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / b7e8518
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / b7e8518
Reports root/ big
OK: 4191 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / b7e8518
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 612 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / b7e8518
Reports root/ big
OK: 4204 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 29, 2022

small_tests_24 / small_tests / ea4028c
Reports root / small


small_tests_25 / small_tests / ea4028c
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ea4028c
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / ea4028c
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / ea4028c
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ea4028c
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / ea4028c
Reports root/ big
OK: 3805 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / ea4028c
Reports root/ big
OK: 2112 / Failed: 0 / User-skipped: 625 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ea4028c
Reports root/ big
OK: 2452 / Failed: 0 / User-skipped: 620 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ea4028c
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / ea4028c
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / ea4028c
Reports root/ big
OK: 4216 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2514@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2514@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"ULEGwFWPB8kjUusGbIJjFw==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


riak_mnesia_24 / riak_mnesia / ea4028c
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 612 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / ea4028c
Reports root/ big
OK: 4191 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / ea4028c
Reports root/ big
OK: 4216 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2526@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2526@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"L358OvAdssX403I6AAeG8A==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

@mongoose-im

This comment was marked as outdated.

@chrzaszcz chrzaszcz force-pushed the unified-rest-api-docs branch 2 times, most recently from 50c32ed to 4d08062 Compare September 29, 2022 13:44
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 29, 2022

small_tests_24 / small_tests / 4d08062
Reports root / small


small_tests_25 / small_tests / 4d08062
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 4d08062
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 4d08062
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 4d08062
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 4d08062
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 4d08062
Reports root/ big
OK: 3805 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 4d08062
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 4d08062
Reports root/ big
OK: 2112 / Failed: 0 / User-skipped: 625 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 4d08062
Reports root/ big
OK: 2452 / Failed: 0 / User-skipped: 620 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 4d08062
Reports root/ big
OK: 4216 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2521@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2521@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"Iu9cXoI3byj4j1i3/wJVgQ==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


pgsql_mnesia_25 / pgsql_mnesia / 4d08062
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 4d08062
Reports root/ big
OK: 4191 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 4d08062
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 612 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 4d08062
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@chrzaszcz chrzaszcz force-pushed the unified-rest-api-docs branch 2 times, most recently from d5f73c6 to 3ea5a14 Compare September 30, 2022 06:55
@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 30, 2022

small_tests_24 / small_tests / d5f73c6
Reports root / small


small_tests_25 / small_tests / d5f73c6
Reports root / small


ldap_mnesia_24 / ldap_mnesia / d5f73c6
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d5f73c6
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / d5f73c6
Reports root/ big
OK: 3805 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d5f73c6
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / d5f73c6
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / d5f73c6
Reports root/ big
OK: 2112 / Failed: 0 / User-skipped: 625 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d5f73c6
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / d5f73c6
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / d5f73c6
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / d5f73c6
Reports root/ big
OK: 4191 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / d5f73c6
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 612 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / d5f73c6
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 30, 2022

small_tests_24 / small_tests / 3ea5a14
Reports root / small


small_tests_25 / small_tests / 3ea5a14
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 3ea5a14
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 3ea5a14
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 3ea5a14
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 3ea5a14
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 3ea5a14
Reports root/ big
OK: 3805 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 3ea5a14
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 3ea5a14
Reports root/ big
OK: 2112 / Failed: 0 / User-skipped: 625 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 3ea5a14
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 3ea5a14
Reports root/ big
OK: 2452 / Failed: 0 / User-skipped: 620 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 3ea5a14
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 3ea5a14
Reports root/ big
OK: 4191 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 3ea5a14
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 612 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 3ea5a14
Reports root/ big
OK: 4216 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2529@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2529@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"BS4p2VPXzzRfPgmzfVR3Ng==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 30, 2022

small_tests_24 / small_tests / b009863
Reports root / small


small_tests_25 / small_tests / b009863
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b009863
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / b009863
Reports root/ big
OK: 3805 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / b009863
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b009863
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / b009863
Reports root/ big
OK: 2112 / Failed: 0 / User-skipped: 625 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / b009863
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b009863
Reports root/ big
OK: 2452 / Failed: 0 / User-skipped: 620 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / b009863
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b009863
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / b009863
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / b009863
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 612 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / b009863
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 30, 2022

small_tests_24 / small_tests / 68d7c60
Reports root / small


small_tests_25 / small_tests / 68d7c60
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 68d7c60
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 68d7c60
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 68d7c60
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 68d7c60
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 68d7c60
Reports root/ big
OK: 3805 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 68d7c60
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 68d7c60
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 68d7c60
Reports root/ big
OK: 2112 / Failed: 0 / User-skipped: 625 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 68d7c60
Reports root/ big
OK: 2452 / Failed: 0 / User-skipped: 620 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 68d7c60
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 68d7c60
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 68d7c60
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 612 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 68d7c60
Reports root/ big
OK: 4191 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 30, 2022

small_tests_24 / small_tests / 6526b59
Reports root / small


small_tests_25 / small_tests / 6526b59
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 6526b59
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6526b59
Reports root/ big
OK: 3830 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

bosh_SUITE:essential:accept_higher_hold_value
{error,
  {{assertEqual,
     [{module,bosh_SUITE},
      {line,251},
      {expression,"get_bosh_sessions ( )"},
      {expected,[]},
      {value,
        [{bosh_session,<<"3b2b11e4547a92eb94059d3a380b6f79e9d7c1f9">>,
           <8833.5622.0>}]}]},
   [{bosh_SUITE,accept_higher_hold_value,1,
      [{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
       {line,251}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


dynamic_domains_mysql_redis_25 / mysql_redis / 6526b59
Reports root/ big
OK: 3805 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 6526b59
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6526b59
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 6526b59
Reports root/ big
OK: 2112 / Failed: 0 / User-skipped: 625 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 6526b59
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6526b59
Reports root/ big
OK: 2452 / Failed: 0 / User-skipped: 620 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6526b59
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 6526b59
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 6526b59
Reports root/ big
OK: 4191 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 6526b59
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 612 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 6526b59
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

Paweł Chrząszcz added 5 commits September 30, 2022 10:32
Previously it was plain text, but the Content-Type was application/json
This caused issues with the interactive Swagger UI - it displayed "no
response from server". Now it displays the errors correctly.

Tests don't need changing, because they are decoding JSON
automatically, and the result is the same text as before.
They got outdated, and it is difficult to keep the up to date.
Moreover, for the remaining operations there are no error examples.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 30, 2022

small_tests_24 / small_tests / 2d4ea88
Reports root / small


small_tests_25 / small_tests / 2d4ea88
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 2d4ea88
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 2d4ea88
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 2d4ea88
Reports root/ big
OK: 3805 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2d4ea88
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 2d4ea88
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 746 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 2d4ea88
Reports root/ big
OK: 2112 / Failed: 0 / User-skipped: 625 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 2d4ea88
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 2d4ea88
Reports root/ big
OK: 3831 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 2d4ea88
Reports root/ big
OK: 2452 / Failed: 0 / User-skipped: 620 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 2d4ea88
Reports root/ big
OK: 4205 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 2d4ea88
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 612 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 2d4ea88
Reports root/ big
OK: 4191 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 2d4ea88
Reports root/ big
OK: 4213 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

disco_and_caps_SUITE:disco_with_caps:user_can_query_friend_features
{error,{{assertion_failed,assert_many,false,[is_roster_set],[],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,108}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log

@chrzaszcz chrzaszcz marked this pull request as ready for review September 30, 2022 09:05
Copy link

@kamilwaz kamilwaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@kamilwaz kamilwaz merged commit b88ec04 into feature/unified-rest-api Oct 3, 2022
@kamilwaz kamilwaz deleted the unified-rest-api-docs branch October 3, 2022 11:59
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants