-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes graphql suites #3783
Fixes graphql suites #3783
Conversation
small_tests_24 / small_tests / 0a21d19 ldap_mnesia_24 / ldap_mnesia / 0a21d19 small_tests_25 / small_tests / 0a21d19 ldap_mnesia_25 / ldap_mnesia / 0a21d19 internal_mnesia_25 / internal_mnesia / 0a21d19 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0a21d19 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 0a21d19 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 0a21d19 dynamic_domains_mysql_redis_25 / mysql_redis / 0a21d19 graphql_session_SUITE:admin_session:admin_session_http:admin_count_sessions{error,
{{assertEqual,
[{module,graphql_session_SUITE},
{line,126},
{expression,"Number"},
{expected,3},
{value,0}]},
[{graphql_session_SUITE,admin_count_sessions_story,4,
[{file,
"/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
{line,126}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} graphql_session_SUITE:admin_session:admin_session_cli:admin_count_sessions{error,
{{assertEqual,
[{module,graphql_session_SUITE},
{line,126},
{expression,"Number"},
{expected,3},
{value,0}]},
[{graphql_session_SUITE,admin_count_sessions_story,4,
[{file,
"/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
{line,126}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} pgsql_mnesia_25 / pgsql_mnesia / 0a21d19 mysql_redis_25 / mysql_redis / 0a21d19 graphql_session_SUITE:admin_session:admin_session_http:admin_count_sessions{error,
{{assertEqual,
[{module,graphql_session_SUITE},
{line,126},
{expression,"Number"},
{expected,3},
{value,0}]},
[{graphql_session_SUITE,admin_count_sessions_story,4,
[{file,
"/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
{line,126}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} graphql_session_SUITE:admin_session:admin_session_cli:admin_count_sessions{error,
{{assertEqual,
[{module,graphql_session_SUITE},
{line,126},
{expression,"Number"},
{expected,3},
{value,0}]},
[{graphql_session_SUITE,admin_count_sessions_story,4,
[{file,
"/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
{line,126}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} metrics_session_SUITE:session_global:session_global{error,
{{totalSessionCount,
{value,1},
[{times,25,
{error,
{badmatch,{value,0}},
[{metrics_helper,assert_counter,3,
[{file,
"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,36}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} rest_SUITE:admin:session_can_be_kicked{error,{test_case_failed,[70,97,105,108,58,32,
[60,60,
"\"alice_session_can_be_kicked_1475@localhost/res1\"",
62,62],
32,105,110,32,
[91,
[[60,60,
"\"alice_session_can_be_kicked_1475@localhost/res1\"",
62,62],
44,10,
[32,32,
[32,
[32,[32," ",32,32,32],32," ",32,32,32],
32,
[32," ",32,32,32],
32," ",32,32,32],
32,
[32,[32," ",32,32,32],32," ",32,32,32],
32,
[32," ",32,32,32],
32," ",32,32,32],
[60,60,
"\"alice_messages_can_be_paginated_1477@localhost/res1\"",
62,62]],
93]]}} riak_mnesia_24 / riak_mnesia / 0a21d19 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 0a21d19 last_SUITE:valid_queries:last_offline_user{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"presence">>,
[{<<"from">>,<<"[email protected]/res1">>},
{<<"to">>,<<"[email protected]/res1">>},
{<<"type">>,<<"unavailable">>}],
[{xmlel,<<"status">>,[],[{xmlcdata,<<"Unknown condition">>}]}]},
"<presence from='[email protected]/res1' to='[email protected]/res1' type='unavailable'><status>Unknown condition</status></presence>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_session,session,1,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,131}]},
{escalus_session,session,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,273}]},
{escalus_connection,connection_step,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{escalus_connection,start,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{escalus_client,start,3,
[{file,
"/home/circleci/project/big_tests/_b... mssql_mnesia_25 / odbc_mssql_mnesia / 0a21d19 |
Codecov ReportBase: 68.11% // Head: 63.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature/mongoose_c2s #3783 +/- ##
========================================================
- Coverage 68.11% 63.11% -5.00%
========================================================
Files 536 536
Lines 35005 34878 -127
========================================================
- Hits 23842 22014 -1828
- Misses 11163 12864 +1701
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ldap_mnesia_24 / ldap_mnesia / c7686af small_tests_24 / small_tests / c7686af ldap_mnesia_25 / ldap_mnesia / c7686af small_tests_25 / small_tests / c7686af pgsql_mnesia_24 / pgsql_mnesia / c7686af internal_mnesia_25 / internal_mnesia / c7686af elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c7686af dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c7686af dynamic_domains_mysql_redis_25 / mysql_redis / c7686af pgsql_mnesia_25 / pgsql_mnesia / c7686af dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c7686af riak_mnesia_24 / riak_mnesia / c7686af mysql_redis_25 / mysql_redis / c7686af mssql_mnesia_25 / odbc_mssql_mnesia / c7686af |
ldap_mnesia_24 / ldap_mnesia / 55d5805 small_tests_24 / small_tests / 55d5805 ldap_mnesia_25 / ldap_mnesia / 55d5805 small_tests_25 / small_tests / 55d5805 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 55d5805 internal_mnesia_25 / internal_mnesia / 55d5805 pgsql_mnesia_24 / pgsql_mnesia / 55d5805 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 55d5805 dynamic_domains_mysql_redis_25 / mysql_redis / 55d5805 mysql_redis_25 / mysql_redis / 55d5805 pgsql_mnesia_25 / pgsql_mnesia / 55d5805 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 55d5805 riak_mnesia_24 / riak_mnesia / 55d5805 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent code! Only needs rebasing to solve conflicts, and a small whitespace not needed.
src/c2s/mongoose_c2s_socket.erl
Outdated
@@ -172,3 +174,9 @@ is_ssl(#c2s_socket{transport = Transport}) -> | |||
-spec get_ip(socket()) -> term(). | |||
get_ip(#c2s_socket{ip = Ip}) -> | |||
Ip. | |||
|
|||
-spec get_conn_type(socket()) -> conntype(). | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary white line.
b4c6695
to
f8a72fe
Compare
small_tests_24 / small_tests / 09404bc ldap_mnesia_24 / ldap_mnesia / 09404bc small_tests_25 / small_tests / 09404bc ldap_mnesia_25 / ldap_mnesia / 09404bc dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 09404bc dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 09404bc pgsql_mnesia_24 / pgsql_mnesia / 09404bc internal_mnesia_25 / internal_mnesia / 09404bc elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 09404bc dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 09404bc pgsql_mnesia_25 / pgsql_mnesia / 09404bc mssql_mnesia_25 / odbc_mssql_mnesia / 09404bc service_domain_db_SUITE:db:db_event_could_appear_with_lower_id{error,
{{badmatch,534},
[{service_domain_db_SUITE,db_event_could_appear_with_lower_id,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,698}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mysql_redis_25 / mysql_redis / 09404bc riak_mnesia_24 / riak_mnesia / 09404bc mssql_mnesia_25 / odbc_mssql_mnesia / 09404bc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent 👌🏽
Fixes graphql suites.