Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C2s/pubsub #3785

Merged
merged 2 commits into from
Oct 4, 2022
Merged

C2s/pubsub #3785

merged 2 commits into from
Oct 4, 2022

Conversation

NelsonVides
Copy link
Collaborator

Really what needed fixing was the from verification in the core c2s code, that enabled not only pubsub but also another bunch of suites.

@NelsonVides
Fix stream from verification
cfae222 
https://datatracker.ietf.org/doc/html/rfc6120#section-8.1.2.1
1.  When a server receives an XML stanza from a connected client, the
       server MUST add a 'from' attribute to the stanza or override the
       'from' attribute specified by the client, where the value of the
       'from' attribute MUST be the full JID
       (<localpart@domainpart/resource>) determined by the server for
       the connected resource that generated the stanza (see
       Section 4.3.6), or the bare JID (<localpart@domainpart>) in the
       case of subscription-related presence stanzas (see [XMPP-IM]).
@NelsonVides
Reenable several suites that can pass already
e555aae
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 3, 2022 •
edited
Loading

small_tests_24 / small_tests / e555aae
Reports root / small

ldap_mnesia_24 / ldap_mnesia / e555aae
Reports root/ big
OK: 1218 / Failed: 0 / User-skipped: 431 / Auto-skipped: 0

small_tests_25 / small_tests / e555aae
Reports root / small

ldap_mnesia_25 / ldap_mnesia / e555aae
Reports root/ big
OK: 1218 / Failed: 0 / User-skipped: 431 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / e555aae
Reports root/ big
OK: 2880 / Failed: 0 / User-skipped: 68 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / e555aae
Reports root/ big
OK: 3125 / Failed: 0 / User-skipped: 79 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / e555aae
Reports root/ big
OK: 1280 / Failed: 0 / User-skipped: 369 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / e555aae
Reports root/ big
OK: 2880 / Failed: 0 / User-skipped: 68 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / e555aae
Reports root/ big
OK: 2863 / Failed: 0 / User-skipped: 85 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / e555aae
Reports root/ big
OK: 1618 / Failed: 0 / User-skipped: 366 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / e555aae
Reports root/ big
OK: 2880 / Failed: 0 / User-skipped: 68 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / e555aae
Reports root/ big
OK: 3125 / Failed: 0 / User-skipped: 79 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / e555aae
Reports root/ big
OK: 1463 / Failed: 0 / User-skipped: 353 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / e555aae
Reports root/ big
OK: 3120 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / e555aae
Reports root/ big
OK: 3125 / Failed: 0 / User-skipped: 79 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 3, 2022 •
edited
Loading

Codecov Report

Base: 64.42% // Head: 68.07% // Increases project coverage by +3.64% 🎉

Coverage data is based on head (e555aae) compared to base (6f9302e).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@                   Coverage Diff                    @@
##           feature/mongoose_c2s    #3785      +/-   ##
========================================================
+ Coverage                 64.42%   68.07%   +3.64%     
========================================================
  Files                       536      536              
  Lines                     35002    35005       +3     
========================================================
+ Hits                      22551    23828    +1277     
+ Misses                    12451    11177    -1274
Impacted Files Coverage Δ
src/c2s/mongoose_c2s.erl 64.30% <75.00%> (+0.01%) ⬆️
src/ejabberd.erl 45.00% <0.00%> (-10.00%) ⬇️
src/metrics/mongoose_metrics_probe.erl 57.14% <0.00%> (-9.53%) ⬇️
src/mod_bosh.erl 93.43% <0.00%> (-2.19%) ⬇️
src/rdbms/mongoose_rdbms.erl 65.26% <0.00%> (-1.06%) ⬇️
src/mod_bosh_socket.erl 76.70% <0.00%> (-0.94%) ⬇️
src/ejabberd_c2s.erl 39.49% <0.00%> (+0.22%) ⬆️
src/jlib.erl 80.92% <0.00%> (+0.57%) ⬆️
src/ejabberd_receiver.erl 44.36% <0.00%> (+0.70%) ⬆️
src/mod_roster.erl 76.79% <0.00%> (+0.95%) ⬆️
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

chrzaszcz
chrzaszcz approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit 121cdf9 into feature/mongoose_c2s Oct 4, 2022
@chrzaszcz chrzaszcz deleted the c2s/pubsub branch October 4, 2022 06:22
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
mongoose_c2s
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@NelsonVides @mongoose-im @chrzaszcz @jacekwegr