Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored hook handler in mod_global_distrib_disco module #3792

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

pawlooss1
Copy link
Member

@pawlooss1 pawlooss1 commented Oct 5, 2022

This PR changes all hook handlers in mod_global_distrib_disco module to gen_hook format.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 5, 2022

small_tests_24 / small_tests / 194afcc
Reports root / small


small_tests_25 / small_tests / 194afcc
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 194afcc
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 748 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 194afcc
Reports root/ big
OK: 3833 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 194afcc
Reports root/ big
OK: 3833 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 194afcc
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 748 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 194afcc
Reports root/ big
OK: 3807 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 194afcc
Reports root/ big
OK: 2112 / Failed: 0 / User-skipped: 627 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 194afcc
Reports root/ big
OK: 2452 / Failed: 0 / User-skipped: 622 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 194afcc
Reports root/ big
OK: 4218 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2541@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2541@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"9Rl9e1QSRSVl9ngmJO5ZKg==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 194afcc
Reports root/ big
OK: 3832 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

inbox_extensions_SUITE:async_pools:one_to_one:mute_muted_entry_gets_unmuted
{error,
  {{assert,
     [{module,inbox_extensions_SUITE},
      {line,798},
      {expression,"escalus_pred : is_message ( Message )"},
      {expected,true},
      {value,false}]},
   [{inbox_extensions_SUITE,check_message_with_properties,4,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,798}]},
    {inbox_extensions_SUITE,set_inbox_properties,4,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,792}]},
    {inbox_extensions_SUITE,'-mute_muted_entry_gets_unmuted/1-fun-2-',2,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,568}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


pgsql_mnesia_25 / pgsql_mnesia / 194afcc
Reports root/ big
OK: 4207 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 194afcc
Reports root/ big
OK: 2291 / Failed: 1 / User-skipped: 614 / Auto-skipped: 0

muc_http_api_SUITE:negative:kick_user_errors
{error,{{timeout,ok,[{times,50,not_yet}]},
    [{mongoose_helper,do_wait_until,2,
              [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
               {line,371}]},
     {muc_http_api_SUITE,kick_user_errors,1,
               [{file,"/home/circleci/project/big_tests/tests/muc_http_api_SUITE.erl"},
                {line,325}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log


mysql_redis_25 / mysql_redis / 194afcc
Reports root/ big
OK: 4192 / Failed: 1 / User-skipped: 111 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mssql_mnesia_25 / odbc_mssql_mnesia / 194afcc
Reports root/ big
OK: 4207 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 194afcc
Reports root/ big
OK: 3833 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 194afcc
Reports root/ big
OK: 4193 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 194afcc
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 614 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 82.92% // Head: 82.89% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (194afcc) compared to base (6748ca4).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3792      +/-   ##
==========================================
- Coverage   82.92%   82.89%   -0.04%     
==========================================
  Files         529      529              
  Lines       33810    33812       +2     
==========================================
- Hits        28038    28028      -10     
- Misses       5772     5784      +12     
Impacted Files Coverage Δ
src/global_distrib/mod_global_distrib_disco.erl 78.57% <83.33%> (+1.64%) ⬆️
src/mongoose_hooks.erl 96.05% <100.00%> (+0.01%) ⬆️
src/event_pusher/mod_event_pusher_sns.erl 82.19% <0.00%> (-15.07%) ⬇️
src/ejabberd.erl 45.00% <0.00%> (-10.00%) ⬇️
src/mod_roster_riak.erl 96.92% <0.00%> (-1.54%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 69.11% <0.00%> (-1.48%) ⬇️
src/mod_roster.erl 78.70% <0.00%> (-0.72%) ⬇️
src/ejabberd_c2s.erl 89.01% <0.00%> (-0.30%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/mam/mod_mam_elasticsearch_arch.erl 88.39% <0.00%> (+1.78%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pawlooss1 pawlooss1 marked this pull request as ready for review October 5, 2022 07:48
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@NelsonVides NelsonVides merged commit 650da9f into master Oct 5, 2022
@NelsonVides NelsonVides deleted the hooks/mod_global_distrib_disco branch October 5, 2022 11:29
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants