Set default value when null is passed to GraphQL API #3803
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 82.87% // Head: 82.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3803 +/- ##
==========================================
+ Coverage 82.87% 82.91% +0.04%
==========================================
Files 529 529
Lines 33808 33810 +2
==========================================
+ Hits 28017 28035 +18
+ Misses 5791 5775 -16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jacekwegr
force-pushed
the
set-default-when-null-is-passed-explicitly
branch
from
3b1c40d
to
a8bde9d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
rebar.config
Outdated
| @@ -77,7 +77,7 @@ | |||
| {worker_pool, "6.0.1"}, | |||
|
|
|||
| %%% HTTP tools | |||
| {graphql, {git, "https://github.com/esl/graphql-erlang.git", {branch, "master"}}}, | |||
| {graphql, {git, "https://github.com/esl/graphql-erlang.git", {branch, "set-default-when-null-is-passed-explicitly"}}}, | |||
There was a problem hiding this comment.
this should be changed back to master after the library is merged
jacekwegr
force-pushed
the
set-default-when-null-is-passed-explicitly
branch
from
a8bde9d
to
def8dce
Compare
|
small_tests_24 / small_tests / def8dce small_tests_25 / small_tests / def8dce ldap_mnesia_24 / ldap_mnesia / def8dce dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / def8dce ldap_mnesia_25 / ldap_mnesia / def8dce dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / def8dce internal_mnesia_25 / internal_mnesia / def8dce elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / def8dce dynamic_domains_mysql_redis_25 / mysql_redis / def8dce pgsql_mnesia_24 / pgsql_mnesia / def8dce dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / def8dce pgsql_mnesia_25 / pgsql_mnesia / def8dce mysql_redis_25 / mysql_redis / def8dce mssql_mnesia_25 / odbc_mssql_mnesia / def8dce muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}smart_markers_SUITE:regular:one2one:remove_markers_when_removed_user{error,{{timeout,true,[{times,50,false}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{smart_markers_SUITE,'-remove_markers_when_removed_user/1-fun-2-',2,
[{file,"/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
{line,244}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}riak_mnesia_24 / riak_mnesia / def8dce mssql_mnesia_25 / odbc_mssql_mnesia / def8dce |
This PR changes how arguments are processed before being passed to the resolver. When an argument has an explicit null value, the GraphQL library tries to set its value to a default one if one exists.