Refactored hook handlers in mod_caps module #3811
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 82.99% // Head: 83.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3811 +/- ##
==========================================
+ Coverage 82.99% 83.05% +0.05%
==========================================
Files 529 529
Lines 33834 33862 +28
==========================================
+ Hits 28081 28124 +43
+ Misses 5753 5738 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pawlooss1
force-pushed
the
hooks/mod_caps
branch
from
4d535df
to
34f3a49
Compare
This comment was marked as outdated.
This comment was marked as outdated.
pawlooss1
force-pushed
the
hooks/mod_caps
branch
from
34f3a49
to
17fd765
Compare
This comment was marked as outdated.
This comment was marked as outdated.
pawlooss1
force-pushed
the
hooks/mod_caps
branch
from
17fd765
to
c1bfa5b
Compare
|
small_tests_24 / small_tests / c1bfa5b small_tests_25 / small_tests / c1bfa5b ldap_mnesia_24 / ldap_mnesia / c1bfa5b dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c1bfa5b dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c1bfa5b ldap_mnesia_25 / ldap_mnesia / c1bfa5b dynamic_domains_mysql_redis_25 / mysql_redis / c1bfa5b internal_mnesia_25 / internal_mnesia / c1bfa5b dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c1bfa5b pgsql_mnesia_24 / pgsql_mnesia / c1bfa5b elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c1bfa5b graphql_server_SUITE:admin_http:clustering_http_tests:remove_node_test{error,{{badmatch,{error,econnrefused}},
[{rest_helper,fusco_request,7,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,185}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,114}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,121}]},
{graphql_server_SUITE,remove_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,210}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}graphql_server_SUITE:admin_http:clustering_http_tests:stop_node_test{error,{{badmatch,{error,econnrefused}},
[{rest_helper,fusco_request,7,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,185}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,114}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,121}]},
{graphql_server_SUITE,stop_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,215}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}pgsql_mnesia_25 / pgsql_mnesia / c1bfa5b mysql_redis_25 / mysql_redis / c1bfa5b mssql_mnesia_25 / odbc_mssql_mnesia / c1bfa5b riak_mnesia_24 / riak_mnesia / c1bfa5b elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c1bfa5b |
There was a problem hiding this comment.
LGTM 👌🏽
We probably need to check in the future if mod_caps is using the most efficient algorithms, I already skimmed through some gb_trees and some more usages of dropping keys to stop a hook, but that's work for a future different refactoring, just taking notes for now 😁
This PR changes all hook handlers in
mod_capsmodule togen_hookformat.