-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored hook handlers in mod_smart_markers #3825
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 83.02% // Head: 83.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3825 +/- ##
==========================================
+ Coverage 83.02% 83.04% +0.02%
==========================================
Files 528 528
Lines 33877 33885 +8
==========================================
+ Hits 28127 28141 +14
+ Misses 5750 5744 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2db4e38
to
8d04b71
Compare
small_tests_24 / small_tests / 8d04b71 small_tests_25 / small_tests / 8d04b71 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8d04b71 ldap_mnesia_24 / ldap_mnesia / 8d04b71 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8d04b71 ldap_mnesia_25 / ldap_mnesia / 8d04b71 dynamic_domains_mysql_redis_25 / mysql_redis / 8d04b71 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8d04b71 internal_mnesia_25 / internal_mnesia / 8d04b71 pgsql_mnesia_24 / pgsql_mnesia / 8d04b71 riak_mnesia_24 / riak_mnesia / 8d04b71 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8d04b71 pgsql_mnesia_25 / pgsql_mnesia / 8d04b71 mysql_redis_25 / mysql_redis / 8d04b71 mssql_mnesia_25 / odbc_mssql_mnesia / 8d04b71 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👌🏽
This PR changes all hook handlers in
mod_smart_markers
module togen_hook
format. Also, I did a little refactoring ofmod_smart_markers :room_new_affiliations
function.