Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored hook handlers in mod_smart_markers #3825

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

pawlooss1
Copy link
Member

This PR changes all hook handlers in mod_smart_markers module to gen_hook format. Also, I did a little refactoring of mod_smart_markers :room_new_affiliations function.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 83.02% // Head: 83.04% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (8d04b71) compared to base (75c9692).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3825      +/-   ##
==========================================
+ Coverage   83.02%   83.04%   +0.02%     
==========================================
  Files         528      528              
  Lines       33877    33885       +8     
==========================================
+ Hits        28127    28141      +14     
+ Misses       5750     5744       -6     
Impacted Files Coverage Δ
src/mongoose_hooks.erl 97.16% <100.00%> (+0.05%) ⬆️
src/smart_markers/mod_smart_markers.erl 96.73% <100.00%> (+1.18%) ⬆️
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 70.58% <0.00%> (-2.95%) ⬇️
src/mam/mod_mam_muc_rdbms_arch_async.erl 82.85% <0.00%> (-2.86%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 86.60% <0.00%> (-1.79%) ⬇️
src/ejabberd_s2s_out.erl 62.53% <0.00%> (-0.75%) ⬇️
src/pubsub/node_pep.erl 79.62% <0.00%> (+1.85%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.11% <0.00%> (+4.44%) ⬆️
src/event_pusher/mod_event_pusher_sns.erl 97.26% <0.00%> (+15.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 25, 2022

small_tests_24 / small_tests / 8d04b71
Reports root / small


small_tests_25 / small_tests / 8d04b71
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8d04b71
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 8d04b71
Reports root/ big
OK: 2103 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8d04b71
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 8d04b71
Reports root/ big
OK: 2103 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 8d04b71
Reports root/ big
OK: 3968 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8d04b71
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 8d04b71
Reports root/ big
OK: 2239 / Failed: 0 / User-skipped: 648 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 8d04b71
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 8d04b71
Reports root/ big
OK: 2427 / Failed: 0 / User-skipped: 627 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8d04b71
Reports root/ big
OK: 2581 / Failed: 0 / User-skipped: 641 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 8d04b71
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 8d04b71
Reports root/ big
OK: 4354 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 8d04b71
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@pawlooss1 pawlooss1 marked this pull request as ready for review October 25, 2022 12:13
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌🏽

@NelsonVides NelsonVides merged commit edccf71 into master Oct 25, 2022
@NelsonVides NelsonVides deleted the hooks/mod_smart_markers branch October 25, 2022 15:11
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants