Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored hook handlers in mod_global_distrib_mapping #3831

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

pawlooss1
Copy link
Member

This PR changes all hook handlers in mod_global_distrib_mapping module to gen_hook format.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 28, 2022

small_tests_24 / small_tests / ca354f4
Reports root / small


small_tests_25 / small_tests / ca354f4
Reports root / small


ldap_mnesia_24 / ldap_mnesia / ca354f4
Reports root/ big
OK: 2103 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ca354f4
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / ca354f4
Reports root/ big
OK: 2103 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ca354f4
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / ca354f4
Reports root/ big
OK: 3968 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ca354f4
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / ca354f4
Reports root/ big
OK: 2239 / Failed: 0 / User-skipped: 648 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / ca354f4
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ca354f4
Reports root/ big
OK: 2581 / Failed: 0 / User-skipped: 641 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / ca354f4
Reports root/ big
OK: 2427 / Failed: 0 / User-skipped: 627 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / ca354f4
Reports root/ big
OK: 4379 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2634@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2634@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"5lgRC3tMair+tMwnX8DCvw==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mssql_mnesia_25 / odbc_mssql_mnesia / ca354f4
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / ca354f4
Reports root/ big
OK: 4354 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 80.57% // Head: 83.05% // Increases project coverage by +2.48% 🎉

Coverage data is based on head (6d78f3d) compared to base (dc32b41).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3831      +/-   ##
==========================================
+ Coverage   80.57%   83.05%   +2.48%     
==========================================
  Files         528      528              
  Lines       33910    33920      +10     
==========================================
+ Hits        27322    28172     +850     
+ Misses       6588     5748     -840     
Impacted Files Coverage Δ
src/global_distrib/mod_global_distrib_mapping.erl 97.72% <100.00%> (+0.02%) ⬆️
src/mongoose_hooks.erl 96.55% <100.00%> (+0.09%) ⬆️
src/mam/mod_mam_muc_rdbms_arch_async.erl 82.85% <0.00%> (-2.86%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 66.66% <0.00%> (-2.23%) ⬇️
src/muc_light/mod_muc_light_db_mnesia.erl 91.57% <0.00%> (-1.06%) ⬇️
src/ejabberd_c2s.erl 88.95% <0.00%> (-0.08%) ⬇️
src/mod_roster.erl 78.94% <0.00%> (+0.23%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.82% <0.00%> (+0.42%) ⬆️
src/mam/mod_mam_utils.erl 89.63% <0.00%> (+0.91%) ⬆️
src/global_distrib/mod_global_distrib_receiver.erl 80.72% <0.00%> (+1.20%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pawlooss1 pawlooss1 force-pushed the hooks/mod_global_distrib_mapping branch from ca354f4 to 6d78f3d Compare October 28, 2022 11:46
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 28, 2022

small_tests_24 / small_tests / 6d78f3d
Reports root / small


small_tests_25 / small_tests / 6d78f3d
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 6d78f3d
Reports root/ big
OK: 2103 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6d78f3d
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6d78f3d
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 6d78f3d
Reports root/ big
OK: 2103 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 6d78f3d
Reports root/ big
OK: 3967 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log


internal_mnesia_25 / internal_mnesia / 6d78f3d
Reports root/ big
OK: 2239 / Failed: 0 / User-skipped: 648 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 6d78f3d
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6d78f3d
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6d78f3d
Reports root/ big
OK: 2581 / Failed: 0 / User-skipped: 641 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 6d78f3d
Reports root/ big
OK: 2427 / Failed: 0 / User-skipped: 627 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 6d78f3d
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 6d78f3d
Reports root/ big
OK: 4354 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 6d78f3d
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 6d78f3d
Reports root/ big
OK: 3968 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

@pawlooss1 pawlooss1 marked this pull request as ready for review October 31, 2022 07:02
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@NelsonVides NelsonVides merged commit 0231bf3 into master Oct 31, 2022
@NelsonVides NelsonVides deleted the hooks/mod_global_distrib_mapping branch October 31, 2022 11:41
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants