-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored hook handlers in mod_global_distrib_mapping #3831
Conversation
small_tests_24 / small_tests / ca354f4 small_tests_25 / small_tests / ca354f4 ldap_mnesia_24 / ldap_mnesia / ca354f4 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ca354f4 ldap_mnesia_25 / ldap_mnesia / ca354f4 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ca354f4 dynamic_domains_mysql_redis_25 / mysql_redis / ca354f4 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ca354f4 internal_mnesia_25 / internal_mnesia / ca354f4 pgsql_mnesia_24 / pgsql_mnesia / ca354f4 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ca354f4 riak_mnesia_24 / riak_mnesia / ca354f4 pgsql_mnesia_25 / pgsql_mnesia / ca354f4 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2634@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2634@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"5lgRC3tMair+tMwnX8DCvw==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mssql_mnesia_25 / odbc_mssql_mnesia / ca354f4 mysql_redis_25 / mysql_redis / ca354f4 |
Codecov ReportBase: 80.57% // Head: 83.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3831 +/- ##
==========================================
+ Coverage 80.57% 83.05% +2.48%
==========================================
Files 528 528
Lines 33910 33920 +10
==========================================
+ Hits 27322 28172 +850
+ Misses 6588 5748 -840
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ca354f4
to
6d78f3d
Compare
small_tests_24 / small_tests / 6d78f3d small_tests_25 / small_tests / 6d78f3d ldap_mnesia_24 / ldap_mnesia / 6d78f3d dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6d78f3d dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6d78f3d ldap_mnesia_25 / ldap_mnesia / 6d78f3d dynamic_domains_mysql_redis_25 / mysql_redis / 6d78f3d muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} internal_mnesia_25 / internal_mnesia / 6d78f3d pgsql_mnesia_24 / pgsql_mnesia / 6d78f3d dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6d78f3d elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6d78f3d riak_mnesia_24 / riak_mnesia / 6d78f3d pgsql_mnesia_25 / pgsql_mnesia / 6d78f3d mysql_redis_25 / mysql_redis / 6d78f3d mssql_mnesia_25 / odbc_mssql_mnesia / 6d78f3d dynamic_domains_mysql_redis_25 / mysql_redis / 6d78f3d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏽
This PR changes all hook handlers in
mod_global_distrib_mapping
module togen_hook
format.