Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ejabberd_auth to gen_hook #3832

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Convert ejabberd_auth to gen_hook #3832

merged 1 commit into from
Nov 2, 2022

Conversation

kamilwaz
Copy link

Convert ejabberd_auth to gen_hook

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 28, 2022

pgsql_mnesia_24 / pgsql_mnesia / bae9bd1
Reports root


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / bae9bd1
Reports root


ldap_mnesia_24 / ldap_mnesia / bae9bd1
Reports root


riak_mnesia_24 / riak_mnesia / bae9bd1
Reports root


dynamic_domains_mysql_redis_25 / mysql_redis / bae9bd1
Reports root


pgsql_mnesia_25 / pgsql_mnesia / bae9bd1
Reports root


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / bae9bd1
Reports root


ldap_mnesia_25 / ldap_mnesia / bae9bd1
Reports root


mysql_redis_25 / mysql_redis / bae9bd1
Reports root


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / bae9bd1
Reports root


mssql_mnesia_25 / odbc_mssql_mnesia / bae9bd1
Reports root


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / bae9bd1
Reports root


small_tests_24 / small_tests / bae9bd1
Reports root / small


small_tests_25 / small_tests / bae9bd1
Reports root / small

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 28, 2022

small_tests_24 / small_tests / 961d3ec
Reports root / small


small_tests_25 / small_tests / 961d3ec
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 961d3ec
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 961d3ec
Reports root/ big
OK: 2103 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 961d3ec
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 961d3ec
Reports root/ big
OK: 3968 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 961d3ec
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 961d3ec
Reports root/ big
OK: 2581 / Failed: 0 / User-skipped: 641 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 961d3ec
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 961d3ec
Reports root/ big
OK: 2239 / Failed: 0 / User-skipped: 648 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 961d3ec
Reports root/ big
OK: 2427 / Failed: 0 / User-skipped: 627 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 961d3ec
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 961d3ec
Reports root/ big
OK: 4354 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 961d3ec
Reports root/ big
OK: 2102 / Failed: 1 / User-skipped: 784 / Auto-skipped: 0

service_mongoose_system_metrics_SUITE:system_metrics_are_reported_to_configurable_google_analytics
{error,
  {{assertEqual,
     [{module,service_mongoose_system_metrics_SUITE},
      {line,470},
      {expression,"ActualTrackingIds"},
      {expected,[<<"UA-151671255-1">>,<<"UA-EXTRA-TRACKING-ID">>]},
      {value,[<<"UA-151671255-1">>]}]},
   [{service_mongoose_system_metrics_SUITE,
      events_are_reported_to_tracking_ids,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
       {line,470}]},
    {service_mongoose_system_metrics_SUITE,
      system_metrics_are_reported_to_configurable_google_analytics,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
       {line,204}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


mssql_mnesia_25 / odbc_mssql_mnesia / 961d3ec
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 80.57% // Head: 83.01% // Increases project coverage by +2.44% 🎉

Coverage data is based on head (b5d03f1) compared to base (dc32b41).
Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3832      +/-   ##
==========================================
+ Coverage   80.57%   83.01%   +2.44%     
==========================================
  Files         528      528              
  Lines       33910    33910              
==========================================
+ Hits        27322    28152     +830     
+ Misses       6588     5758     -830     
Impacted Files Coverage Δ
src/auth/ejabberd_auth.erl 85.34% <33.33%> (-0.23%) ⬇️
src/auth/ejabberd_auth_anonymous.erl 72.13% <71.42%> (+1.81%) ⬆️
src/mongoose_hooks.erl 96.52% <100.00%> (+0.06%) ⬆️
src/ejabberd.erl 55.00% <0.00%> (-5.00%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 66.66% <0.00%> (-2.23%) ⬇️
src/rdbms/mongoose_rdbms.erl 65.26% <0.00%> (-1.06%) ⬇️
src/muc_light/mod_muc_light_db_mnesia.erl 91.57% <0.00%> (-1.06%) ⬇️
src/mod_muc_room.erl 78.28% <0.00%> (-0.40%) ⬇️
src/ejabberd_c2s.erl 88.95% <0.00%> (-0.08%) ⬇️
src/pubsub/mod_pubsub.erl 73.35% <0.00%> (+0.12%) ⬆️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 28, 2022

small_tests_24 / small_tests / b5d03f1
Reports root / small


small_tests_25 / small_tests / b5d03f1
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b5d03f1
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / b5d03f1
Reports root/ big
OK: 2103 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b5d03f1
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / b5d03f1
Reports root/ big
OK: 3968 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / b5d03f1
Reports root/ big
OK: 2121 / Failed: 1 / User-skipped: 784 / Auto-skipped: 0

pubsub_SUITE:tree+basic:subscribe_unsubscribe_test
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,491}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,481}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,471}]},
     {pubsub_SUITE,'-subscribe_unsubscribe_test/1-fun-0-',2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
            {line,419}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b5d03f1
Reports root/ big
OK: 3993 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

muc_SUITE:register:user_changes_nick
{error,
  {{assertion_failed,assert,is_iq_result,
     [{xmlel,<<"iq">>,
        [{<<"type">>,<<"set">>},
         {<<"id">>,<<"788644282307700ce139e6c0f0cde697">>},
         {<<"to">>,<<"groupchats.domain.example.com">>}],
        [{xmlel,<<"query">>,
           [{<<"xmlns">>,<<"jabber:iq:register">>}],
           [{xmlel,<<"x">>,
            [{<<"xmlns">>,<<"jabber:x:data">>},
             {<<"type">>,<<"submit">>}],
            [{xmlel,<<"field">>,
               [{<<"type">>,<<"hidden">>},
                {<<"var">>,<<"FORM_TYPE">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,<<"jabber:iq:register">>}]}]},
             {xmlel,<<"field">>,
               [{<<"type">>,<<"text-single">>},
                {<<"var">>,<<"nick">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,
                     <<"thirdwitch1room-39bb6c0484">>}]}]}]}]}]}],
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"groupchats.domain.example.com">>},
        {<<"to">>,
         <<"[email protected]/res1">>},
        {<<"type">>,<<"error">>},
        {<<"xml:lang">>,<<"en">>},
        {<<"id">>,<<"788644282307700ce139e6c0f0cde697">>}],
       [{xmlel,<<"query">>,
          [{<<"xmlns">>,<<"jabber:iq:register">>}],
          [{xmlel,<<"x">>,
             [{<<"xmlns">>,<<"jabber:x:data">>},
            {<<"type">>,<<"submit">>}],
             [{xmlel,<<"field">>,
              [{<<"type">>,<<"hidden">>},
               {<<"var">>,<<...

Report log


internal_mnesia_25 / internal_mnesia / b5d03f1
Reports root/ big
OK: 2239 / Failed: 0 / User-skipped: 648 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / b5d03f1
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b5d03f1
Reports root/ big
OK: 2581 / Failed: 0 / User-skipped: 641 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / b5d03f1
Reports root/ big
OK: 2427 / Failed: 0 / User-skipped: 627 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / b5d03f1
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / b5d03f1
Reports root/ big
OK: 4354 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / b5d03f1
Reports root/ big
OK: 4379 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2635@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2635@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"RE5J0LMgfrQjjFem5aFRnw==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b5d03f1
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

@kamilwaz kamilwaz marked this pull request as ready for review November 2, 2022 07:40
Copy link
Member

@pawlooss1 pawlooss1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👌

@pawlooss1 pawlooss1 merged commit 7b0c015 into master Nov 2, 2022
@pawlooss1 pawlooss1 deleted the hooks/ejabberd_auth branch November 2, 2022 09:53
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants