Refactored hook handlers in mod_http_upload #3835
Conversation
|
small_tests_24 / small_tests / 7bdae88 small_tests_25 / small_tests / 7bdae88 ldap_mnesia_24 / ldap_mnesia / 7bdae88 rest_client_SUITE:messages:msg_is_sent_and_delivered_over_sse{error,{{badmap,{error,timeout}},
[{erlang,map_get,
[data,{error,timeout}],
[{error_info,#{module => erl_erts_errors}}]},
{rest_client_SUITE,msg_is_sent_and_delivered_over_sse,1,
[{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,235}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7bdae88 dynamic_domains_mysql_redis_25 / mysql_redis / 7bdae88 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 7bdae88 ldap_mnesia_25 / ldap_mnesia / 7bdae88 internal_mnesia_25 / internal_mnesia / 7bdae88 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 7bdae88 pgsql_mnesia_24 / pgsql_mnesia / 7bdae88 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 7bdae88 riak_mnesia_24 / riak_mnesia / 7bdae88 pgsql_mnesia_25 / pgsql_mnesia / 7bdae88 mysql_redis_25 / mysql_redis / 7bdae88 mssql_mnesia_25 / odbc_mssql_mnesia / 7bdae88 ldap_mnesia_24 / ldap_mnesia / 7bdae88 |
Codecov ReportBase: 82.97% // Head: 83.03% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3835 +/- ##
==========================================
+ Coverage 82.97% 83.03% +0.05%
==========================================
Files 528 528
Lines 33922 33922
==========================================
+ Hits 28148 28168 +20
+ Misses 5774 5754 -20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/http_upload/mod_http_upload.erl
Outdated
|
|
||
| %% API | ||
| -export([get_urls/5]). | ||
|
|
||
| %% mongoose_module_metrics callbacks | ||
| -export([config_metrics/1]). | ||
|
|
||
| -ignore_xref([behaviour_info/1, disco_local_items/1, process_disco_iq/5, process_iq/5]). | ||
| -ignore_xref([behaviour_info/1, process_disco_iq/5, process_iq/5]). |
There was a problem hiding this comment.
I'm actually thinking that it is very likely all these ignores can be removed 🤔
There was a problem hiding this comment.
you were right 🙂 xref doesn't complain after I've removed them
pawlooss1
force-pushed
the
hooks/mod_http_upload
branch
from
7bdae88
to
8d93760
Compare
|
small_tests_24 / small_tests / 8d93760 small_tests_25 / small_tests / 8d93760 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8d93760 ldap_mnesia_24 / ldap_mnesia / 8d93760 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8d93760 ldap_mnesia_25 / ldap_mnesia / 8d93760 dynamic_domains_mysql_redis_25 / mysql_redis / 8d93760 pgsql_mnesia_24 / pgsql_mnesia / 8d93760 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2575@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2575@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"QxGO6572iE8SJMsdosc78g==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8d93760 internal_mnesia_25 / internal_mnesia / 8d93760 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8d93760 riak_mnesia_24 / riak_mnesia / 8d93760 mysql_redis_25 / mysql_redis / 8d93760 pgsql_mnesia_25 / pgsql_mnesia / 8d93760 mssql_mnesia_25 / odbc_mssql_mnesia / 8d93760 |
This PR changes all hook handlers in
mod_http_uploadmodule togen_hookformat.