Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored hook handlers in mod_blocking #3839

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Conversation

pawlooss1
Copy link
Member

This PR changes all hook handlers in mod_blocking module to gen_hook format.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 3, 2022

small_tests_24 / small_tests / b10a7ac
Reports root / small


small_tests_25 / small_tests / b10a7ac
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b10a7ac
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / b10a7ac
Reports root/ big
OK: 2103 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / b10a7ac
Reports root/ big
OK: 2103 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b10a7ac
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / b10a7ac
Reports root/ big
OK: 3968 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b10a7ac
Reports root/ big
OK: 3994 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / b10a7ac
Reports root/ big
OK: 2239 / Failed: 0 / User-skipped: 648 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b10a7ac
Reports root/ big
OK: 2581 / Failed: 0 / User-skipped: 641 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / b10a7ac
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / b10a7ac
Reports root/ big
OK: 2427 / Failed: 0 / User-skipped: 627 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / b10a7ac
Reports root/ big
OK: 4379 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2662@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2662@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"vWeaXYV+xQgmDjV6tbVIAw==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mssql_mnesia_25 / odbc_mssql_mnesia / b10a7ac
Reports root/ big
OK: 4368 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / b10a7ac
Reports root/ big
OK: 4354 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 83.04% // Head: 83.05% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b10a7ac) compared to base (011217f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3839      +/-   ##
==========================================
+ Coverage   83.04%   83.05%   +0.01%     
==========================================
  Files         528      528              
  Lines       33926    33923       -3     
==========================================
+ Hits        28174    28176       +2     
+ Misses       5752     5747       -5     
Impacted Files Coverage Δ
src/mod_blocking.erl 88.46% <100.00%> (-0.43%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 66.66% <0.00%> (-2.23%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 72.05% <0.00%> (-1.48%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/mod_muc_room.erl 78.73% <0.00%> (+0.05%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.82% <0.00%> (+0.42%) ⬆️
src/rdbms/mongoose_rdbms.erl 67.01% <0.00%> (+0.70%) ⬆️
src/domain/service_domain_db.erl 85.41% <0.00%> (+2.08%) ⬆️
src/mongoose_tcp_listener.erl 72.34% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pawlooss1 pawlooss1 marked this pull request as ready for review November 3, 2022 11:33
Copy link

@kamilwaz kamilwaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

@kamilwaz kamilwaz merged commit 4203e5d into master Nov 4, 2022
@kamilwaz kamilwaz deleted the hooks/mod_blocking branch November 4, 2022 12:15
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants