Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored hook handlers in mod_csi #3846

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Refactored hook handlers in mod_csi #3846

merged 1 commit into from
Nov 8, 2022

Conversation

pawlooss1
Copy link
Member

This PR changes all hook handlers in mod_csi module to gen_hook format.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 8, 2022 •
edited
Loading

small_tests_24 / small_tests / bb62a1b
Reports root / small

small_tests_25 / small_tests / bb62a1b
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / bb62a1b
Reports root/ big
OK: 4000 / Failed: 0 / User-skipped: 88 / Auto-skipped: 9

xep_0352_csi_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {function_clause,
         [{gen_hook,add_handler,
            [{c2s_stream_features,<<"test type">>,
               fun mod_csi:c2s_stream_features/3,60}],
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,86}]},
          {gen_hook,'-add_handlers/1-lc$^0/1-0-',1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {gen_hook,add_handlers,1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {mod_csi,start,2,
            [{file,"/home/circleci/project/src/mod_csi.erl"},
             {line,30}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]},
          {mongoose_modules,ensure_started,3,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,74}]},
          {mongoose_modules,'-replace_modules/3-lc$^1/1-1-',2,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,50}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_modules,replace_modules,
       [<<"test type">>,[],
      #{mod_csi => #{buffer_max => 10},
        mod_offlin...

Report log

ldap_mnesia_24 / ldap_mnesia / bb62a1b
Reports root/ big
OK: 2109 / Failed: 0 / User-skipped: 784 / Auto-skipped: 9

xep_0352_csi_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {function_clause,
         [{gen_hook,add_handler,
            [{c2s_stream_features,<<"localhost">>,
               fun mod_csi:c2s_stream_features/3,60}],
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,86}]},
          {gen_hook,'-add_handlers/1-lc$^0/1-0-',1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {gen_hook,add_handlers,1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {mod_csi,start,2,
            [{file,"/home/circleci/project/src/mod_csi.erl"},
             {line,30}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]},
          {mongoose_modules,ensure_started,3,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,74}]},
          {mongoose_modules,'-replace_modules/3-lc$^1/1-1-',2,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,50}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_modules,replace_modules,
       [<<"localhost">>,[],
      #{mod_csi => #{buffer_max => 10},
        mod_offlin...

Report log

dynamic_domains_mysql_redis_25 / mysql_redis / bb62a1b
Reports root/ big
OK: 3974 / Failed: 0 / User-skipped: 114 / Auto-skipped: 9

xep_0352_csi_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {function_clause,
         [{gen_hook,add_handler,
            [{c2s_stream_features,<<"test type">>,
               fun mod_csi:c2s_stream_features/3,60}],
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,86}]},
          {gen_hook,'-add_handlers/1-lc$^0/1-0-',1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {gen_hook,add_handlers,1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {mod_csi,start,2,
            [{file,"/home/circleci/project/src/mod_csi.erl"},
             {line,30}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]},
          {mongoose_modules,ensure_started,3,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,74}]},
          {mongoose_modules,'-replace_modules/3-lc$^1/1-1-',2,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,50}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_modules,replace_modules,
       [<<"test type">>,[],
      #{mod_csi => #{buffer_max => 10},
        mod_offlin...

Report log

ldap_mnesia_25 / ldap_mnesia / bb62a1b
Reports root/ big
OK: 2109 / Failed: 0 / User-skipped: 784 / Auto-skipped: 9

xep_0352_csi_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {function_clause,
         [{gen_hook,add_handler,
            [{c2s_stream_features,<<"localhost">>,
               fun mod_csi:c2s_stream_features/3,60}],
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,86}]},
          {gen_hook,'-add_handlers/1-lc$^0/1-0-',1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {gen_hook,add_handlers,1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {mod_csi,start,2,
            [{file,"/home/circleci/project/src/mod_csi.erl"},
             {line,30}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]},
          {mongoose_modules,ensure_started,3,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,74}]},
          {mongoose_modules,'-replace_modules/3-lc$^1/1-1-',2,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,50}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_modules,replace_modules,
       [<<"localhost">>,[],
      #{mod_csi => #{buffer_max => 10},
        mod_offlin...

Report log

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / bb62a1b
Reports root/ big
OK: 4000 / Failed: 0 / User-skipped: 88 / Auto-skipped: 9

xep_0352_csi_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {function_clause,
         [{gen_hook,add_handler,
            [{c2s_stream_features,<<"test type">>,
               fun mod_csi:c2s_stream_features/3,60}],
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,86}]},
          {gen_hook,'-add_handlers/1-lc$^0/1-0-',1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {gen_hook,add_handlers,1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {mod_csi,start,2,
            [{file,"/home/circleci/project/src/mod_csi.erl"},
             {line,30}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]},
          {mongoose_modules,ensure_started,3,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,74}]},
          {mongoose_modules,'-replace_modules/3-lc$^1/1-1-',2,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,50}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_modules,replace_modules,
       [<<"test type">>,[],
      #{mod_csi => #{buffer_max => 10},
        mod_offlin...

Report log

pgsql_mnesia_24 / pgsql_mnesia / bb62a1b
Reports root/ big
OK: 4374 / Failed: 0 / User-skipped: 97 / Auto-skipped: 9

xep_0352_csi_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {function_clause,
         [{gen_hook,add_handler,
            [{c2s_stream_features,<<"localhost">>,
               fun mod_csi:c2s_stream_features/3,60}],
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,86}]},
          {gen_hook,'-add_handlers/1-lc$^0/1-0-',1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {gen_hook,add_handlers,1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {mod_csi,start,2,
            [{file,"/home/circleci/project/src/mod_csi.erl"},
             {line,30}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]},
          {mongoose_modules,ensure_started,3,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,74}]},
          {mongoose_modules,'-replace_modules/3-lc$^1/1-1-',2,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,50}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_modules,replace_modules,
       [<<"localhost">>,[],
      #{mod_csi => #{buffer_max => 10},
        mod_offlin...

Report log

internal_mnesia_25 / internal_mnesia / bb62a1b
Reports root/ big
OK: 2245 / Failed: 0 / User-skipped: 648 / Auto-skipped: 9

xep_0352_csi_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {function_clause,
         [{gen_hook,add_handler,
            [{c2s_stream_features,<<"localhost">>,
               fun mod_csi:c2s_stream_features/3,60}],
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,86}]},
          {gen_hook,'-add_handlers/1-lc$^0/1-0-',1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {gen_hook,add_handlers,1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {mod_csi,start,2,
            [{file,"/home/circleci/project/src/mod_csi.erl"},
             {line,30}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]},
          {mongoose_modules,ensure_started,3,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,74}]},
          {mongoose_modules,'-replace_modules/3-lc$^1/1-1-',2,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,50}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_modules,replace_modules,
       [<<"localhost">>,[],
      #{mod_csi => #{buffer_max => 10},
        mod_offlin...

Report log

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / bb62a1b
Reports root/ big
OK: 4000 / Failed: 0 / User-skipped: 88 / Auto-skipped: 9

xep_0352_csi_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {function_clause,
         [{gen_hook,add_handler,
            [{c2s_stream_features,<<"test type">>,
               fun mod_csi:c2s_stream_features/3,60}],
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,86}]},
          {gen_hook,'-add_handlers/1-lc$^0/1-0-',1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {gen_hook,add_handlers,1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {mod_csi,start,2,
            [{file,"/home/circleci/project/src/mod_csi.erl"},
             {line,30}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]},
          {mongoose_modules,ensure_started,3,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,74}]},
          {mongoose_modules,'-replace_modules/3-lc$^1/1-1-',2,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,50}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_modules,replace_modules,
       [<<"test type">>,[],
      #{mod_csi => #{buffer_max => 10},
        mod_offlin...

Report log

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / bb62a1b
Reports root/ big
OK: 2587 / Failed: 0 / User-skipped: 641 / Auto-skipped: 9

xep_0352_csi_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {function_clause,
         [{gen_hook,add_handler,
            [{c2s_stream_features,<<"localhost">>,
               fun mod_csi:c2s_stream_features/3,60}],
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,86}]},
          {gen_hook,'-add_handlers/1-lc$^0/1-0-',1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {gen_hook,add_handlers,1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {mod_csi,start,2,
            [{file,"/home/circleci/project/src/mod_csi.erl"},
             {line,30}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]},
          {mongoose_modules,ensure_started,3,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,74}]},
          {mongoose_modules,'-replace_modules/3-lc$^1/1-1-',2,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,50}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_modules,replace_modules,
       [<<"localhost">>,[],
      #{mod_csi => #{buffer_max => 10},
        mod_offlin...

Report log

riak_mnesia_24 / riak_mnesia / bb62a1b
Reports root/ big
OK: 2433 / Failed: 0 / User-skipped: 627 / Auto-skipped: 9

xep_0352_csi_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {function_clause,
         [{gen_hook,add_handler,
            [{c2s_stream_features,<<"localhost">>,
               fun mod_csi:c2s_stream_features/3,60}],
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,86}]},
          {gen_hook,'-add_handlers/1-lc$^0/1-0-',1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {gen_hook,add_handlers,1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {mod_csi,start,2,
            [{file,"/home/circleci/project/src/mod_csi.erl"},
             {line,30}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]},
          {mongoose_modules,ensure_started,3,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,74}]},
          {mongoose_modules,'-replace_modules/3-lc$^1/1-1-',2,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,50}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_modules,replace_modules,
       [<<"localhost">>,[],
      #{mod_csi => #{buffer_max => 10},
        mod_offlin...

Report log

pgsql_mnesia_25 / pgsql_mnesia / bb62a1b
Reports root/ big
OK: 4374 / Failed: 0 / User-skipped: 97 / Auto-skipped: 9

xep_0352_csi_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {function_clause,
         [{gen_hook,add_handler,
            [{c2s_stream_features,<<"localhost">>,
               fun mod_csi:c2s_stream_features/3,60}],
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,86}]},
          {gen_hook,'-add_handlers/1-lc$^0/1-0-',1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {gen_hook,add_handlers,1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {mod_csi,start,2,
            [{file,"/home/circleci/project/src/mod_csi.erl"},
             {line,30}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]},
          {mongoose_modules,ensure_started,3,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,74}]},
          {mongoose_modules,'-replace_modules/3-lc$^1/1-1-',2,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,50}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_modules,replace_modules,
       [<<"localhost">>,[],
      #{mod_csi => #{buffer_max => 10},
        mod_offlin...

Report log

mysql_redis_25 / mysql_redis / bb62a1b
Reports root/ big
OK: 4360 / Failed: 0 / User-skipped: 111 / Auto-skipped: 9

xep_0352_csi_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {function_clause,
         [{gen_hook,add_handler,
            [{c2s_stream_features,<<"localhost">>,
               fun mod_csi:c2s_stream_features/3,60}],
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,86}]},
          {gen_hook,'-add_handlers/1-lc$^0/1-0-',1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {gen_hook,add_handlers,1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {mod_csi,start,2,
            [{file,"/home/circleci/project/src/mod_csi.erl"},
             {line,30}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]},
          {mongoose_modules,ensure_started,3,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,74}]},
          {mongoose_modules,'-replace_modules/3-lc$^1/1-1-',2,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,50}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_modules,replace_modules,
       [<<"localhost">>,[],
      #{mod_csi => #{buffer_max => 10},
        mod_offlin...

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / bb62a1b
Reports root/ big
OK: 4373 / Failed: 1 / User-skipped: 97 / Auto-skipped: 9

xep_0352_csi_SUITE:init_per_suite 
{'EXIT',
  {{badrpc,
     {'EXIT',
       {function_clause,
         [{gen_hook,add_handler,
            [{c2s_stream_features,<<"localhost">>,
               fun mod_csi:c2s_stream_features/3,60}],
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,86}]},
          {gen_hook,'-add_handlers/1-lc$^0/1-0-',1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {gen_hook,add_handlers,1,
            [{file,"/home/circleci/project/src/gen_hook.erl"},
             {line,82}]},
          {mod_csi,start,2,
            [{file,"/home/circleci/project/src/mod_csi.erl"},
             {line,30}]},
          {gen_mod,start_module_for_host_type,3,
            [{file,"/home/circleci/project/src/gen_mod.erl"},
             {line,103}]},
          {mongoose_modules,start_module,4,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,90}]},
          {mongoose_modules,ensure_started,3,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,74}]},
          {mongoose_modules,'-replace_modules/3-lc$^1/1-1-',2,
            [{file,
               "/home/circleci/project/src/mongoose_modules.erl"},
             {line,50}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_modules,replace_modules,
       [<<"localhost">>,[],
      #{mod_csi => #{buffer_max => 10},
        mod_offlin...

Report log

service_domain_db_SUITE:db:db_domains_with_unknown_host_type_are_ignored_by_core 
{error,
  {{badmatch,{error,not_found}},
   [{service_domain_db_SUITE,
      db_domains_with_unknown_host_type_are_ignored_by_core,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,469}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

@codecov
Copy link

codecov bot commented Nov 8, 2022 •
edited
Loading

Codecov Report

Base: 83.10% // Head: 83.09% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (6562a08) compared to base (7c74198).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3846      +/-   ##
==========================================
- Coverage   83.10%   83.09%   -0.01%     
==========================================
  Files         534      534              
  Lines       34049    34049              
==========================================
- Hits        28297    28294       -3     
- Misses       5752     5755       +3
Impacted Files Coverage Δ
src/mod_csi.erl 100.00% <100.00%> (ø)
src/mam/mod_mam_muc_rdbms_arch_async.erl 82.85% <0.00%> (-2.86%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 72.05% <0.00%> (-1.48%) ⬇️
src/rdbms/mongoose_rdbms.erl 66.31% <0.00%> (-0.71%) ⬇️
src/ejabberd_sm.erl 87.33% <0.00%> (-0.33%) ⬇️
src/ejabberd_c2s.erl 89.02% <0.00%> (+0.07%) ⬆️
src/pubsub/node_pep.erl 79.62% <0.00%> (+1.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pawlooss1 pawlooss1 marked this pull request as ready for review November 8, 2022 11:25
@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 8, 2022 •
edited
Loading

small_tests_24 / small_tests / 6562a08
Reports root / small

small_tests_25 / small_tests / 6562a08
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6562a08
Reports root/ big
OK: 4009 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 6562a08
Reports root/ big
OK: 2118 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 6562a08
Reports root/ big
OK: 2118 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 6562a08
Reports root/ big
OK: 3983 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6562a08
Reports root/ big
OK: 4009 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 6562a08
Reports root/ big
OK: 4383 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 6562a08
Reports root/ big
OK: 2254 / Failed: 0 / User-skipped: 648 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6562a08
Reports root/ big
OK: 4017 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

disco_and_caps_SUITE:disco_with_caps:user_can_query_friend_resources 
{error,{{assertion_failed,assert_many,false,[is_roster_set],[],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,108}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6562a08
Reports root/ big
OK: 2596 / Failed: 0 / User-skipped: 641 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 6562a08
Reports root/ big
OK: 2442 / Failed: 0 / User-skipped: 627 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 6562a08
Reports root/ big
OK: 4393 / Failed: 2 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2563@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2563@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"36wd2pPxmB6HDd/afsphbA==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

service_domain_db_SUITE:db:db_event_could_appear_with_lower_id 
{error,
  {{badmatch,88},
   [{service_domain_db_SUITE,db_event_could_appear_with_lower_id,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,710}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / 6562a08
Reports root/ big
OK: 4369 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 6562a08
Reports root/ big
OK: 4383 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 6562a08
Reports root/ big
OK: 4383 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

NelsonVides
NelsonVides approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

src/mod_csi.erl
-spec c2s_stream_features(Acc, Params, Extra) -> {ok, Acc} when
Acc :: [exml:element()],
Params :: map(),
Extra :: map().
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can use now in all these handlers the new type, gen_hook:extra(), just for good habit, but nevertheless it doesn't change much in this PR, just for the future 👌🏽

@NelsonVides NelsonVides merged commit 145669a into master Nov 8, 2022
@NelsonVides NelsonVides deleted the hooks/mod_csi branch November 8, 2022 17:28
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelsonVides NelsonVides NelsonVides approved these changes

@kamilwaz kamilwaz Awaiting requested review from kamilwaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pawlooss1 @mongoose-im @NelsonVides @chrzaszcz