-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored hook handlers in mod_disco #3847
Conversation
small_tests_24 / small_tests / b4f7bbd small_tests_25 / small_tests / b4f7bbd ldap_mnesia_24 / ldap_mnesia / b4f7bbd dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b4f7bbd dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b4f7bbd ldap_mnesia_25 / ldap_mnesia / b4f7bbd dynamic_domains_mysql_redis_25 / mysql_redis / b4f7bbd internal_mnesia_25 / internal_mnesia / b4f7bbd dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b4f7bbd pgsql_mnesia_24 / pgsql_mnesia / b4f7bbd elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b4f7bbd riak_mnesia_24 / riak_mnesia / b4f7bbd pgsql_mnesia_25 / pgsql_mnesia / b4f7bbd mysql_redis_25 / mysql_redis / b4f7bbd mssql_mnesia_25 / odbc_mssql_mnesia / b4f7bbd pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2613@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2613@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"Eo55A7FpBkOITcMwYQ5+WA==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} |
Codecov ReportBase: 83.08% // Head: 83.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3847 +/- ##
==========================================
+ Coverage 83.08% 83.11% +0.02%
==========================================
Files 534 534
Lines 34060 34058 -2
==========================================
+ Hits 28300 28306 +6
+ Misses 5760 5752 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one indentation broken and it's ready to merge 👌🏽
Acc :: mongoose_disco:info_acc(), | ||
Params :: map(), | ||
Extra :: map(). | ||
disco_info(Acc = #{host_type := HostType, module := Module, node := <<>>}, _, _) -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... all these handlers expose the host_type twice, once here and once in the extra param, seems like redundancy to correct for the future 🤔
b4f7bbd
to
caee162
Compare
small_tests_24 / small_tests / caee162 small_tests_25 / small_tests / caee162 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / caee162 ldap_mnesia_24 / ldap_mnesia / caee162 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / caee162 ldap_mnesia_25 / ldap_mnesia / caee162 dynamic_domains_mysql_redis_25 / mysql_redis / caee162 pgsql_mnesia_24 / pgsql_mnesia / caee162 internal_mnesia_25 / internal_mnesia / caee162 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / caee162 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / caee162 pgsql_mnesia_25 / pgsql_mnesia / caee162 riak_mnesia_24 / riak_mnesia / caee162 mysql_redis_25 / mysql_redis / caee162 mssql_mnesia_25 / odbc_mssql_mnesia / caee162 |
This PR changes all hook handlers in
mod_disco
module togen_hook
format.