-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored hook handlers in mod_register #3867
Conversation
Codecov ReportBase: 82.77% // Head: 83.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3867 +/- ##
==========================================
+ Coverage 82.77% 83.13% +0.36%
==========================================
Files 535 535
Lines 34149 34153 +4
==========================================
+ Hits 28266 28393 +127
+ Misses 5883 5760 -123
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
small_tests_24 / small_tests / 60e2a05 small_tests_25 / small_tests / 60e2a05 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 60e2a05 ldap_mnesia_24 / ldap_mnesia / 60e2a05 ldap_mnesia_25 / ldap_mnesia / 60e2a05 dynamic_domains_mysql_redis_25 / mysql_redis / 60e2a05 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 60e2a05 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 60e2a05 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 60e2a05 internal_mnesia_25 / internal_mnesia / 60e2a05 pgsql_mnesia_24 / pgsql_mnesia / 60e2a05 riak_mnesia_24 / riak_mnesia / 60e2a05 pgsql_mnesia_25 / pgsql_mnesia / 60e2a05 mysql_redis_25 / mysql_redis / 60e2a05 mssql_mnesia_25 / odbc_mssql_mnesia / 60e2a05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌🏽
This PR changes all hook handlers in
mod_register
module togen_hook
format.