Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tabbed content in the documentation #3869

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

gustawlippa
Copy link
Contributor

I've noticed that the tabbed content was not rendering properly. Seems like a new configuration option is required for the tabbed plugin, so I've added it.

Before:
Screenshot 2022-11-22 at 12 06 58

After:
Screenshot 2022-11-22 at 12 06 38

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 22, 2022

small_tests_24 / small_tests / 5469765
Reports root / small


small_tests_25 / small_tests / 5469765
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 5469765
Reports root/ big
OK: 2155 / Failed: 0 / User-skipped: 806 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5469765
Reports root/ big
OK: 4092 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5469765
Reports root/ big
OK: 4092 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 5469765
Reports root/ big
OK: 2155 / Failed: 0 / User-skipped: 806 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 5469765
Reports root/ big
OK: 4066 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5469765
Reports root/ big
OK: 4092 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 5469765
Reports root/ big
OK: 2643 / Failed: 0 / User-skipped: 657 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 5469765
Reports root/ big
OK: 2297 / Failed: 0 / User-skipped: 664 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 5469765
Reports root/ big
OK: 4477 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2623@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2623@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"CQtj7Q6zvy/fETb3l/Crog==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


mysql_redis_25 / mysql_redis / 5469765
Reports root/ big
OK: 4452 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 5469765
Reports root/ big
OK: 4466 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 5469765
Reports root/ big
OK: 2487 / Failed: 0 / User-skipped: 643 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 5469765
Reports root/ big
OK: 4462 / Failed: 4 / User-skipped: 97 / Auto-skipped: 0

inbox_SUITE:async_pools:muclight_config:system_message_is_correctly_avoided
{error,
  {{inbox_size,1,
     [{times,1,
        {error,
          #{check_params => #{},
          error => {badmatch,1},
          expected_items =>
            [#{content => <<"How are you?">>,
               from =>
                 <<"[email protected]/bob@localhost">>,
               to => <<"[email protected]">>,unread => 2,
               verify => #Fun<inbox_SUITE.86.91825257>}],
          inbox_items =>
            [<<"<message from='[email protected]' to='[email protected]/res1' id='1669-116297-860274'><result xmlns='erlang-solutions.com:xmpp:inbox:0' unread='1' queryid='58c5f7dc99a4462cad3673b328a49222'><forwarded xmlns='urn:xmpp:forward:0'><delay xmlns='urn:xmpp:delay' stamp='2022-11-22T11:24:57.751943Z'/><message to='[email protected]' id='id-2' type='groupchat' from='[email protected]/bob@localhost'><body>How are you?</body></message></forwarded><box>inbox</box><archive>false</archive><mute>0</mute></result></message>">>],
          query_params => #{},reason => inbox_mismatch,
          stacktrace =>
            [{inbox_helper,process_inbox_message,5,
               [{file,
                  "/home/circleci/project/big_tests/tests/inbox_helper.erl"},
                {line,234}]},
             {lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
             {inbox_helper,check_inbox_result,5,
               [{file,
                  "/home/circleci/project/big_tests/tests/inbox...

Report log

inbox_extensions_SUITE:async_pools:one_to_one:mute_muted_entry_gets_unmuted
{error,
  {{assert,
     [{module,inbox_extensions_SUITE},
      {line,882},
      {expression,"escalus_pred : is_message ( Message )"},
      {expected,true},
      {value,false}]},
   [{inbox_extensions_SUITE,check_message_with_properties,4,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,882}]},
    {inbox_extensions_SUITE,set_inbox_properties,4,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,876}]},
    {inbox_extensions_SUITE,'-mute_muted_entry_gets_unmuted/1-fun-2-',2,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,575}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

service_mongoose_system_metrics_SUITE:system_metrics_are_reported_to_configurable_google_analytics
{error,
  {{assertEqual,
     [{module,service_mongoose_system_metrics_SUITE},
      {line,470},
      {expression,"ActualTrackingIds"},
      {expected,[<<"UA-151671255-1">>,<<"UA-EXTRA-TRACKING-ID">>]},
      {value,[<<"UA-151671255-1">>]}]},
   [{service_mongoose_system_metrics_SUITE,
      events_are_reported_to_tracking_ids,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
       {line,470}]},
    {service_mongoose_system_metrics_SUITE,
      system_metrics_are_reported_to_configurable_google_analytics,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
       {line,204}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mssql_mnesia_25 / odbc_mssql_mnesia / 5469765
Reports root/ big
OK: 4466 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 83.12% // Head: 83.14% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (5469765) compared to base (89d1b2b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3869      +/-   ##
==========================================
+ Coverage   83.12%   83.14%   +0.01%     
==========================================
  Files         535      535              
  Lines       34164    34164              
==========================================
+ Hits        28400    28404       +4     
+ Misses       5764     5760       -4     
Impacted Files Coverage Δ
src/async_pools/mongoose_aggregator_worker.erl 63.33% <0.00%> (-5.01%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 70.58% <0.00%> (-2.95%) ⬇️
src/muc_light/mod_muc_light_db_mnesia.erl 91.57% <0.00%> (-1.06%) ⬇️
src/pubsub/mod_pubsub.erl 73.04% <0.00%> (-0.19%) ⬇️
src/pubsub/mod_pubsub_db_rdbms.erl 95.34% <0.00%> (+0.25%) ⬆️
src/ejabberd_c2s.erl 89.25% <0.00%> (+0.29%) ⬆️
src/inbox/mod_inbox_rdbms.erl 92.77% <0.00%> (+0.55%) ⬆️
src/inbox/mod_inbox.erl 88.78% <0.00%> (+1.34%) ⬆️
src/pubsub/node_pep.erl 79.62% <0.00%> (+1.85%) ⬆️
src/mam/mod_mam_muc_rdbms_arch_async.erl 85.71% <0.00%> (+2.85%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😁

@NelsonVides NelsonVides merged commit 9116a26 into master Nov 23, 2022
@NelsonVides NelsonVides deleted the docs-fix-tabbed-content branch November 23, 2022 11:54
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants