Refactored hook handlers in mod_shared_roster_ldap #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawlooss1
force-pushed
the
hooks/mod_shared_roster_ldap
branch
from
fbf78b8
to
6ffea97
Compare
|
small_tests_24 / small_tests / 6ffea97 small_tests_25 / small_tests / 6ffea97 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6ffea97 ldap_mnesia_24 / ldap_mnesia / 6ffea97 dynamic_domains_mysql_redis_25 / mysql_redis / 6ffea97 ldap_mnesia_25 / ldap_mnesia / 6ffea97 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6ffea97 pgsql_mnesia_24 / pgsql_mnesia / 6ffea97 internal_mnesia_25 / internal_mnesia / 6ffea97 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6ffea97 pgsql_mnesia_25 / pgsql_mnesia / 6ffea97 riak_mnesia_24 / riak_mnesia / 6ffea97 mysql_redis_25 / mysql_redis / 6ffea97 mssql_mnesia_25 / odbc_mssql_mnesia / 6ffea97 inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_fetch_ahead{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bob_max_queries_can_fetch_ahead_1518@localhost/res1">>,
escalus_tcp,<0.8683.1>,
[{event_manager,<0.8672.1>},
{server,<<"localhost">>},
{username,<<"bOb_max_queries_can_fetch_ahead_1518">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.8672.1>},
{server,<<"localhost">>},
{username,<<"bOb_max_queries_can_fetch_ahead_1518">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_max_queries_can_fetch_ahead_1518">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_max_queries_can_fetch_ahead_1518">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"5fa110822e061fd6">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE,'-max_queries_can_fetch_ahead/1-fun-0-',4,
[{file,...inbox_extensions_SUITE:regular:one_to_one:pagination:pagination_overrides_form{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"kate_pagination_overrides_form_1514@localhost/res1">>,
escalus_tcp,<0.8684.1>,
[{event_manager,<0.8644.1>},
{server,<<"localhost">>},
{username,<<"kate_pagination_overrides_form_1514">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.8644.1>},
{server,<<"localhost">>},
{username,<<"kate_pagination_overrides_form_1514">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_pagination_overrides_form_1514">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_pagination_overrides_form_1514">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"d253ecb7a482a259">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-pagination_overrides_form/1-fun-0-',4,
[{file,
...inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_forwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"kate_can_paginate_forwards_1515@localhost/res1">>,
escalus_tcp,<0.8686.1>,
[{event_manager,<0.8651.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_forwards_1515">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.8651.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_forwards_1515">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_forwards_1515">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_forwards_1515">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"c711828f7ab03613">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-can_paginate_forwards/1-fun-0-',4,
[{file,
"/home/circleci/project/big_t...inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_backwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"kate_can_paginate_backwards_1517@localhost/res1">>,
escalus_tcp,<0.8687.1>,
[{event_manager,<0.8665.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_backwards_1517">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.8665.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_backwards_1517">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_backwards_1517">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_backwards_1517">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"debf29cf5c6296e9">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-can_paginate_backwards/1-fun-0-',4,
[{file,
"/home/circleci/project...inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_be_limited{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"kate_max_queries_can_be_limited_1516@localhost/res1">>,
escalus_tcp,<0.8685.1>,
[{event_manager,<0.8658.1>},
{server,<<"localhost">>},
{username,<<"kate_max_queries_can_be_limited_1516">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.8658.1>},
{server,<<"localhost">>},
{username,<<"kate_max_queries_can_be_limited_1516">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_max_queries_can_be_limited_1516">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_max_queries_can_be_limited_1516">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"b012c8652e67d0c8">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-max_queries_can_be_limited/1-fun-0-',4,
[{file...mssql_mnesia_25 / odbc_mssql_mnesia / 6ffea97 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2655@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2655@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"kK24ra8/bg3jqOUtERxd9w==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} |
Codecov ReportBase: 83.09% // Head: 83.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3874 +/- ##
==========================================
+ Coverage 83.09% 83.13% +0.03%
==========================================
Files 535 535
Lines 34168 34169 +1
==========================================
+ Hits 28393 28405 +12
+ Misses 5775 5764 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all hook handlers in
mod_shared_roster_ldapmodule togen_hookformat.