Put hooks into persistent_term using batching #3878

NelsonVides · 2022-11-28T15:33:05Z

Optimising hooks, as every hook execution means copying a list of handler from the ets table, having them into persistent terms means faster access to super frequently used values: no copying, no GC, and keeping code hotter for memory caching.

gen_hook accumulates the handlers on an internal state, and does not dump into PT until explicitly requested (at the end of app startup). If any more handlers are added or removed afterwards, PT entry is updated immediately (this keeps tests easier).

Perhaps #4074 is preferred, needs to be discussed.

codecov · 2022-11-28T16:24:50Z

Codecov Report

Patch coverage: 96.66% and project coverage change: +0.07% 🎉

Comparison is base (8c4047d) 83.86% compared to head (6652234) 83.94%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3878      +/-   ##
==========================================
+ Coverage   83.86%   83.94%   +0.07%     
==========================================
  Files         551      551              
  Lines       33583    33589       +6     
==========================================
+ Hits        28166    28197      +31     
+ Misses       5417     5392      -25

Files Changed	Coverage Δ
src/metrics/mongoose_metrics.erl	`92.92% <ø> (ø)`
src/gen_hook.erl	`89.88% <96.55%> (+2.98%)`	⬆️
src/ejabberd_app.erl	`89.77% <100.00%> (+0.11%)`	⬆️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NelsonVides · 2022-11-28T22:28:02Z

An example of a profile with perf profiling for 60 seconds: mongoose_one_to_one scenario, 5k users, sending a message per second. Above, running on master, run_fold takes time in the range of 0.02-0.08%. Below, this branch, run_fold takes time in the range 0.02-0.03%. So best times are similar but average times are 2x faster, and worst times 4x faster. We're talking about very small times anyway, but also we're considering a very simple load test.

NelsonVides · 2023-08-01T13:25:04Z

To choose between this one and #4074

mongoose-im · 2023-08-17T14:53:53Z

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c6b0241
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

small_tests_24 / small_tests / c6b0241
Reports root / small

small_tests_25_arm64 / small_tests / c6b0241
Reports root / small

small_tests_25 / small_tests / c6b0241
Reports root / small

ldap_mnesia_24 / ldap_mnesia / c6b0241
Reports root/ big
OK: 2274 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / c6b0241
Reports root/ big
OK: 2274 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c6b0241
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c6b0241
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / c6b0241
Reports root/ big
OK: 4201 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c6b0241
Reports root/ big
OK: 4230 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / c6b0241
Reports root/ big
OK: 2420 / Failed: 0 / User-skipped: 685 / Auto-skipped: 0

pgsql_cets_25 / pgsql_cets / c6b0241
Reports root/ big
OK: 4592 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / c6b0241
Reports root/ big
OK: 4622 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / c6b0241
Reports root/ big
OK: 4602 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / c6b0241
Reports root/ big
OK: 4622 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / c6b0241
Reports root/ big
OK: 4619 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0

chrzaszcz

Thanks for making all the changes. This version looks best to me 👍

src/gen_hook.erl

mongoose-im · 2023-08-18T08:14:34Z

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6652234
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

small_tests_24 / small_tests / 6652234
Reports root / small

small_tests_25 / small_tests / 6652234
Reports root / small

small_tests_25_arm64 / small_tests / 6652234
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6652234
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 6652234
Reports root/ big
OK: 2274 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 6652234
Reports root/ big
OK: 4201 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6652234
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 6652234
Reports root/ big
OK: 2257 / Failed: 0 / User-skipped: 831 / Auto-skipped: 17

service_mongoose_system_metrics_SUITE:all_clustered_mongooses_report_the_same_client_id

{skip,
  {failed,
    {service_mongoose_system_metrics_SUITE,init_per_testcase,
      {{badrpc,timeout},
       [{distributed_helper,rpc,
          [#{node => mongooseim2@localhost,timeout => 30000},
           mongoose_cluster,join,
           [mongooseim@localhost]],
          [{file,
             "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
           {line,121}]},
        {distributed_helper,add_node_to_cluster,2,
          [{file,
             "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
           {line,29}]},
        {service_mongoose_system_metrics_SUITE,init_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
           {line,113}]},
        {test_server,do_init_per_testcase,2,
          [{file,"test_server.erl"},{line,1552}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1253}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1223}]}]}}}}

Report log

service_domain_db_SUITE:api_lookup_works

{skip,
  {failed,
    {service_domain_db_SUITE,init_per_testcase,
      {{badrpc,
         {'EXIT',
           {noproc,
             {gen_server,call,
               [mongoose_domain_sup,
                {terminate_child,mongoose_domain_core},
                infinity]}}}},
       [{distributed_helper,rpc,
          [#{node => mongooseim2@localhost},
           mongoose_domain_sup,restart_core,
           [[[],
           [<<"mim2only">>,<<"type1">>,<<"type2">>,<<"dummy auth">>,
            <<"dbgroup">>,<<"dbgroup2">>,<<"cfggroup">>]]]],
          [{file,
             "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
           {line,121}]},
        {domain_helper,restart_domain_core,3,
          [{file,
             "/home/circleci/project/big_tests/tests/domain_helper.erl"},
           {line,33}]},
        {service_domain_db_SUITE,setup_service,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,287}]},
        {service_domain_db_SUITE,init_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,239}]},
        {test_server,do_init_per_testcase,2,
          [{file,"test_server.erl"},{line,1552}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1253}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1223}]}]}}}}

Report log

service_domain_db_SUITE:api_lookup_not_found

{skip,
  {failed,
    {service_domain_db_SUITE,init_per_testcase,
      {{badrpc,
         {'EXIT',
           {noproc,
             {gen_server,call,
               [mongoose_domain_sup,
                {terminate_child,mongoose_domain_core},
                infinity]}}}},
       [{distributed_helper,rpc,
          [#{node => mongooseim2@localhost},
           mongoose_domain_sup,restart_core,
           [[[],
           [<<"mim2only">>,<<"type1">>,<<"type2">>,<<"dummy auth">>,
            <<"dbgroup">>,<<"dbgroup2">>,<<"cfggroup">>]]]],
          [{file,
             "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
           {line,121}]},
        {domain_helper,restart_domain_core,3,
          [{file,
             "/home/circleci/project/big_tests/tests/domain_helper.erl"},
           {line,33}]},
        {service_domain_db_SUITE,setup_service,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,287}]},
        {service_domain_db_SUITE,init_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,239}]},
        {test_server,do_init_per_testcase,2,
          [{file,"test_server.erl"},{line,1552}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1253}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1223}]}]}}}}

Report log

service_domain_db_SUITE:api_cannot_insert_static

{skip,
  {failed,
    {service_domain_db_SUITE,init_per_testcase,
      {{badrpc,
         {'EXIT',
           {noproc,
             {gen_server,call,
               [mongoose_domain_sup,
                {terminate_child,mongoose_domain_core},
                infinity]}}}},
       [{distributed_helper,rpc,
          [#{node => mongooseim2@localhost},
           mongoose_domain_sup,restart_core,
           [[[],
           [<<"mim2only">>,<<"type1">>,<<"type2">>,<<"dummy auth">>,
            <<"dbgroup">>,<<"dbgroup2">>,<<"cfggroup">>]]]],
          [{file,
             "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
           {line,121}]},
        {domain_helper,restart_domain_core,3,
          [{file,
             "/home/circleci/project/big_tests/tests/domain_helper.erl"},
           {line,33}]},
        {service_domain_db_SUITE,setup_service,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,287}]},
        {service_domain_db_SUITE,init_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,239}]},
        {test_server,do_init_per_testcase,2,
          [{file,"test_server.erl"},{line,1552}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1253}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1223}]}]}}}}

Report log

service_domain_db_SUITE:api_cannot_disable_static

{skip,
  {failed,
    {service_domain_db_SUITE,init_per_testcase,
      {{badrpc,
         {'EXIT',
           {noproc,
             {gen_server,call,
               [mongoose_domain_sup,
                {terminate_child,mongoose_domain_core},
                infinity]}}}},
       [{distributed_helper,rpc,
          [#{node => mongooseim2@localhost},
           mongoose_domain_sup,restart_core,
           [[[],
           [<<"mim2only">>,<<"type1">>,<<"type2">>,<<"dummy auth">>,
            <<"dbgroup">>,<<"dbgroup2">>,<<"cfggroup">>]]]],
          [{file,
             "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
           {line,121}]},
        {domain_helper,restart_domain_core,3,
          [{file,
             "/home/circleci/project/big_tests/tests/domain_helper.erl"},
           {line,33}]},
        {service_domain_db_SUITE,setup_service,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,287}]},
        {service_domain_db_SUITE,init_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,239}]},
        {test_server,do_init_per_testcase,2,
          [{file,"test_server.erl"},{line,1552}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1253}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1223}]}]}}}}

Report log

service_domain_db_SUITE:api_cannot_enable_static

{skip,
  {failed,
    {service_domain_db_SUITE,init_per_testcase,
      {{badrpc,
         {'EXIT',
           {noproc,
             {gen_server,call,
               [mongoose_domain_sup,
                {terminate_child,mongoose_domain_core},
                infinity]}}}},
       [{distributed_helper,rpc,
          [#{node => mongooseim2@localhost},
           mongoose_domain_sup,restart_core,
           [[[],
           [<<"mim2only">>,<<"type1">>,<<"type2">>,<<"dummy auth">>,
            <<"dbgroup">>,<<"dbgroup2">>,<<"cfggroup">>]]]],
          [{file,
             "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
           {line,121}]},
        {domain_helper,restart_domain_core,3,
          [{file,
             "/home/circleci/project/big_tests/tests/domain_helper.erl"},
           {line,33}]},
        {service_domain_db_SUITE,setup_service,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,287}]},
        {service_domain_db_SUITE,init_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,239}]},
        {test_server,do_init_per_testcase,2,
          [{file,"test_server.erl"},{line,1552}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1253}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1223}]}]}}}}

Report log

service_domain_db_SUITE:api_get_all_static

{skip,
  {failed,
    {service_domain_db_SUITE,init_per_testcase,
      {{badrpc,
         {'EXIT',
           {noproc,
             {gen_server,call,
               [mongoose_domain_sup,
                {terminate_child,mongoose_domain_core},
                infinity]}}}},
       [{distributed_helper,rpc,
          [#{node => mongooseim2@localhost},
           mongoose_domain_sup,restart_core,
           [[[],
           [<<"mim2only">>,<<"type1">>,<<"type2">>,<<"dummy auth">>,
            <<"dbgroup">>,<<"dbgroup2">>,<<"cfggroup">>]]]],
          [{file,
             "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
           {line,121}]},
        {domain_helper,restart_domain_core,3,
          [{file,
             "/home/circleci/project/big_tests/tests/domain_helper.erl"},
           {line,33}]},
        {service_domain_db_SUITE,setup_service,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,287}]},
        {service_domain_db_SUITE,init_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,239}]},
        {test_server,do_init_per_testcase,2,
          [{file,"test_server.erl"},{line,1552}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1253}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1223}]}]}}}}

Report log

service_domain_db_SUITE:api_get_domains_by_host_type

{skip,
  {failed,
    {service_domain_db_SUITE,init_per_testcase,
      {{badrpc,
         {'EXIT',
           {noproc,
             {gen_server,call,
               [mongoose_domain_sup,
                {terminate_child,mongoose_domain_core},
                infinity]}}}},
       [{distributed_helper,rpc,
          [#{node => mongooseim2@localhost},
           mongoose_domain_sup,restart_core,
           [[[],
           [<<"mim2only">>,<<"type1">>,<<"type2">>,<<"dummy auth">>,
            <<"dbgroup">>,<<"dbgroup2">>,<<"cfggroup">>]]]],
          [{file,
             "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
           {line,121}]},
        {domain_helper,restart_domain_core,3,
          [{file,
             "/home/circleci/project/big_tests/tests/domain_helper.erl"},
           {line,33}]},
        {service_domain_db_SUITE,setup_service,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,287}]},
        {service_domain_db_SUITE,init_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
           {line,239}]},
        {test_server,do_init_per_testcase,2,
          [{file,"test_server.erl"},{line,1552}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1253}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1223}]}]}}}}

Report log

service_domain_db_SUITE:end_per_suite

{error,
  {{badrpc,
     {'EXIT',
       {noproc,
         {gen_server,call,
           [mongoose_domain_sup,
            {terminate_child,mongoose_domain_core},
            infinity]}}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim2@localhost},
       mongoose_domain_sup,restart_core,
       [[]]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {domain_helper,restart_domain_core,1,
      [{file,"/home/circleci/project/big_tests/tests/domain_helper.erl"},
       {line,30}]},
    {service_domain_db_SUITE,'-end_per_suite/1-lc$^0/1-0-',1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,190}]},
    {service_domain_db_SUITE,end_per_suite,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
       {line,190}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1379}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_SUITE:init_per_suite

{'EXIT',
  {{badrpc,timeout},
   [{distributed_helper,rpc,
      [#{node => mongooseim2@localhost,timeout => 30000},
       mongoose_cluster,join,
       [mongooseim@localhost]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {distributed_helper,add_node_to_cluster,2,
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,29}]},
    {dynamic_domains_SUITE,cluster_nodes,2,
      [{file,
         "/home/circleci/project/big_tests/tests/dynamic_domains_SUITE.erl"},
       {line,210}]},
    {dynamic_domains_SUITE,init_per_suite,1,
      [{file,
         "/home/circleci/project/big_tests/tests/dynamic_domains_SUITE.erl"},
       {line,32}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1379}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

local_iq_SUITE:init_per_suite

{'EXIT',{{badrpc,timeout},
     [{distributed_helper,rpc,
                [#{node => mongooseim2@localhost,
                 timeout => 30000},
                 mongoose_cluster,join,
                 [mongooseim@localhost]],
                [{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
                 {line,121}]},
      {distributed_helper,add_node_to_cluster,2,
                [{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
                 {line,29}]},
      {local_iq_SUITE,init_per_suite,1,
              [{file,"/home/circleci/project/big_tests/tests/local_iq_SUITE.erl"},
               {line,29}]},
      {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
      {test_server,run_test_case_eval1,6,
             [{file,"test_server.erl"},{line,1379}]},
      {test_server,run_test_case_eval,9,
             [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6652234
Reports root/ big
OK: 4230 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0

pgsql_cets_25 / pgsql_cets / 6652234
Reports root/ big
OK: 4592 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 6652234
Reports root/ big
OK: 4622 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 6652234
Reports root/ big
OK: 4622 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 6652234
Reports root/ big
OK: 2420 / Failed: 0 / User-skipped: 685 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 6652234
Reports root/ big
OK: 4619 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0

small_tests_25_arm64 / small_tests / 6652234
Reports root / small

ldap_mnesia_25 / ldap_mnesia / 6652234
Reports root/ big
OK: 2274 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0

chrzaszcz

👌

NelsonVides force-pushed the hooks/persistent_term branch 2 times, most recently from 6674e33 to 272b31e Compare November 28, 2022 16:05

This comment was marked as outdated.

Sign in to view

NelsonVides added the WIP 🚧 label Mar 9, 2023

NelsonVides force-pushed the hooks/persistent_term branch 2 times, most recently from e0aa7e3 to 4a05899 Compare July 27, 2023 15:02

This comment was marked as outdated.

Sign in to view

NelsonVides force-pushed the hooks/persistent_term branch from 4a05899 to cc36f34 Compare July 27, 2023 15:30

This comment was marked as outdated.

Sign in to view

NelsonVides force-pushed the hooks/persistent_term branch from cc36f34 to ed62983 Compare July 27, 2023 15:50

This comment was marked as outdated.

Sign in to view

NelsonVides force-pushed the hooks/persistent_term branch from ed62983 to f2a9953 Compare July 27, 2023 16:06

This comment was marked as outdated.

Sign in to view

NelsonVides force-pushed the hooks/persistent_term branch from f2a9953 to 6dffa7f Compare July 27, 2023 17:03

This comment was marked as outdated.

Sign in to view

NelsonVides removed the WIP 🚧 label Jul 27, 2023

NelsonVides marked this pull request as ready for review July 27, 2023 20:39

NelsonVides force-pushed the hooks/persistent_term branch from 6dffa7f to aef976a Compare August 1, 2023 13:23

NelsonVides changed the base branch from master to hooks/apply_known_arity August 1, 2023 13:24

NelsonVides mentioned this pull request Aug 1, 2023

Put hooks into persistent_term using iterations #4074

Closed

NelsonVides marked this pull request as draft August 1, 2023 13:25

NelsonVides changed the title ~~Put hooks into persistent_term~~ Put hooks into persistent_term using batching Aug 1, 2023

This comment was marked as outdated.

Sign in to view

NelsonVides force-pushed the hooks/apply_known_arity branch from 25fa007 to c47348f Compare August 6, 2023 14:18

Base automatically changed from hooks/apply_known_arity to master August 7, 2023 07:29

NelsonVides force-pushed the hooks/persistent_term branch from aef976a to a0a5d35 Compare August 11, 2023 08:22

This comment was marked as outdated.

Sign in to view

NelsonVides force-pushed the hooks/persistent_term branch from a0a5d35 to 24a6a3c Compare August 11, 2023 09:15

This comment was marked as outdated.

Sign in to view

NelsonVides force-pushed the hooks/persistent_term branch from 24a6a3c to c0d1a15 Compare August 14, 2023 07:49

This comment was marked as outdated.

Sign in to view

Fix typespec

8b19aea

NelsonVides force-pushed the hooks/persistent_term branch from c0d1a15 to c6b0241 Compare August 17, 2023 14:46

chrzaszcz reviewed Aug 18, 2023

View reviewed changes

src/gen_hook.erl Outdated Show resolved Hide resolved

src/gen_hook.erl Outdated Show resolved Hide resolved

NelsonVides added 2 commits August 18, 2023 10:06

Put hooks into persistent_term

cdad561

Fix small tests

6652234

NelsonVides force-pushed the hooks/persistent_term branch from c6b0241 to 6652234 Compare August 18, 2023 08:06

NelsonVides marked this pull request as ready for review August 18, 2023 08:59

chrzaszcz approved these changes Aug 18, 2023

View reviewed changes

chrzaszcz merged commit 162df78 into master Aug 18, 2023
4 checks passed

chrzaszcz deleted the hooks/persistent_term branch August 18, 2023 10:32

chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Put hooks into persistent_term using batching #3878

Put hooks into persistent_term using batching #3878

NelsonVides commented Nov 28, 2022 •

edited

Loading

This comment was marked as outdated.

codecov bot commented Nov 28, 2022 •

edited

Loading

NelsonVides commented Nov 28, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

NelsonVides commented Aug 1, 2023

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Aug 17, 2023 •

edited

Loading

chrzaszcz left a comment

mongoose-im commented Aug 18, 2023 •

edited

Loading

chrzaszcz left a comment

Put hooks into persistent_term using batching #3878

Put hooks into persistent_term using batching #3878

Conversation

NelsonVides commented Nov 28, 2022 • edited Loading

This comment was marked as outdated.

codecov bot commented Nov 28, 2022 • edited Loading

Codecov Report

NelsonVides commented Nov 28, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

NelsonVides commented Aug 1, 2023

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Aug 17, 2023 • edited Loading

chrzaszcz left a comment

Choose a reason for hiding this comment

mongoose-im commented Aug 18, 2023 • edited Loading

chrzaszcz left a comment

Choose a reason for hiding this comment

NelsonVides commented Nov 28, 2022 •

edited

Loading

codecov bot commented Nov 28, 2022 •

edited

Loading

mongoose-im commented Aug 17, 2023 •

edited

Loading

mongoose-im commented Aug 18, 2023 •

edited

Loading