Improve error handling in session #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
small_tests_24 / small_tests / 9dcb2a2 small_tests_25 / small_tests / 9dcb2a2 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 9dcb2a2 graphql_session_SUITE:domain_admin_session:domain_admin_kick_user_no_permission{error,
{{invalid_ejson,
{client,
<<"alice_domain_admin_kick_user_no_permission_1205@domain.example.org/res1">>,
escalus_tcp,<0.529.1>,
[{event_manager,<0.528.1>},
{server,<<"domain.example.org">>},
{username,<<"alicE_domain_admin_kick_user_no_permission_1205">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.528.1>},
{server,<<"domain.example.org">>},
{username,
<<"alicE_domain_admin_kick_user_no_permission_1205">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_domain_admin_kick_user_no_permission_1205">>},
{server,<<"domain.example.org">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_domain_admin_kick_user_no_permission_1205">>},
{server,<<"domain.example.org">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"a106eb07632a7e1f">>}]}},
[{jiffy,encode,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/jiffy/src/jiffy.erl"},
{line,99}]},
{rest_helper,normalize_body,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,132}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,113}]},
{rest_helper,make_reques...ldap_mnesia_24 / ldap_mnesia / 9dcb2a2 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 9dcb2a2 graphql_session_SUITE:domain_admin_session:domain_admin_kick_user_no_permission{error,
{{invalid_ejson,
{client,
<<"alice_domain_admin_kick_user_no_permission_1201@domain.example.org/res1">>,
escalus_tcp,<0.32058.0>,
[{event_manager,<0.32057.0>},
{server,<<"domain.example.org">>},
{username,<<"alicE_domain_admin_kick_user_no_permission_1201">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.32057.0>},
{server,<<"domain.example.org">>},
{username,
<<"alicE_domain_admin_kick_user_no_permission_1201">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_domain_admin_kick_user_no_permission_1201">>},
{server,<<"domain.example.org">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_domain_admin_kick_user_no_permission_1201">>},
{server,<<"domain.example.org">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"079bdcbcf9c81b28">>}]}},
[{jiffy,encode,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/jiffy/src/jiffy.erl"},
{line,99}]},
{rest_helper,normalize_body,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,132}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,113}]},
{rest_helper,make_...dynamic_domains_mysql_redis_25 / mysql_redis / 9dcb2a2 graphql_session_SUITE:domain_admin_session:domain_admin_kick_user_no_permission{error,
{{invalid_ejson,
{client,
<<"alice_domain_admin_kick_user_no_permission_1189@domain.example.org/res1">>,
escalus_tcp,<0.31397.0>,
[{event_manager,<0.31396.0>},
{server,<<"domain.example.org">>},
{username,<<"alicE_domain_admin_kick_user_no_permission_1189">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.31396.0>},
{server,<<"domain.example.org">>},
{username,
<<"alicE_domain_admin_kick_user_no_permission_1189">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_domain_admin_kick_user_no_permission_1189">>},
{server,<<"domain.example.org">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_domain_admin_kick_user_no_permission_1189">>},
{server,<<"domain.example.org">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"0129d517fedb2d2e">>}]}},
[{jiffy,encode,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/jiffy/src/jiffy.erl"},
{line,99}]},
{rest_helper,normalize_body,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,132}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,113}]},
{rest_helper,make_...ldap_mnesia_25 / ldap_mnesia / 9dcb2a2 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 9dcb2a2 graphql_session_SUITE:domain_admin_session:domain_admin_kick_user_no_permission{error,
{{invalid_ejson,
{client,
<<"alice_domain_admin_kick_user_no_permission_1199@domain.example.org/res1">>,
escalus_tcp,<0.31990.0>,
[{event_manager,<0.31989.0>},
{server,<<"domain.example.org">>},
{username,<<"alicE_domain_admin_kick_user_no_permission_1199">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.31989.0>},
{server,<<"domain.example.org">>},
{username,
<<"alicE_domain_admin_kick_user_no_permission_1199">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_domain_admin_kick_user_no_permission_1199">>},
{server,<<"domain.example.org">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_domain_admin_kick_user_no_permission_1199">>},
{server,<<"domain.example.org">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"9cf0d908020e81c0">>}]}},
[{jiffy,encode,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/jiffy/src/jiffy.erl"},
{line,99}]},
{rest_helper,normalize_body,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,132}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,113}]},
{rest_helper,make_...pgsql_mnesia_24 / pgsql_mnesia / 9dcb2a2 graphql_session_SUITE:domain_admin_session:domain_admin_kick_user_no_permission{error,
{{invalid_ejson,
{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.1536.1>,
[{event_manager,<0.1535.1>},
{server,<<"localhost.bis">>},
{username,<<"alicE_domain_admin_kick_user_no_permission_1227">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.1535.1>},
{server,<<"localhost.bis">>},
{username,
<<"alicE_domain_admin_kick_user_no_permission_1227">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_domain_admin_kick_user_no_permission_1227">>},
{server,<<"localhost.bis">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_domain_admin_kick_user_no_permission_1227">>},
{server,<<"localhost.bis">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"e13466f5307828e3">>}]}},
[{jiffy,encode,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/jiffy/src/jiffy.erl"},
{line,99}]},
{rest_helper,normalize_body,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,132}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,113}]},
{rest_helper,make_request,1,
[{file,"/ho...elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 9dcb2a2 internal_mnesia_25 / internal_mnesia / 9dcb2a2 riak_mnesia_24 / riak_mnesia / 9dcb2a2 pgsql_mnesia_25 / pgsql_mnesia / 9dcb2a2 graphql_session_SUITE:domain_admin_session:domain_admin_kick_user_no_permission{error,
{{invalid_ejson,
{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.147.1>,
[{event_manager,<0.146.1>},
{server,<<"localhost.bis">>},
{username,<<"alicE_domain_admin_kick_user_no_permission_1220">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.146.1>},
{server,<<"localhost.bis">>},
{username,
<<"alicE_domain_admin_kick_user_no_permission_1220">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_domain_admin_kick_user_no_permission_1220">>},
{server,<<"localhost.bis">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_domain_admin_kick_user_no_permission_1220">>},
{server,<<"localhost.bis">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"9fcd36868755020b">>}]}},
[{jiffy,encode,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/jiffy/src/jiffy.erl"},
{line,99}]},
{rest_helper,normalize_body,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,132}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,113}]},
{rest_helper,make_request,1,
[{file,"/home/...mysql_redis_25 / mysql_redis / 9dcb2a2 graphql_session_SUITE:domain_admin_session:domain_admin_kick_user_no_permission{error,
{{invalid_ejson,
{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.32222.0>,
[{event_manager,<0.32221.0>},
{server,<<"localhost.bis">>},
{username,<<"alicE_domain_admin_kick_user_no_permission_1207">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.32221.0>},
{server,<<"localhost.bis">>},
{username,
<<"alicE_domain_admin_kick_user_no_permission_1207">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_domain_admin_kick_user_no_permission_1207">>},
{server,<<"localhost.bis">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_domain_admin_kick_user_no_permission_1207">>},
{server,<<"localhost.bis">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"79dbbbb7d4eb7056">>}]}},
[{jiffy,encode,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/jiffy/src/jiffy.erl"},
{line,99}]},
{rest_helper,normalize_body,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,132}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,113}]},
{rest_helper,make_request,1,
[{file,"...mssql_mnesia_25 / odbc_mssql_mnesia / 9dcb2a2 graphql_session_SUITE:domain_admin_session:domain_admin_kick_user_no_permission{error,
{{invalid_ejson,
{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.73.1>,
[{event_manager,<0.72.1>},
{server,<<"localhost.bis">>},
{username,<<"alicE_domain_admin_kick_user_no_permission_1207">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.72.1>},
{server,<<"localhost.bis">>},
{username,
<<"alicE_domain_admin_kick_user_no_permission_1207">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_domain_admin_kick_user_no_permission_1207">>},
{server,<<"localhost.bis">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_domain_admin_kick_user_no_permission_1207">>},
{server,<<"localhost.bis">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"b55e4ea91a3a832b">>}]}},
[{jiffy,encode,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/jiffy/src/jiffy.erl"},
{line,99}]},
{rest_helper,normalize_body,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,132}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,113}]},
{rest_helper,make_request,1,
[{file,"/home/cir...inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_backwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"bob_can_paginate_backwards_1521@localhost/res1">>,
escalus_tcp,<0.10164.1>,
[{event_manager,<0.10141.1>},
{server,<<"localhost">>},
{username,<<"bOb_can_paginate_backwards_1521">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10141.1>},
{server,<<"localhost">>},
{username,<<"bOb_can_paginate_backwards_1521">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_can_paginate_backwards_1521">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_can_paginate_backwards_1521">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"5c8b2f32a48a7fd7">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE,'-can_paginate_backwards/1-fun-0-',4,
[{file,
"/home/circleci/project/big...inbox_extensions_SUITE:regular:one_to_one:pagination:pagination_overrides_form{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bob_pagination_overrides_form_1519@localhost/res1">>,
escalus_tcp,<0.10161.1>,
[{event_manager,<0.10127.1>},
{server,<<"localhost">>},
{username,<<"bOb_pagination_overrides_form_1519">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10127.1>},
{server,<<"localhost">>},
{username,<<"bOb_pagination_overrides_form_1519">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_pagination_overrides_form_1519">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_pagination_overrides_form_1519">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"95be8b7cbc39c897">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE,'-pagination_overrides_form/1-fun-0-',4,
[{file,
...inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_forwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"kate_can_paginate_forwards_1520@localhost/res1">>,
escalus_tcp,<0.10163.1>,
[{event_manager,<0.10134.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_forwards_1520">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10134.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_forwards_1520">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_forwards_1520">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_forwards_1520">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"9a96e3818c44ab89">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-can_paginate_forwards/1-fun-0-',4,
[{file,
"/home/circleci/project/bi...inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_fetch_ahead{error,{{badmatch,0},
[{escalus_story,drop_presences,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,191}]},
{escalus_story,'-start_ready_clients/2-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,135}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{escalus_story,start_ready_clients,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,128}]},
{lists,flatmap_1,2,[{file,"lists.erl"},{line,1335}]},
{lists,flatmap_1,2,[{file,"lists.erl"},{line,1335}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,69}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]}]}}inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_be_limited{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"kate_max_queries_can_be_limited_1522@localhost/res1">>,
escalus_tcp,<0.10169.1>,
[{event_manager,<0.10148.1>},
{server,<<"localhost">>},
{username,<<"kate_max_queries_can_be_limited_1522">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10148.1>},
{server,<<"localhost">>},
{username,<<"kate_max_queries_can_be_limited_1522">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_max_queries_can_be_limited_1522">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_max_queries_can_be_limited_1522">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"e9bf352cbc536618">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-max_queries_can_be_limited/1-fun-0-',4,
[{f...push_integration_SUITE:pubsub_ful:groupchat_notifications_with_inbox:muclight_inbox_msg_unread_count_fcm{error,
{{assertMatch,
[{module,push_integration_SUITE},
{line,485},
{expression,"Data"},
{pattern,"# { << \"message-count\" >> := UnreadCount }"},
{value,
#{<<"last-message-body">> => <<"Second!">>,
<<"last-message-sender">> =>
<<"[email protected]/alice_muclight_inbox_msg_unread_count_fcm_2889@localhost">>,
<<"message-count">> => 1}}]},
[{push_integration_SUITE,assert_push_notification,5,
[{file,
"/home/circleci/project/big_tests/tests/push_integration_SUITE.erl"},
{line,485}]},
{push_integration_SUITE,'-muclight_inbox_msg_unread_count/3-fun-1-',5,
[{file,
"/home/circleci/project/big_tests/tests/push_integration_SUITE.erl"},
{line,636}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} |
Codecov ReportBase: 83.13% // Head: 83.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3883 +/- ##
==========================================
+ Coverage 83.13% 83.15% +0.01%
==========================================
Files 535 535
Lines 34199 34251 +52
==========================================
+ Hits 28432 28480 +48
- Misses 5767 5771 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kamilwaz
force-pushed
the
api-modules/session
branch
from
9dcb2a2
to
bd0c840
Compare
|
small_tests_24 / small_tests / bd0c840 small_tests_25 / small_tests / bd0c840 ldap_mnesia_24 / ldap_mnesia / bd0c840 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / bd0c840 ldap_mnesia_25 / ldap_mnesia / bd0c840 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / bd0c840 dynamic_domains_mysql_redis_25 / mysql_redis / bd0c840 pgsql_mnesia_24 / pgsql_mnesia / bd0c840 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / bd0c840 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / bd0c840 internal_mnesia_25 / internal_mnesia / bd0c840 riak_mnesia_24 / riak_mnesia / bd0c840 graphql_server_SUITE:admin_http:clustering_http_tests:remove_dead_from_cluster_http{error,
{{badrpc,
{'EXIT',
{{try_clause,
{badrpc,{'EXIT',{aborted,{no_exists,node,storage_type}}}}},
[{mongoose_cluster,table_type,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,158}]},
{mongoose_cluster,'-unsafe_join/2-lc$^0/1-0-',2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,119}]},
{mongoose_cluster,unsafe_join,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,120}]},
{mongoose_cluster,with_app_stopped,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,221}]},
{global,trans,4,[{file,"global.erl"},{line,463}]},
{mongoose_cluster,join,1,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost,timeout => 60000},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{graphql_server_SUITE,remove_dead_from_cluster_http,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,247}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}pgsql_mnesia_25 / pgsql_mnesia / bd0c840 mysql_redis_25 / mysql_redis / bd0c840 mssql_mnesia_25 / odbc_mssql_mnesia / bd0c840 pep_SUITE:pep_tests:publish_and_notify_test{error,{{assertion_failed,assert_many,false,[is_presence],[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-make_all_clients_friends/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,109}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{escalus_utils,distinct_pairs,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,60}]},
{escalus_story,make_all_clients_friends,1,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,106}]}]}}riak_mnesia_24 / riak_mnesia / bd0c840 |
chrzaszcz
reviewed
Dec 1, 2022
There was a problem hiding this comment.
I think all the changes are good, but I think we need to address some cases that give unexpected results:
Listing sessions for a non-existent domain results in an empty list, which makes the impression that the domain exists, but there are no users connected. So for example if I type loclahost instead of localhost, I might assume that my server has no sessions, which is not true.
$ _build/mim1/rel/mongooseim/bin/mongooseimctl session listSessions --domain x
{
"data" : {
"session" : {
"listSessions" : [
]
}
}
}
The same happens for non-existent users:
_build/mim1/rel/mongooseim/bin/mongooseimctl session listUserSessions --user a@b
egrep: warning: egrep is obsolescent; using grep -E
{
"data" : {
"session" : {
"listUserSessions" : [
]
}
}
}
This behaviour is present for multiple commands, e.g.
$ _build/mim1/rel/mongooseim/bin/mongooseimctl session kickUser --user x@z
egrep: warning: egrep is obsolescent; using grep -E
{
"data" : {
"session" : {
"kickUser" : [
]
}
}
}
Another corner case is that if you try to list sessions while a user is connected with SSE (REST or GraphQL), it crashes because of no IP address. To reproduce, run this in one shell:
curl -H 'Authorization: Basic YWRtaW46c2VjcmV0' -v -N http://localhost:5551/api/graphql/sse?query=subscription%20%7Bstanza%20%7BsubscribeForMessages%28caller%3A%22alice%40localhost%22%29%20%7Bstanza%7D%7D%7D
Then, while the previous command is running, do:
$ _build/mim1/rel/mongooseim/bin/mongooseimctl session listUserSessions --user alice@localhost
{
"errors" : [
{
"path" : [
"session",
"listUserSessions"
],
"message" : "Unexpected SessionAdminQuery resolver crash",
"extensions" : {
"code" : "resolver_crash"
}
}
],
"data" : {
"session" : {
"listUserSessions" : null
}
}
}
|
small_tests_24 / small_tests / 5e66fe0 small_tests_25 / small_tests / 5e66fe0 ldap_mnesia_24 / ldap_mnesia / 5e66fe0 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5e66fe0 ldap_mnesia_25 / ldap_mnesia / 5e66fe0 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5e66fe0 dynamic_domains_mysql_redis_25 / mysql_redis / 5e66fe0 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5e66fe0 muc_SUITE:register:end_per_group{error,
{{badrpc,
{'EXIT',
{timeout,
{gen_server,call,
['wpool_pool-mongoose_wpool$rdbms$global$default-4',
{sql_cmd,
{sql_execute,auth_get_password,
[<<"domain.example.com">>,<<"alice">>]},
-576459905558},
60000]}}}},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,unregister,
[<<"alicE">>,<<"domain.example.com">>],
30000,ejabberd],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
{escalus_ejabberd,delete_users,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,216}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1379}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}pgsql_mnesia_24 / pgsql_mnesia / 5e66fe0 internal_mnesia_25 / internal_mnesia / 5e66fe0 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 5e66fe0 mysql_redis_25 / mysql_redis / 5e66fe0 pgsql_mnesia_25 / pgsql_mnesia / 5e66fe0 mssql_mnesia_25 / odbc_mssql_mnesia / 5e66fe0 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}riak_mnesia_24 / riak_mnesia / 5e66fe0 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5e66fe0 inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_backwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.9982.1>,
[{event_manager,<0.9972.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_can_paginate_backwards_1541">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.9972.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_can_paginate_backwards_1541">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_can_paginate_backwards_1541">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_can_paginate_backwards_1541">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"6ebd4ebae5e7bc65">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE,'-...inbox_extensions_SUITE:regular:one_to_one:pagination:pagination_overrides_form{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.9984.1>,
[{event_manager,<0.9944.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_pagination_overrides_form_1537">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.9944.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_pagination_overrides_form_1537">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_pagination_overrides_form_1537">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_pagination_overrides_form_1537">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"f6e21fa6f56b9184">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inb...inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_fetch_ahead{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.9988.1>,
[{event_manager,<0.9965.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_max_queries_can_fetch_ahead_1540">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.9965.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_max_queries_can_fetch_ahead_1540">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_max_queries_can_fetch_ahead_1540">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_max_queries_can_fetch_ahead_1540">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"8825ef1d34323b4a">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},...inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_be_limited{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.9987.1>,
[{event_manager,<0.9958.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_max_queries_can_be_limited_1539">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.9958.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_max_queries_can_be_limited_1539">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_max_queries_can_be_limited_1539">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_max_queries_can_be_limited_1539">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"c3593393e49cc24c">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
...inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_forwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.9986.1>,
[{event_manager,<0.9951.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_can_paginate_forwards_1538">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.9951.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_can_paginate_forwards_1538">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_forwards_1538">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_forwards_1538">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"e5bf913db89fed23">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,...muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mssql_mnesia_25 / odbc_mssql_mnesia / 5e66fe0 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5e66fe0 muc_SUITE:register:user_submits_registration_form_twice{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"0a3095255465eccd1c4e4aa332a8a7ed">>},
{<<"to">>,<<"groupchats.domain.example.com">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitchroom-1412feab6b">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"groupchats.domain.example.com">>},
{<<"to">>,
<<"alice_user_submits_registration_form_twice_2487@domain.example.com/res1">>},
{<<"type">>,<<"error">>},
{<<"xml:lang">>,<<"en">>},
{<<"id">>,<<"0a3095255465eccd1c4e4aa332a8a7ed">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
...dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5e66fe0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling in session