Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored hook handlers in auth_tokend_SUITE #3886

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

pawlooss1
Copy link
Member

This PR changes all hook handlers in auth_tokend_SUITE to gen_hook format.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 1, 2022

small_tests_24 / small_tests / 1da1e23
Reports root / small


small_tests_25 / small_tests / 1da1e23
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1da1e23
Reports root/ big
OK: 4118 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 1da1e23
Reports root/ big
OK: 2169 / Failed: 0 / User-skipped: 818 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 1da1e23
Reports root/ big
OK: 2169 / Failed: 0 / User-skipped: 818 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 1da1e23
Reports root/ big
OK: 4092 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1da1e23
Reports root/ big
OK: 4118 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 1da1e23
Reports root/ big
OK: 4492 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 1da1e23
Reports root/ big
OK: 4118 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 1da1e23
Reports root/ big
OK: 2664 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 1da1e23
Reports root/ big
OK: 2311 / Failed: 0 / User-skipped: 676 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 1da1e23
Reports root/ big
OK: 2505 / Failed: 0 / User-skipped: 651 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 1da1e23
Reports root/ big
OK: 4492 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 1da1e23
Reports root/ big
OK: 4478 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 1da1e23
Reports root/ big
OK: 4492 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 81.63% // Head: 83.14% // Increases project coverage by +1.51% 🎉

Coverage data is based on head (8d04e95) compared to base (2affe7e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3886      +/-   ##
==========================================
+ Coverage   81.63%   83.14%   +1.51%     
==========================================
  Files         535      535              
  Lines       34205    34205              
==========================================
+ Hits        27923    28441     +518     
+ Misses       6282     5764     -518     
Impacted Files Coverage Δ
src/async_pools/mongoose_aggregator_worker.erl 63.33% <0.00%> (-5.01%) ⬇️
src/domain/service_domain_db.erl 83.33% <0.00%> (-2.09%) ⬇️
src/auth/ejabberd_auth.erl 83.24% <0.00%> (-1.53%) ⬇️
src/muc_light/mod_muc_light_db_mnesia.erl 91.57% <0.00%> (-1.06%) ⬇️
src/ejabberd_c2s.erl 89.02% <0.00%> (+0.07%) ⬆️
src/mam/mod_mam_utils.erl 89.93% <0.00%> (+0.91%) ⬆️
src/inbox/mod_inbox_rdbms_async.erl 73.52% <0.00%> (+1.47%) ⬆️
src/wpool/mongoose_wpool_riak.erl 100.00% <0.00%> (+12.50%) ⬆️
src/privacy/mod_privacy_riak.erl 76.47% <0.00%> (+76.47%) ⬆️
src/auth/ejabberd_auth_riak.erl 78.75% <0.00%> (+77.50%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 1, 2022

small_tests_24 / small_tests / 8d04e95
Reports root / small


small_tests_25 / small_tests / 8d04e95
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 8d04e95
Reports root/ big
OK: 2169 / Failed: 0 / User-skipped: 818 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8d04e95
Reports root/ big
OK: 4118 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 8d04e95
Reports root/ big
OK: 2169 / Failed: 0 / User-skipped: 818 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 8d04e95
Reports root/ big
OK: 4091 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8d04e95
Reports root/ big
OK: 4118 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8d04e95
Reports root/ big
OK: 4118 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 8d04e95
Reports root/ big
OK: 2311 / Failed: 0 / User-skipped: 676 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 8d04e95
Reports root/ big
OK: 4492 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8d04e95
Reports root/ big
OK: 2664 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 8d04e95
Reports root/ big
OK: 2505 / Failed: 0 / User-skipped: 651 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 8d04e95
Reports root/ big
OK: 4492 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 8d04e95
Reports root/ big
OK: 4478 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 8d04e95
Reports root/ big
OK: 4498 / Failed: 6 / User-skipped: 97 / Auto-skipped: 0

inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_forwards
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"bob_can_paginate_forwards_1516@localhost/res1">>,
          escalus_tcp,<0.10189.1>,
          [{event_manager,<0.10166.1>},
           {server,<<"localhost">>},
           {username,<<"bOb_can_paginate_forwards_1516">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.10166.1>},
            {server,<<"localhost">>},
            {username,<<"bOb_can_paginate_forwards_1516">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bob_can_paginate_forwards_1516">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_can_paginate_forwards_1516">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"ce907c2db0e7a35f">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,'-given_conversations_between/2-fun-1-',4,
       [{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
        {line,543}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {inbox_extensions_SUITE,'-can_paginate_forwards/1-fun-0-',4,
       [{file,
          "/home/circleci/project/big_tests...

Report log

inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_backwards
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"bob_can_paginate_backwards_1517@localhost/res1">>,
          escalus_tcp,<0.10191.1>,
          [{event_manager,<0.10173.1>},
           {server,<<"localhost">>},
           {username,<<"bOb_can_paginate_backwards_1517">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.10173.1>},
            {server,<<"localhost">>},
            {username,<<"bOb_can_paginate_backwards_1517">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bob_can_paginate_backwards_1517">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_can_paginate_backwards_1517">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"037eab7e458671ed">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,'-given_conversations_between/2-fun-1-',4,
       [{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
        {line,543}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {inbox_extensions_SUITE,'-can_paginate_backwards/1-fun-0-',4,
       [{file,
          "/home/circleci/project/big...

Report log

inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_fetch_ahead
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bob_max_queries_can_fetch_ahead_1518@localhost/res1">>,
          escalus_tcp,<0.10190.1>,
          [{event_manager,<0.10180.1>},
           {server,<<"localhost">>},
           {username,<<"bOb_max_queries_can_fetch_ahead_1518">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.10180.1>},
            {server,<<"localhost">>},
            {username,<<"bOb_max_queries_can_fetch_ahead_1518">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bob_max_queries_can_fetch_ahead_1518">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_max_queries_can_fetch_ahead_1518">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"abc8f4855b57f572">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,'-given_conversations_between/2-fun-1-',4,
       [{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
        {line,543}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {inbox_extensions_SUITE,'-max_queries_can_fetch_ahead/1-fun-0-',4,
       [{fi...

Report log

inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_be_limited
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bob_max_queries_can_be_limited_1514@localhost/res1">>,
          escalus_tcp,<0.10188.1>,
          [{event_manager,<0.10152.1>},
           {server,<<"localhost">>},
           {username,<<"bOb_max_queries_can_be_limited_1514">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.10152.1>},
            {server,<<"localhost">>},
            {username,<<"bOb_max_queries_can_be_limited_1514">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bob_max_queries_can_be_limited_1514">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_max_queries_can_be_limited_1514">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"9d3cc3c21d1641a6">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,'-given_conversations_between/2-fun-1-',4,
       [{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
        {line,543}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {inbox_extensions_SUITE,'-max_queries_can_be_limited/1-fun-0-',4,
       [{file,
  ...

Report log

inbox_extensions_SUITE:regular:one_to_one:pagination:pagination_overrides_form
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"kate_pagination_overrides_form_1515@localhost/res1">>,
          escalus_tcp,<0.10192.1>,
          [{event_manager,<0.10159.1>},
           {server,<<"localhost">>},
           {username,<<"kate_pagination_overrides_form_1515">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.10159.1>},
            {server,<<"localhost">>},
            {username,<<"kate_pagination_overrides_form_1515">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"kate_pagination_overrides_form_1515">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"kate_pagination_overrides_form_1515">>},
           {server,<<"localhost">>},
           {password,<<"makrowe;p">>},
           {stream_id,<<"18cbb60f096720d8">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,'-given_conversations_between/2-fun-1-',4,
       [{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
        {line,543}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {inbox_extensions_SUITE,'-pagination_overrides_form/1-fun-0-',4,
       [{file,
 ...

Report log

pep_SUITE:pep_tests:publish_and_notify_test
{error,{{assertion_failed,assert_many,false,[is_presence],[],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,109}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log


dynamic_domains_mysql_redis_25 / mysql_redis / 8d04e95
Reports root/ big
OK: 4092 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 8d04e95
Reports root/ big
OK: 4492 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@pawlooss1 pawlooss1 marked this pull request as ready for review December 1, 2022 13:02
@NelsonVides NelsonVides merged commit c90358e into master Dec 1, 2022
@NelsonVides NelsonVides deleted the hooks/auth_tokens_SUITE branch December 1, 2022 15:37
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants