-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling in vcard #3890
Conversation
small_tests_24 / small_tests / f6346b2 small_tests_25 / small_tests / f6346b2 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / f6346b2 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / f6346b2 dynamic_domains_mysql_redis_25 / mysql_redis / f6346b2 ldap_mnesia_25 / ldap_mnesia / f6346b2 ldap_mnesia_24 / ldap_mnesia / f6346b2 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / f6346b2 graphql_server_SUITE:admin_http:clustering_http_tests:remove_alive_from_cluster_http{error,{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost,
timeout => 60000},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{graphql_server_SUITE,remove_alive_from_cluster_http,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,267}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} graphql_server_SUITE:admin_http:clustering_http_tests:remove_node_test{error,{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost},
mongoose_config,get_opt,
[listen]],
[{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{graphql_helper,get_listener_config,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,143}]},
{graphql_helper,get_listener_port,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,138}]},
{graphql_helper,build_request,4,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,24}]},
{graphql_helper,execute,4,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,20}]},
{graphql_server_SUITE,remove_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,210}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]}]}} graphql_server_SUITE:admin_http:clustering_http_tests:stop_node_test{error,{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost},
mongoose_config,get_opt,
[listen]],
[{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{graphql_helper,get_listener_config,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,143}]},
{graphql_helper,get_listener_port,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,138}]},
{graphql_helper,build_request,4,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,24}]},
{graphql_helper,execute,4,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,20}]},
{graphql_server_SUITE,stop_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,215}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:remove_dead_from_cluster{error,{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost,
timeout => 60000},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{graphql_server_SUITE,remove_dead_from_cluster,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,176}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:remove_alive_from_cluster{error,{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost,
timeout => 60000},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{graphql_server_SUITE,remove_alive_from_cluster,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,199}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:remove_node_test{error,{#{expected_type => ok,
response_code => {exit_status,3},
what => invalid_response_code},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_server_SUITE,remove_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,210}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:stop_node_test{error,{#{expected_type => ok,
response_code => {exit_status,3},
what => invalid_response_code},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_server_SUITE,stop_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,215}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} service_mongoose_system_metrics_SUITE:log_transparency:just_removed_from_config_logs_question{error,
{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost},
mongoose_service,ensure_stopped,
[service_mongoose_system_metrics]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{service_mongoose_system_metrics_SUITE,disable_system_metrics,1,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,435}]},
{service_mongoose_system_metrics_SUITE,
just_removed_from_config_logs_question,1,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,283}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} service_domain_db_SUITE:init_per_suite{'EXIT',
{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost},
mongoose_service,loaded_services_with_opts,[]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{dynamic_services,save_services,2,
[{file,
"/home/circleci/project/big_tests/tests/dynamic_services.erl"},
{line,15}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{service_domain_db_SUITE,init_per_suite,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,176}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1379}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} pgsql_mnesia_24 / pgsql_mnesia / f6346b2 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / f6346b2 disco_and_caps_SUITE:disco_with_caps:user_cannot_query_friend_resources_with_unknown_node{error,{{assertion_failed,assert_many,false,[is_roster_set,is_presence],[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-make_all_clients_friends/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,111}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{escalus_utils,distinct_pairs,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,60}]},
{escalus_story,make_all_clients_friends,1,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,106}]}]}} rest_client_SUITE:roster:add_contact_and_invite{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.20841.2>,
[{event_manager,<0.20799.2>},
{server,<<"domain.example.com">>},
{username,<<"bOb_add_contact_and_invite_2712">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.20799.2>},
{server,<<"domain.example.com">>},
{username,<<"bOb_add_contact_and_invite_2712">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_add_contact_and_invite_2712">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_add_contact_and_invite_2712">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"9357fc1b63495490">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{rest_client_SUITE,'-add_contact_and_invite/1-fun-0-',2,
[{file,
"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,1185}]},
{escalus_story,story,4,
[{file,
"/home/circl... smart_markers_SUITE:regular:one2one:remove_markers_when_removed_user{error,{{timeout,true,[{times,50,false}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{smart_markers_SUITE,'-remove_markers_when_removed_user/1-fun-2-',2,
[{file,"/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
{line,244}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} internal_mnesia_25 / internal_mnesia / f6346b2 pgsql_mnesia_25 / pgsql_mnesia / f6346b2 riak_mnesia_24 / riak_mnesia / f6346b2 mysql_redis_25 / mysql_redis / f6346b2 mssql_mnesia_25 / odbc_mssql_mnesia / f6346b2 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / f6346b2 disco_and_caps_SUITE:disco_with_caps:user_cannot_query_friend_resources_with_unknown_node{error,{{assertion_failed,assert_many,false,[is_roster_set],[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-make_all_clients_friends/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,108}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{escalus_utils,distinct_pairs,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,60}]},
{escalus_story,make_all_clients_friends,1,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,106}]}]}} muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / f6346b2 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / f6346b2 inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_backwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.9879.1>,
[{event_manager,<0.9857.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_can_paginate_backwards_1547">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.9857.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_can_paginate_backwards_1547">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_can_paginate_backwards_1547">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_can_paginate_backwards_1547">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"64e5a3f8c0a61933">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE,'-... inbox_extensions_SUITE:regular:one_to_one:pagination:pagination_overrides_form{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.9887.1>,
[{event_manager,<0.9836.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_pagination_overrides_form_1544">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.9836.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_pagination_overrides_form_1544">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_pagination_overrides_form_1544">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_pagination_overrides_form_1544">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"80d776900634fe45">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inb... inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_forwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.9884.1>,
[{event_manager,<0.9850.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_can_paginate_forwards_1546">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.9850.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_can_paginate_forwards_1546">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_forwards_1546">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_forwards_1546">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"8d7e39e1dcd168b5">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,... inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_fetch_ahead{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.9885.1>,
[{event_manager,<0.9864.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_max_queries_can_fetch_ahead_1548">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.9864.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_max_queries_can_fetch_ahead_1548">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_max_queries_can_fetch_ahead_1548">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_max_queries_can_fetch_ahead_1548">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"eeb369f468dd8494">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},... inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_be_limited{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.9886.1>,
[{event_manager,<0.9871.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_max_queries_can_be_limited_1549">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.9871.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_max_queries_can_be_limited_1549">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_max_queries_can_be_limited_1549">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_max_queries_can_be_limited_1549">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"b85558eee88fca74">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
... dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / f6346b2 |
Codecov ReportBase: 83.11% // Head: 83.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3890 +/- ##
==========================================
+ Coverage 83.11% 83.14% +0.02%
==========================================
Files 535 535
Lines 34203 34208 +5
==========================================
+ Hits 28428 28442 +14
+ Misses 5775 5766 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good in general, I just found the following minor issues.
JID is not converted to binary in error messages:
$ _build/mim1/rel/mongooseim/bin/mongooseimctl vcard getVcard --user alic@localhosta
{
"errors" : [
{
"path" : [
"vcard",
"getVcard"
],
"message" : "User's domain does not exist",
"extensions" : {
"user" : "{jid,<<\"alic\">>,<<\"localhosta\">>,<<>>}",
"code" : "user_not_found"
}
}
],
"data" : {
"vcard" : {
"getVcard" : null
}
}
}
Passing a list instead of a map results in a crash:
$ _build/mim1/rel/mongooseim/bin/mongooseimctl vcard setVcard --user alice@localhost --vcard '{"formattedName":"Alice", "nameComponents":[]}'
Failed RPC connection to the node mongooseim@localhost: {'EXIT',
{function_clause,
[{graphql_err,
type_check_err_msg,
[{type_mismatch,
#{document => [],
schmema =>
{input_object_type,
<<"NameComponentsInput">>,
<<"No description provided">>,
[],
#{<<"family">> =>
{schema_arg,
<<"String">>,
undefined,
<<"User's family name">>,
[]},
<<"givenName">> =>
{schema_arg,
<<"String">>,
undefined,
<<"User's name">>,
[]},
<<"middleName">> =>
{schema_arg,
<<"String">>,
undefined,
<<"User's middle name">>,
[]},
<<"prefix">> =>
{schema_arg,
<<"String">>,
undefined,
<<"Prefix to the name">>,
[]},
<<"suffix">> =>
{schema_arg,
<<"String">>,
undefined,
<<"Suffix to the name">>,
[]}}}}}],
[{file,
"/home/lth/dev/mongoose/_build/default/lib/graphql/src/graphql_err.erl"},
{line,231}]},
{graphql_err,
format_errors_,2,
[{file,
"/home/lth/dev/mongoose/_build/default/lib/graphql/src/graphql_err.erl"},
{line,74}]},
{mongoose_graphql_errors,
format_error,1,
[{file,
"/home/lth/dev/mongoose/src/graphql/mongoose_graphql_errors.erl"},
{line,45}]},
{ejabberd_ctl,
handle_graphql_result,
1,
[{file,
"/home/lth/dev/mongoose/src/ejabberd_ctl.erl"},
{line,253}]},
{ejabberd_ctl,
process,1,[]}]}}
The second error will be fixed here: esl/graphql-erlang#3. |
small_tests_24 / small_tests / f1fdc67 small_tests_25 / small_tests / f1fdc67 ldap_mnesia_24 / ldap_mnesia / f1fdc67 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / f1fdc67 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / f1fdc67 dynamic_domains_mysql_redis_25 / mysql_redis / f1fdc67 ldap_mnesia_25 / ldap_mnesia / f1fdc67 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / f1fdc67 smart_markers_SUITE:regular:one2one:repeated_markers_produce_no_warnings{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_repeated_markers_produce_no_warnings_2683@domain.example.com/res1">>,
escalus_tcp,<0.27756.2>,
[{event_manager,<0.27739.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_repeated_markers_produce_no_warnings_2683">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.27739.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_repeated_markers_produce_no_warnings_2683">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_repeated_markers_produce_no_warnings_2683">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_repeated_markers_produce_no_warnings_2683">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"31e890a2abc5285c">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{smart_markers_SUITE,
'-repeated_markers_produce_no_warnings/1-fun-1-',2,
[{file,
... smart_markers_SUITE:regular:one2one:remove_markers_when_removed_user{error,{{badrpc,timeout},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},
ejabberd_auth,remove_user,
[{jid,<<"bob_remove_markers_when_removed_user_2682">>,
<<"domain.example.com">>,<<>>}]],
[{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{smart_markers_SUITE,'-remove_markers_when_removed_user/1-fun-2-',2,
[{file,"/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
{line,245}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} smart_markers_SUITE:regular:one2one:marker_after_timestamp_for_threadid_can_be_fetched{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_marker_after_timestamp_for_threadid_can_be_fetched_2684@domain.example.com/res1">>,
escalus_tcp,<0.27757.2>,
[{event_manager,<0.27746.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_marker_after_timestamp_for_threadid_can_be_fetched_2684">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.27746.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_marker_after_timestamp_for_threadid_can_be_fetched_2684">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_marker_after_timestamp_for_threadid_can_be_fetched_2684">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_marker_after_timestamp_for_threadid_can_be_fetched_2684">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"8d3b99c463580ba4">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{smart_markers_SUITE,
... smart_markers_SUITE:regular:one2one:marker_for_thread_can_be_fetched{error,
{{fetch_marker,ok,
[{times,50,
{error,
{badmatch,[]},
[{smart_markers_SUITE,'-verify_marker_fetch/4-fun-6-',3,
[{file,
"/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
{line,405}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} pgsql_mnesia_24 / pgsql_mnesia / f1fdc67 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / f1fdc67 riak_mnesia_24 / riak_mnesia / f1fdc67 mysql_redis_25 / mysql_redis / f1fdc67 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} pgsql_mnesia_25 / pgsql_mnesia / f1fdc67 mssql_mnesia_25 / odbc_mssql_mnesia / f1fdc67 inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_fetch_ahead{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bob_max_queries_can_fetch_ahead_1544@localhost/res1">>,
escalus_tcp,<0.10141.1>,
[{event_manager,<0.10130.1>},
{server,<<"localhost">>},
{username,<<"bOb_max_queries_can_fetch_ahead_1544">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10130.1>},
{server,<<"localhost">>},
{username,<<"bOb_max_queries_can_fetch_ahead_1544">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_max_queries_can_fetch_ahead_1544">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_max_queries_can_fetch_ahead_1544">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"a33f80df9cafb324">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE,'-max_queries_can_fetch_ahead/1-fun-0-',4,
[{fi... inbox_extensions_SUITE:regular:one_to_one:pagination:pagination_overrides_form{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"kate_pagination_overrides_form_1539@localhost/res1">>,
escalus_tcp,<0.10142.1>,
[{event_manager,<0.10095.1>},
{server,<<"localhost">>},
{username,<<"kate_pagination_overrides_form_1539">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10095.1>},
{server,<<"localhost">>},
{username,<<"kate_pagination_overrides_form_1539">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_pagination_overrides_form_1539">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_pagination_overrides_form_1539">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"d1a76a70bd24c6bb">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-pagination_overrides_form/1-fun-0-',4,
[{file,
... inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_forwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"kate_can_paginate_forwards_1540@localhost/res1">>,
escalus_tcp,<0.10143.1>,
[{event_manager,<0.10102.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_forwards_1540">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10102.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_forwards_1540">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_forwards_1540">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_forwards_1540">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"ec33610bcc6a6872">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-can_paginate_forwards/1-fun-0-',4,
[{file,
"/home/circleci/project/bi... inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_backwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"kate_can_paginate_backwards_1541@localhost/res1">>,
escalus_tcp,<0.10144.1>,
[{event_manager,<0.10109.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_backwards_1541">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10109.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_backwards_1541">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_backwards_1541">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_backwards_1541">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"4a2a0a29fb89e7c4">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-can_paginate_backwards/1-fun-0-',4,
[{file,
"/home/circleci/proj... inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_be_limited{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"kate_max_queries_can_be_limited_1543@localhost/res1">>,
escalus_tcp,<0.10145.1>,
[{event_manager,<0.10123.1>},
{server,<<"localhost">>},
{username,<<"kate_max_queries_can_be_limited_1543">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10123.1>},
{server,<<"localhost">>},
{username,<<"kate_max_queries_can_be_limited_1543">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_max_queries_can_be_limited_1543">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_max_queries_can_be_limited_1543">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"4bf9dc6a4e508c8c">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-max_queries_can_be_limited/1-fun-0-',4,
[{f... |
f1fdc67
to
69a7261
Compare
small_tests_24 / small_tests / 69a7261 small_tests_25 / small_tests / 69a7261 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 69a7261 ldap_mnesia_24 / ldap_mnesia / 69a7261 dynamic_domains_mysql_redis_25 / mysql_redis / 69a7261 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 69a7261 ldap_mnesia_25 / ldap_mnesia / 69a7261 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 69a7261 internal_mnesia_25 / internal_mnesia / 69a7261 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 69a7261 pgsql_mnesia_24 / pgsql_mnesia / 69a7261 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2729@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2729@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"r9soEQMO8s/GkutM9DVXTA==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} riak_mnesia_24 / riak_mnesia / 69a7261 pgsql_mnesia_25 / pgsql_mnesia / 69a7261 mssql_mnesia_25 / odbc_mssql_mnesia / 69a7261 mysql_redis_25 / mysql_redis / 69a7261 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good 👌
Improve error handling in vcard