Improve error handling in mnesia API #3896
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 83.21% // Head: 83.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3896 +/- ##
=======================================
Coverage 83.21% 83.21%
=======================================
Files 535 535
Lines 34269 34275 +6
=======================================
+ Hits 28517 28522 +5
- Misses 5752 5753 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jacekwegr
force-pushed
the
improve-error-handling-in-mnesia-api
branch
from
268f017
to
af3b39c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jacekwegr
force-pushed
the
improve-error-handling-in-mnesia-api
branch
from
af3b39c
to
7adaca7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jacekwegr
force-pushed
the
improve-error-handling-in-mnesia-api
branch
from
7adaca7
to
429d930
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jacekwegr
force-pushed
the
improve-error-handling-in-mnesia-api
branch
from
e6b93f3
to
d44f1df
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jacekwegr
force-pushed
the
improve-error-handling-in-mnesia-api
branch
from
d44f1df
to
1fcfb88
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jacekwegr
force-pushed
the
improve-error-handling-in-mnesia-api
branch
from
1fcfb88
to
fa72d70
Compare
|
small_tests_24 / small_tests / fa72d70 small_tests_25 / small_tests / fa72d70 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / fa72d70 ldap_mnesia_24 / ldap_mnesia / fa72d70 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / fa72d70 dynamic_domains_mysql_redis_25 / mysql_redis / fa72d70 ldap_mnesia_25 / ldap_mnesia / fa72d70 internal_mnesia_25 / internal_mnesia / fa72d70 pgsql_mnesia_24 / pgsql_mnesia / fa72d70 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / fa72d70 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / fa72d70 disco_and_caps_SUITE:disco_with_caps:user_can_query_friend_resources{error,{{assertion_failed,assert_many,false,[is_roster_set],[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-make_all_clients_friends/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,112}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{escalus_utils,distinct_pairs,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,60}]},
{escalus_story,make_all_clients_friends,1,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,106}]}]}}riak_mnesia_24 / riak_mnesia / fa72d70 pgsql_mnesia_25 / pgsql_mnesia / fa72d70 mysql_redis_25 / mysql_redis / fa72d70 mssql_mnesia_25 / odbc_mssql_mnesia / fa72d70 |
jacekwegr
force-pushed
the
improve-error-handling-in-mnesia-api
branch
from
fa72d70
to
f6ab093
Compare
|
small_tests_24 / small_tests / f6ab093 small_tests_25 / small_tests / f6ab093 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / f6ab093 ldap_mnesia_24 / ldap_mnesia / f6ab093 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / f6ab093 ldap_mnesia_25 / ldap_mnesia / f6ab093 dynamic_domains_mysql_redis_25 / mysql_redis / f6ab093 internal_mnesia_25 / internal_mnesia / f6ab093 pgsql_mnesia_24 / pgsql_mnesia / f6ab093 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / f6ab093 riak_mnesia_24 / riak_mnesia / f6ab093 graphql_server_SUITE:admin_http:clustering_http_tests:remove_dead_from_cluster_http{error,
{{badrpc,
{'EXIT',
{{try_clause,
{badrpc,{'EXIT',{aborted,{no_exists,node,storage_type}}}}},
[{mongoose_cluster,table_type,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,158}]},
{mongoose_cluster,'-unsafe_join/2-lc$^0/1-0-',2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,119}]},
{mongoose_cluster,unsafe_join,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,120}]},
{mongoose_cluster,with_app_stopped,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,221}]},
{global,trans,4,[{file,"global.erl"},{line,463}]},
{mongoose_cluster,join,1,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost,timeout => 60000},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{graphql_server_SUITE,remove_dead_from_cluster_http,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,247}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / f6ab093 pgsql_mnesia_25 / pgsql_mnesia / f6ab093 mysql_redis_25 / mysql_redis / f6ab093 mssql_mnesia_25 / odbc_mssql_mnesia / f6ab093 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2677@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2677@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"hgoWNDHgdwiHBFt+Jb07aA==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}riak_mnesia_24 / riak_mnesia / f6ab093 |
This PR changes some of the returned values from the "mnesia" module's functions to be more consistent with the whole GraphQL API and adds a new scalar GraphQL type "NodeName" to check whether the provided string is a valid Erlang node name.