-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document hooks refactor #3903
Document hooks refactor #3903
Conversation
small_tests_24 / small_tests / b01caf1 small_tests_25 / small_tests / b01caf1 ldap_mnesia_24 / ldap_mnesia / b01caf1 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b01caf1 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b01caf1 ldap_mnesia_25 / ldap_mnesia / b01caf1 dynamic_domains_mysql_redis_25 / mysql_redis / b01caf1 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b01caf1 pgsql_mnesia_24 / pgsql_mnesia / b01caf1 internal_mnesia_25 / internal_mnesia / b01caf1 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b01caf1 pgsql_mnesia_25 / pgsql_mnesia / b01caf1 riak_mnesia_24 / riak_mnesia / b01caf1 mysql_redis_25 / mysql_redis / b01caf1 mssql_mnesia_25 / odbc_mssql_mnesia / b01caf1 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} |
Codecov ReportBase: 83.14% // Head: 83.17% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3903 +/- ##
==========================================
+ Coverage 83.14% 83.17% +0.02%
==========================================
Files 535 535
Lines 34112 34112
==========================================
+ Hits 28362 28371 +9
+ Misses 5750 5741 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. I agree with what @NelsonVides suggested, and the branch needs rebasing because of conflicts.
Co-authored-by: Nelson Vides <[email protected]>
b00b896
to
0e97e00
Compare
small_tests_24 / small_tests / b00b896 small_tests_25 / small_tests / b00b896 ldap_mnesia_24 / ldap_mnesia / b00b896 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b00b896 ldap_mnesia_25 / ldap_mnesia / b00b896 dynamic_domains_mysql_redis_25 / mysql_redis / b00b896 sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_send_message_without_ack{error,
{{assertion_failed,assert,is_presence,
{xmlel,<<"message">>,
[{<<"from">>,
<<"bob_resume_session_state_send_message_without_ack_2654@domain.example.com/escalus-default-resource">>},
{<<"to">>,
<<"alice_resume_session_state_send_message_without_ack_2663@domain.example.com">>},
{<<"xml:lang">>,<<"en">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"msg-3">>}]}]},
"<message from='bob_resume_session_state_send_message_without_ack_2654@domain.example.com/escalus-default-resource' to='alice_resume_session_state_send_message_without_ack_2663@domain.example.com' xml:lang='en' type='chat'><body>msg-3</body></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{sm_helper,initial_presence_step,2,
[{file,"/home/circleci/project/big_tests/tests/sm_helper.erl"},
{line,133}]},
{escalus_connection,connection_step,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,162}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{escalus_connection,start,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_helper,connect_spec,3,
[{file,"/home/circleci/project/big_tests/test... dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b00b896 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b00b896 mod_blocking_SUITE:manage:add_user_to_blocklist_with_white_spaces{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_unnamed_2335_add_user_to_blocklist_with_white_spaces_2338@domain.example.com/res1">>,
escalus_tcp,<0.5904.2>,
[{event_manager,<0.5852.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_unnamed_2335_add_user_to_blocklist_with_white_spaces_2338">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.5852.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_unnamed_2335_add_user_to_blocklist_with_white_spaces_2338">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_unnamed_2335_add_user_to_blocklist_with_white_spaces_2338">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_unnamed_2335_add_user_to_blocklist_with_white_spaces_2338">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"ea0870344889f982">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{mod_blocking_SUITE,
... mod_blocking_SUITE:manage:add_user_to_blocklist{error,{{assertion_failed,assert_many,false,
[is_iq_result,#Fun<mod_blocking_SUITE.32.29136960>],
[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{mod_blocking_SUITE,'-add_user_to_blocklist/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/mod_blocking_SUITE.erl"},
{line,162}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mod_blocking_SUITE:manage:add_many_users_to_blocklist{error,{{badmatch,0},
[{escalus_story,drop_presences,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,191}]},
{escalus_story,'-start_ready_clients/2-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,135}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{escalus_story,start_ready_clients,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,128}]},
{lists,flatmap_1,2,[{file,"lists.erl"},{line,1335}]},
{lists,flatmap_1,2,[{file,"lists.erl"},{line,1335}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,69}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]}]}} mod_blocking_SUITE:manage:clear_blocklist{error,{{assertion_failed,assert_many,false,
[is_iq_result,#Fun<mod_blocking_SUITE.32.29136960>],
[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{mod_blocking_SUITE,'-clear_blocklist/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/mod_blocking_SUITE.erl"},
{line,223}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mod_blocking_SUITE:manage:remove_user_from_blocklist{error,{{assertion_failed,assert_many,false,
[is_iq_result,#Fun<mod_blocking_SUITE.36.29136960>],
[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{mod_blocking_SUITE,'-remove_user_from_blocklist/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/mod_blocking_SUITE.erl"},
{line,203}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mod_blocking_SUITE:manage:remove_many_user_from_blocklist{error,{{assertion_failed,assert_many,false,
[is_iq_result,#Fun<mod_blocking_SUITE.35.29136960>],
[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{mod_blocking_SUITE,'-remove_many_user_from_blocklist/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/mod_blocking_SUITE.erl"},
{line,213}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mod_blocking_SUITE:manage:add_another_user_to_blocklist{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_unnamed_2335_add_another_user_to_blocklist_2342@domain.example.com/res1">>,
escalus_tcp,<0.5906.2>,
[{event_manager,<0.5880.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_unnamed_2335_add_another_user_to_blocklist_2342">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.5880.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_unnamed_2335_add_another_user_to_blocklist_2342">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_unnamed_2335_add_another_user_to_blocklist_2342">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_unnamed_2335_add_another_user_to_blocklist_2342">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"abcfbc4757eee5ab">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{mod_blocking_SUITE,'-add_another_user_to_blocklist/1-fun-0-',2,
... mod_blocking_SUITE:manage:remove_many_user_from_blocklist{error,
{{badrpc,
{'EXIT',
{timeout,
{gen_server,call,
['wpool_pool-mongoose_wpool$rdbms$global$default-1',
{sql_cmd,
{sql_execute,auth_get_password,
[<<"domain.example.com">>,
<<"kate_unnamed_2346_remove_many_user_from_blocklist_2354">>]},
-576460041072},
60000]}}}},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"kate_unnamed_2346_remove_many_user_from_blocklist_2354">>,
<<"domain.example.com">>,<<"makrowe;p">>],
3000,ejabberd],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
{escalus_ejabberd,create_users,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[... internal_mnesia_25 / internal_mnesia / b00b896 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b00b896 pgsql_mnesia_24 / pgsql_mnesia / b00b896 riak_mnesia_24 / riak_mnesia / b00b896 pgsql_mnesia_25 / pgsql_mnesia / b00b896 mysql_redis_25 / mysql_redis / b00b896 vcard_SUITE:ro_full:retrieve_own_card{error,{test_case_failed,"Expected <<\"alice\">> got undefined\n"}} mssql_mnesia_25 / odbc_mssql_mnesia / b00b896 rest_client_SUITE:roster:add_contact_and_invite{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"bob_add_contact_and_invite_3151@localhost/res1">>,
escalus_tcp,<0.4169.3>,
[{event_manager,<0.4146.3>},
{server,<<"localhost">>},
{username,<<"bOb_add_contact_and_invite_3151">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.4146.3>},
{server,<<"localhost">>},
{username,<<"bOb_add_contact_and_invite_3151">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_add_contact_and_invite_3151">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_add_contact_and_invite_3151">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"d4e0e0b72fb74a5e">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{rest_client_SUITE,'-add_contact_and_invite/1-fun-0-',2,
[{file,
"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,1184}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},... |
small_tests_24 / small_tests / 0e97e00 small_tests_25 / small_tests / 0e97e00 ldap_mnesia_24 / ldap_mnesia / 0e97e00 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0e97e00 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 0e97e00 dynamic_domains_mysql_redis_25 / mysql_redis / 0e97e00 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 0e97e00 ldap_mnesia_25 / ldap_mnesia / 0e97e00 pgsql_mnesia_24 / pgsql_mnesia / 0e97e00 bosh_SUITE:essential_https:accept_higher_hold_value{error,
{{assertEqual,
[{module,bosh_SUITE},
{line,251},
{expression,"get_bosh_sessions ( )"},
{expected,[]},
{value,
[{bosh_session,<<"233750821e1455fa2abb8d2ab384586b60e9d188">>,
<8846.6099.0>}]}]},
[{bosh_SUITE,accept_higher_hold_value,1,
[{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
{line,251}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 0e97e00 internal_mnesia_25 / internal_mnesia / 0e97e00 riak_mnesia_24 / riak_mnesia / 0e97e00 pgsql_mnesia_25 / pgsql_mnesia / 0e97e00 mysql_redis_25 / mysql_redis / 0e97e00 mssql_mnesia_25 / odbc_mssql_mnesia / 0e97e00 pgsql_mnesia_24 / pgsql_mnesia / 0e97e00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This PR updates hooks and handlers documentation.