-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inbox/extend messages #3910
Inbox/extend messages #3910
Conversation
small_tests_25 / small_tests / f354ada small_tests_24 / small_tests / f354ada |
It happens that handler to extend inbox entries want to fetch extra data for each entry, so if the hook is ran per message, the handler will have to make an extra query for each message, potentially incurring into way too many round trips to the DB. Instead, we can pass the whole buffer to the handler, so that the handler is able to aggregate as best as possible all the entries.
Codecov ReportBase: 83.14% // Head: 83.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3910 +/- ##
=======================================
Coverage 83.14% 83.15%
=======================================
Files 535 535
Lines 34112 34110 -2
=======================================
- Hits 28364 28363 -1
+ Misses 5748 5747 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
f354ada
to
f6b16c8
Compare
small_tests_24 / small_tests / f6b16c8 small_tests_25 / small_tests / f6b16c8 ldap_mnesia_24 / ldap_mnesia / f6b16c8 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / f6b16c8 dynamic_domains_mysql_redis_25 / mysql_redis / f6b16c8 ldap_mnesia_25 / ldap_mnesia / f6b16c8 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / f6b16c8 internal_mnesia_25 / internal_mnesia / f6b16c8 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / f6b16c8 pgsql_mnesia_24 / pgsql_mnesia / f6b16c8 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / f6b16c8 riak_mnesia_24 / riak_mnesia / f6b16c8 mysql_redis_25 / mysql_redis / f6b16c8 pgsql_mnesia_25 / pgsql_mnesia / f6b16c8 mssql_mnesia_25 / odbc_mssql_mnesia / f6b16c8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
It happens that handler to extend inbox entries want to fetch extra data for each entry, so if the
hook is ran per message, the handler will have to make an extra query for each message, potentially
incurring into way too many round trips to the DB. Instead, we can pass the whole buffer to the
handler, so that the handler is able to aggregate as best as possible all the entries.