-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C2s/fix sm timeouts [merge after 3931] #3934
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 82.67% // Head: 83.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## c2s/enable-remaining-suites #3934 +/- ##
===============================================================
+ Coverage 82.67% 83.49% +0.81%
===============================================================
Files 540 539 -1
Lines 34229 33962 -267
===============================================================
+ Hits 28298 28355 +57
+ Misses 5931 5607 -324
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
d6e2544
to
1fedc01
Compare
small_tests_24 / small_tests / 1fedc01 small_tests_25 / small_tests / 1fedc01 ldap_mnesia_24 / ldap_mnesia / 1fedc01 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1fedc01 ldap_mnesia_25 / ldap_mnesia / 1fedc01 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1fedc01 pgsql_mnesia_24 / pgsql_mnesia / 1fedc01 dynamic_domains_mysql_redis_25 / mysql_redis / 1fedc01 internal_mnesia_25 / internal_mnesia / 1fedc01 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 1fedc01 pgsql_mnesia_25 / pgsql_mnesia / 1fedc01 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 1fedc01 riak_mnesia_24 / riak_mnesia / 1fedc01 mysql_redis_25 / mysql_redis / 1fedc01 mssql_mnesia_25 / odbc_mssql_mnesia / 1fedc01 inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_fetch_ahead{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bob_max_queries_can_fetch_ahead_1533@localhost/res1">>,
escalus_tcp,<0.13125.1>,
[{event_manager,<0.13115.1>},
{server,<<"localhost">>},
{username,<<"bOb_max_queries_can_fetch_ahead_1533">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.13115.1>},
{server,<<"localhost">>},
{username,<<"bOb_max_queries_can_fetch_ahead_1533">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_max_queries_can_fetch_ahead_1533">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_max_queries_can_fetch_ahead_1533">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"8d1c435d796b088f">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE,'-max_queries_can_fetch_ahead/1-fun-0-',4,
[{fi... inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_be_limited{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bob_max_queries_can_be_limited_1530@localhost/res1">>,
escalus_tcp,<0.13131.1>,
[{event_manager,<0.13094.1>},
{server,<<"localhost">>},
{username,<<"bOb_max_queries_can_be_limited_1530">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.13094.1>},
{server,<<"localhost">>},
{username,<<"bOb_max_queries_can_be_limited_1530">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_max_queries_can_be_limited_1530">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_max_queries_can_be_limited_1530">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"5df2224fcd995bed">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE,'-max_queries_can_be_limited/1-fun-0-',4,
[{file,
... inbox_extensions_SUITE:regular:one_to_one:pagination:pagination_overrides_form{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bob_pagination_overrides_form_1532@localhost/res1">>,
escalus_tcp,<0.13133.1>,
[{event_manager,<0.13108.1>},
{server,<<"localhost">>},
{username,<<"bOb_pagination_overrides_form_1532">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.13108.1>},
{server,<<"localhost">>},
{username,<<"bOb_pagination_overrides_form_1532">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_pagination_overrides_form_1532">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_pagination_overrides_form_1532">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"b9999e4d9cb38584">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE,'-pagination_overrides_form/1-fun-0-',4,
[{file,
... inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_backwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"bob_can_paginate_backwards_1529@localhost/res1">>,
escalus_tcp,<0.13129.1>,
[{event_manager,<0.13087.1>},
{server,<<"localhost">>},
{username,<<"bOb_can_paginate_backwards_1529">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.13087.1>},
{server,<<"localhost">>},
{username,<<"bOb_can_paginate_backwards_1529">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_can_paginate_backwards_1529">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_can_paginate_backwards_1529">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"6ea74e91a33a636a">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE,'-can_paginate_backwards/1-fun-0-',4,
[{file,
"/home/circleci/project/big... inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_forwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"kate_can_paginate_forwards_1528@localhost/res1">>,
escalus_tcp,<0.13132.1>,
[{event_manager,<0.13080.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_forwards_1528">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.13080.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_forwards_1528">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_forwards_1528">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_forwards_1528">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"e6ed7b8e6c6ed695">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-can_paginate_forwards/1-fun-0-',4,
[{file,
"/home/circleci/project/bi... inbox_extensions_SUITE:async_pools:one_to_one:mute_muted_entry_gets_unmuted{error,
{{assert,
[{module,inbox_extensions_SUITE},
{line,882},
{expression,"escalus_pred : is_message ( Message )"},
{expected,true},
{value,false}]},
[{inbox_extensions_SUITE,check_message_with_properties,4,
[{file,
"/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
{line,882}]},
{inbox_extensions_SUITE,set_inbox_properties,4,
[{file,
"/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
{line,876}]},
{inbox_extensions_SUITE,'-mute_muted_entry_gets_unmuted/1-fun-2-',2,
[{file,
"/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
{line,575}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mssql_mnesia_25 / odbc_mssql_mnesia / 1fedc01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch(es)!! 🎉
Fix timeouts in
mod_ping
andmod_stream_management
.After introducing timeout actions some timeouts started being interpreted as milliseconds instead of seconds, causing one test to fail.
Also: found an unused legacy module.