Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C2s/fix sm timeouts [merge after 3931] #3934

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Jan 23, 2023

Fix timeouts in mod_ping and mod_stream_management.
After introducing timeout actions some timeouts started being interpreted as milliseconds instead of seconds, causing one test to fail.

Also: found an unused legacy module.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 82.67% // Head: 83.49% // Increases project coverage by +0.81% 🎉

Coverage data is based on head (1fedc01) compared to base (5c5f06e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           c2s/enable-remaining-suites    #3934      +/-   ##
===============================================================
+ Coverage                        82.67%   83.49%   +0.81%     
===============================================================
  Files                              540      539       -1     
  Lines                            34229    33962     -267     
===============================================================
+ Hits                             28298    28355      +57     
+ Misses                            5931     5607     -324     
Impacted Files Coverage Δ
src/mongoose_collector.erl 53.84% <ø> (ø)
...stream_management/mod_stream_management_mnesia.erl 85.36% <ø> (ø)
src/stream_management/mod_stream_management.erl 88.35% <100.00%> (ø)
...bal_distrib/mod_global_distrib_hosts_refresher.erl 66.66% <0.00%> (-2.23%) ⬇️
src/domain/service_domain_db.erl 83.33% <0.00%> (-2.09%) ⬇️
src/muc_light/mod_muc_light_db_mnesia.erl 91.57% <0.00%> (-1.06%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 73.49% <0.00%> (+0.12%) ⬆️
src/mod_presence.erl 86.06% <0.00%> (+0.30%) ⬆️
src/domain/mongoose_domain_loader.erl 90.17% <0.00%> (+0.89%) ⬆️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 23, 2023

small_tests_24 / small_tests / 1fedc01
Reports root / small


small_tests_25 / small_tests / 1fedc01
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 1fedc01
Reports root/ big
OK: 2213 / Failed: 0 / User-skipped: 823 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1fedc01
Reports root/ big
OK: 4163 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 1fedc01
Reports root/ big
OK: 2213 / Failed: 0 / User-skipped: 823 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1fedc01
Reports root/ big
OK: 4163 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 1fedc01
Reports root/ big
OK: 4541 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 1fedc01
Reports root/ big
OK: 4137 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 1fedc01
Reports root/ big
OK: 2355 / Failed: 0 / User-skipped: 681 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 1fedc01
Reports root/ big
OK: 4163 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 1fedc01
Reports root/ big
OK: 4541 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 1fedc01
Reports root/ big
OK: 2713 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 1fedc01
Reports root/ big
OK: 2551 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 1fedc01
Reports root/ big
OK: 4527 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 1fedc01
Reports root/ big
OK: 4535 / Failed: 6 / User-skipped: 97 / Auto-skipped: 0

inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_fetch_ahead
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bob_max_queries_can_fetch_ahead_1533@localhost/res1">>,
          escalus_tcp,<0.13125.1>,
          [{event_manager,<0.13115.1>},
           {server,<<"localhost">>},
           {username,<<"bOb_max_queries_can_fetch_ahead_1533">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.13115.1>},
            {server,<<"localhost">>},
            {username,<<"bOb_max_queries_can_fetch_ahead_1533">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bob_max_queries_can_fetch_ahead_1533">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_max_queries_can_fetch_ahead_1533">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"8d1c435d796b088f">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,'-given_conversations_between/2-fun-1-',4,
       [{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
        {line,543}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {inbox_extensions_SUITE,'-max_queries_can_fetch_ahead/1-fun-0-',4,
       [{fi...

Report log

inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_be_limited
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bob_max_queries_can_be_limited_1530@localhost/res1">>,
          escalus_tcp,<0.13131.1>,
          [{event_manager,<0.13094.1>},
           {server,<<"localhost">>},
           {username,<<"bOb_max_queries_can_be_limited_1530">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.13094.1>},
            {server,<<"localhost">>},
            {username,<<"bOb_max_queries_can_be_limited_1530">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bob_max_queries_can_be_limited_1530">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_max_queries_can_be_limited_1530">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"5df2224fcd995bed">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,'-given_conversations_between/2-fun-1-',4,
       [{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
        {line,543}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {inbox_extensions_SUITE,'-max_queries_can_be_limited/1-fun-0-',4,
       [{file,
  ...

Report log

inbox_extensions_SUITE:regular:one_to_one:pagination:pagination_overrides_form
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bob_pagination_overrides_form_1532@localhost/res1">>,
          escalus_tcp,<0.13133.1>,
          [{event_manager,<0.13108.1>},
           {server,<<"localhost">>},
           {username,<<"bOb_pagination_overrides_form_1532">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.13108.1>},
            {server,<<"localhost">>},
            {username,<<"bOb_pagination_overrides_form_1532">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bob_pagination_overrides_form_1532">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_pagination_overrides_form_1532">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"b9999e4d9cb38584">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,'-given_conversations_between/2-fun-1-',4,
       [{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
        {line,543}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {inbox_extensions_SUITE,'-pagination_overrides_form/1-fun-0-',4,
       [{file,
        ...

Report log

inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_backwards
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"bob_can_paginate_backwards_1529@localhost/res1">>,
          escalus_tcp,<0.13129.1>,
          [{event_manager,<0.13087.1>},
           {server,<<"localhost">>},
           {username,<<"bOb_can_paginate_backwards_1529">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.13087.1>},
            {server,<<"localhost">>},
            {username,<<"bOb_can_paginate_backwards_1529">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bob_can_paginate_backwards_1529">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_can_paginate_backwards_1529">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"6ea74e91a33a636a">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,'-given_conversations_between/2-fun-1-',4,
       [{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
        {line,543}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {inbox_extensions_SUITE,'-can_paginate_backwards/1-fun-0-',4,
       [{file,
          "/home/circleci/project/big...

Report log

inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_forwards
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"kate_can_paginate_forwards_1528@localhost/res1">>,
          escalus_tcp,<0.13132.1>,
          [{event_manager,<0.13080.1>},
           {server,<<"localhost">>},
           {username,<<"kate_can_paginate_forwards_1528">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.13080.1>},
            {server,<<"localhost">>},
            {username,<<"kate_can_paginate_forwards_1528">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"kate_can_paginate_forwards_1528">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"kate_can_paginate_forwards_1528">>},
           {server,<<"localhost">>},
           {password,<<"makrowe;p">>},
           {stream_id,<<"e6ed7b8e6c6ed695">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,'-given_conversations_between/2-fun-1-',4,
       [{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
        {line,543}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {inbox_extensions_SUITE,'-can_paginate_forwards/1-fun-0-',4,
       [{file,
          "/home/circleci/project/bi...

Report log

inbox_extensions_SUITE:async_pools:one_to_one:mute_muted_entry_gets_unmuted
{error,
  {{assert,
     [{module,inbox_extensions_SUITE},
      {line,882},
      {expression,"escalus_pred : is_message ( Message )"},
      {expected,true},
      {value,false}]},
   [{inbox_extensions_SUITE,check_message_with_properties,4,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,882}]},
    {inbox_extensions_SUITE,set_inbox_properties,4,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,876}]},
    {inbox_extensions_SUITE,'-mute_muted_entry_gets_unmuted/1-fun-2-',2,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,575}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mssql_mnesia_25 / odbc_mssql_mnesia / 1fedc01
Reports root/ big
OK: 4541 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@chrzaszcz chrzaszcz changed the title C2s/fix sm timeouts C2s/fix sm timeouts [merge after 3931] Jan 23, 2023
@chrzaszcz chrzaszcz marked this pull request as ready for review January 23, 2023 16:16
Base automatically changed from c2s/enable-remaining-suites to feature/mongoose_c2s January 23, 2023 16:46
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch(es)!! 🎉

@NelsonVides NelsonVides merged commit b6343e1 into feature/mongoose_c2s Jan 23, 2023
@NelsonVides NelsonVides deleted the c2s/fix-sm-timeouts branch January 23, 2023 17:12
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants