Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type issues discovered by the extended dialyzer checks #3957

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Feb 7, 2023

After merging feature/mongoose_c2s the new code was checked with the {warnings, [unknown]} option, and the check started failing.

The gen_hook:extra type should be used instead of gen_hook:hook_extra, because the handler function gets the extended extra.

After merging feature/mongoose_c2s the new code was checked with the
'{warnings, [unknown]}' option, and the check started failing.

The 'gen_hook:extra' should be used instead of 'gen_hook:hook_extra',
because the handler function gets the extended 'extra'.
@chrzaszcz chrzaszcz changed the title Fix types discovered by the extended dialyzer checks Fix types issues discovered by the extended dialyzer checks Feb 7, 2023
@chrzaszcz chrzaszcz changed the title Fix types issues discovered by the extended dialyzer checks Fix type issues discovered by the extended dialyzer checks Feb 7, 2023
@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 7, 2023

small_tests_24 / small_tests / c52baf3
Reports root / small


small_tests_25 / small_tests / c52baf3
Reports root / small


ldap_mnesia_24 / ldap_mnesia / c52baf3
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c52baf3
Reports root/ big
OK: 4169 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / c52baf3
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / c52baf3
Reports root/ big
OK: 4143 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c52baf3
Reports root/ big
OK: 4169 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / c52baf3
Reports root/ big
OK: 4549 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c52baf3
Reports root/ big
OK: 4166 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / c52baf3
Reports root/ big
OK: 2361 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c52baf3
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / c52baf3
Reports root/ big
OK: 4549 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / c52baf3
Reports root/ big
OK: 2559 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / c52baf3
Reports root/ big
OK: 4546 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / c52baf3
Reports root/ big
OK: 4535 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 83.52% // Head: 83.54% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (c52baf3) compared to base (06a1d21).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3957      +/-   ##
==========================================
+ Coverage   83.52%   83.54%   +0.02%     
==========================================
  Files         538      538              
  Lines       34003    34003              
==========================================
+ Hits        28402    28409       +7     
+ Misses       5601     5594       -7     
Impacted Files Coverage Δ
src/c2s/mongoose_c2s.erl 87.35% <ø> (ø)
src/c2s/mongoose_c2s_hooks.erl 95.45% <ø> (ø)
src/gen_hook.erl 86.90% <ø> (ø)
src/metrics/mongoose_metrics_hooks.erl 97.43% <ø> (ø)
src/mod_last.erl 88.00% <ø> (ø)
src/privacy/mod_blocking.erl 89.38% <ø> (ø)
src/sasl/cyrsasl.erl 90.90% <ø> (ø)
src/mongoose_cleaner.erl 60.00% <0.00%> (-10.00%) ⬇️
src/mam/mod_mam_muc_rdbms_arch_async.erl 82.85% <0.00%> (-2.86%) ⬇️
src/pubsub/node_pep.erl 77.77% <0.00%> (-1.86%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chrzaszcz chrzaszcz marked this pull request as ready for review February 7, 2023 10:53
Copy link
Collaborator

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DenysGonchar DenysGonchar merged commit 997ce8c into master Feb 7, 2023
@DenysGonchar DenysGonchar deleted the fix-c2s-types branch February 7, 2023 11:29
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants