-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type issues discovered by the extended dialyzer checks #3957
Conversation
After merging feature/mongoose_c2s the new code was checked with the '{warnings, [unknown]}' option, and the check started failing. The 'gen_hook:extra' should be used instead of 'gen_hook:hook_extra', because the handler function gets the extended 'extra'.
small_tests_24 / small_tests / c52baf3 small_tests_25 / small_tests / c52baf3 ldap_mnesia_24 / ldap_mnesia / c52baf3 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c52baf3 ldap_mnesia_25 / ldap_mnesia / c52baf3 dynamic_domains_mysql_redis_25 / mysql_redis / c52baf3 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c52baf3 pgsql_mnesia_24 / pgsql_mnesia / c52baf3 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c52baf3 internal_mnesia_25 / internal_mnesia / c52baf3 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c52baf3 pgsql_mnesia_25 / pgsql_mnesia / c52baf3 riak_mnesia_24 / riak_mnesia / c52baf3 mssql_mnesia_25 / odbc_mssql_mnesia / c52baf3 mysql_redis_25 / mysql_redis / c52baf3 |
Codecov ReportBase: 83.52% // Head: 83.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3957 +/- ##
==========================================
+ Coverage 83.52% 83.54% +0.02%
==========================================
Files 538 538
Lines 34003 34003
==========================================
+ Hits 28402 28409 +7
+ Misses 5601 5594 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonderful
After merging feature/mongoose_c2s the new code was checked with the
{warnings, [unknown]}
option, and the check started failing.The
gen_hook:extra
type should be used instead ofgen_hook:hook_extra
, because the handler function gets the extendedextra
.