Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C2s code cleanup #3959

Merged
merged 6 commits into from
Feb 9, 2023
Merged

C2s code cleanup #3959

merged 6 commits into from
Feb 9, 2023

Commits on Feb 9, 2023

  1. Remove unused helpers

    @chrzaszcz
    chrzaszcz committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    3aae6d4 View commit details
    Browse the repository at this point in the history

  2. Remove comment that is no longer relevant

    @chrzaszcz
    chrzaszcz committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    06f8dbe View commit details
    Browse the repository at this point in the history

  3. Update comments in race_conditions_SUITE 

    There is no check_incoming_accum_for_conflicts anymore,
and this test cannot reach that functionality, because it was extracted
to mod_stream_management.
    @chrzaszcz
    chrzaszcz committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    8970e4d View commit details
    Browse the repository at this point in the history

  4. Update comment in last_SUITE

    @chrzaszcz
    chrzaszcz committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    e0f398f View commit details
    Browse the repository at this point in the history

  5. Simplify presence handling in mod_global_distrib_SUITE 

    There was a function called 'wait_for_registration', that called
the non-existing old c2s module.

It was supposed to wait for the sm session, but actually the presence
is sent by the server after creating the session, not before as the
comment said.

Thus, it was enough to disable the filter predicate for Alice's
presences, and just handle them the same way as for other users.
    @chrzaszcz
    chrzaszcz committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    b7e6f3b View commit details
    Browse the repository at this point in the history

  6. Finish renaming Handler to ModState 

    It is module-specific state.
    @chrzaszcz
    chrzaszcz committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    cb60d77 View commit details
    Browse the repository at this point in the history