-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C2S docs #3962
C2S docs #3962
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 83.57% // Head: 83.53% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3962 +/- ##
==========================================
- Coverage 83.57% 83.53% -0.04%
==========================================
Files 538 538
Lines 34003 34003
==========================================
- Hits 28418 28405 -13
- Misses 5585 5598 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
7939b13
to
045d2ec
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Make it easier to find all hook definitions. Module names don't help, because we have e.g. mongoose_metrics_hooks, which contains handlers, not hooks.
small_tests_24 / small_tests / 6d2c774 small_tests_25 / small_tests / 6d2c774 ldap_mnesia_24 / ldap_mnesia / 6d2c774 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6d2c774 ldap_mnesia_25 / ldap_mnesia / 6d2c774 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6d2c774 dynamic_domains_mysql_redis_25 / mysql_redis / 6d2c774 pgsql_mnesia_24 / pgsql_mnesia / 6d2c774 internal_mnesia_25 / internal_mnesia / 6d2c774 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6d2c774 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6d2c774 riak_mnesia_24 / riak_mnesia / 6d2c774 mysql_redis_25 / mysql_redis / 6d2c774 rest_SUITE:admin:session_can_be_kicked{error,{test_case_failed,[70,97,105,108,58,32,
[60,60,
"\"alice_session_can_be_kicked_2825@localhost/res1\"",
62,62],
32,105,110,32,
[91,
[[60,60,
"\"alice_messages_are_sent_and_received_2824@localhost/res1\"",
62,62],
44,10,
[32,32,
[32,
[32,[32," ",32,32,32],32," ",32,32,32],
32,
[32," ",32,32,32],
32," ",32,32,32],
32,
[32,[32," ",32,32,32],32," ",32,32,32],
32,
[32," ",32,32,32],
32," ",32,32,32],
[60,60,
"\"alice_stanzas_are_sent_and_received_2827@localhost/res1\"",
62,62],
44,10,
[32,32,
[32,
[32,[32," ",32,32,32],32," ",32,32,32],
32,
[32," ",32,32,32],
32," ",32,32,32],
32,
[32,[32," ",32,32,32],32," ",32,32,32],
32,
[32," ",32,32,32],
32," ",32,32,32],
[60,60,
"\"alice_session_can_be_kicked_2825@localhost/res1\"",
62,62],
44,10,
[32,32,
[32,
[32,[32," ",32,32,32],32," ",32,32,32],
32,
... mssql_mnesia_25 / odbc_mssql_mnesia / 6d2c774 pgsql_mnesia_25 / pgsql_mnesia / 6d2c774 |
small_tests_24 / small_tests / a9dc040 small_tests_25 / small_tests / a9dc040 ldap_mnesia_24 / ldap_mnesia / a9dc040 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a9dc040 ldap_mnesia_25 / ldap_mnesia / a9dc040 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / a9dc040 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / a9dc040 dynamic_domains_mysql_redis_25 / mysql_redis / a9dc040 pgsql_mnesia_24 / pgsql_mnesia / a9dc040 internal_mnesia_25 / internal_mnesia / a9dc040 mysql_redis_25 / mysql_redis / a9dc040 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / a9dc040 pubsub_SUITE:dag+basic:publish_only_retract_items_scope_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,491}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,481}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,471}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} riak_mnesia_24 / riak_mnesia / a9dc040 pgsql_mnesia_25 / pgsql_mnesia / a9dc040 mssql_mnesia_25 / odbc_mssql_mnesia / a9dc040 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, dunno if those are actually useful examples but just throwing in some thought. Otherwise, a wonderful PR 🎉
small_tests_24 / small_tests / 8716857 small_tests_25 / small_tests / 8716857 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8716857 ldap_mnesia_24 / ldap_mnesia / 8716857 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8716857 ldap_mnesia_25 / ldap_mnesia / 8716857 dynamic_domains_mysql_redis_25 / mysql_redis / 8716857 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8716857 pgsql_mnesia_24 / pgsql_mnesia / 8716857 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8716857 pgsql_mnesia_25 / pgsql_mnesia / 8716857 internal_mnesia_25 / internal_mnesia / 8716857 riak_mnesia_24 / riak_mnesia / 8716857 mysql_redis_25 / mysql_redis / 8716857 mssql_mnesia_25 / odbc_mssql_mnesia / 8716857 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Update documentation after introducing
mongose_c2s
.The migration guide will be updated in a separate PR.
Main changes:
plantuml
, so it was replaced with Google docs. The docs were looking bad in night mode, so a separate dark-mode version is used.src/hooks
to make them easier to find and automatically grep. Another reason was naming - we had confusing modules likemongoose_metric_hooks
, which contains handlers, not hooks. The rename is the simplest change, and I wanted to avoid code changes in this PR.