Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration guide for mongoose_c2s #3965

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Feb 17, 2023

The migration guide is self-explanatory: it describes how to switch from 6.0.0 to the latest version 6.1.0.

Metrics are updated in a separate task, and will be described separately, most likely by @DenysGonchar.

The rolling upgrade procedure is based on the load tests.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 82.00% // Head: 83.54% // Increases project coverage by +1.54% 🎉

Coverage data is based on head (c67d1e8) compared to base (d816175).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3965      +/-   ##
==========================================
+ Coverage   82.00%   83.54%   +1.54%     
==========================================
  Files         538      538              
  Lines       34003    34003              
==========================================
+ Hits        27883    28407     +524     
+ Misses       6120     5596     -524     
Impacted Files Coverage Δ
src/mongoose_tcp_listener.erl 74.46% <0.00%> (-4.26%) ⬇️
src/pubsub/node_pep.erl 77.77% <0.00%> (-1.86%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 72.05% <0.00%> (-1.48%) ⬇️
src/wpool/mongoose_wpool.erl 82.24% <0.00%> (-0.94%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 73.48% <0.00%> (+0.12%) ⬆️
src/rdbms/mongoose_rdbms.erl 67.01% <0.00%> (+0.70%) ⬆️
src/mam/mod_mam_utils.erl 89.96% <0.00%> (+0.91%) ⬆️
src/ejabberd.erl 50.00% <0.00%> (+5.00%) ⬆️
src/wpool/mongoose_wpool_riak.erl 100.00% <0.00%> (+12.50%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 22, 2023

small_tests_24 / small_tests / 7d09991
Reports root / small


small_tests_25 / small_tests / 7d09991
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 7d09991
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7d09991
Reports root/ big
OK: 4169 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 7d09991
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 7d09991
Reports root/ big
OK: 4169 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 7d09991
Reports root/ big
OK: 4143 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 7d09991
Reports root/ big
OK: 4166 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 7d09991
Reports root/ big
OK: 4548 / Failed: 0 / User-skipped: 97 / Auto-skipped: 1


internal_mnesia_25 / internal_mnesia / 7d09991
Reports root/ big
OK: 2361 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 7d09991
Reports root/ big
OK: 4535 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 7d09991
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 7d09991
Reports root/ big
OK: 4549 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 7d09991
Reports root/ big
OK: 2559 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 7d09991
Reports root/ big
OK: 4546 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

- Changed configuration: listeners and modules
- Hooks
- Upgrade procedure described after load-testing the rolling upgrade
  and finiding the extent of the warning-related issue.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 23, 2023

small_tests_24 / small_tests / c67d1e8
Reports root / small


small_tests_25 / small_tests / c67d1e8
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c67d1e8
Reports root/ big
OK: 4169 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / c67d1e8
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / c67d1e8
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / c67d1e8
Reports root/ big
OK: 4549 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c67d1e8
Reports root/ big
OK: 4166 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / c67d1e8
Reports root/ big
OK: 4143 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c67d1e8
Reports root/ big
OK: 4169 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c67d1e8
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / c67d1e8
Reports root/ big
OK: 2559 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / c67d1e8
Reports root/ big
OK: 2361 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / c67d1e8
Reports root/ big
OK: 4548 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

push_integration_SUITE:pubsub_less:pm_notifications_with_inbox:inbox_msg_reset_unread_count_fcm
{error,
  {{assertion_failed,assert_many,false,
     [is_presence,is_message,is_message],
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_inbox_msg_reset_unread_count_fcm_2983@localhost/res1">>},
         {<<"to">>,
        <<"bob_inbox_msg_reset_unread_count_fcm_2983@localhost">>},
         {<<"type">>,<<"chat">>},
         {<<"id">>,<<"28e865e1c3b613b103e936f2815e7683">>}],
        [{xmlel,<<"body">>,[],[{xmlcdata,<<"FIRST MESSAGE">>}]},
         {xmlel,<<"delay">>,
           [{<<"xmlns">>,<<"urn:xmpp:delay">>},
          {<<"stamp">>,<<"2023-02-23T13:37:24.864345Z">>},
          {<<"from">>,<<"localhost">>}],
           [{xmlcdata,<<"Offline Storage">>}]}]},
      {xmlel,<<"presence">>,
        [{<<"from">>,
        <<"bob_inbox_msg_reset_unread_count_fcm_2983@localhost/res1">>},
         {<<"to">>,
        <<"bob_inbox_msg_reset_unread_count_fcm_2983@localhost/res1">>}],
        []}],
     "   <message from='alice_inbox_msg_reset_unread_count_fcm_2983@localhost/res1' to='bob_inbox_msg_reset_unread_count_fcm_2983@localhost' type='chat' id='28e865e1c3b613b103e936f2815e7683'><body>FIRST MESSAGE</body><delay xmlns='urn:xmpp:delay' stamp='2023-02-23T13:37:24.864345Z' from='localhost'>Offline Storage</delay></message>   <presence from='bob_inbox_msg_reset_unread_count_fcm_2983@localhost/res1' to='bob_inbox_msg_reset_unread_count_fcm_2983@localhost/res1'/>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_buil...

Report log


mssql_mnesia_25 / odbc_mssql_mnesia / c67d1e8
Reports root/ big
OK: 4546 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

muc_light_http_api_SUITE:end_per_suite
{error,
 {{unregistering_failed,
   {amount,2},
   {unregistered_items,
  [{{<<"_send_message_errors_2623">>,
     [{escalus_event_mgr,<0.21188.2>},
    {tc_name,send_message_errors},
    {escalus_cleaner,<0.21187.2>},
    {watchdog,<0.21186.2>},
    {mim_data_dir,
     "/home/circleci/project/big_tests/tests/muc_light_http_api_SUITE_data"},
    {preset,"odbc_mssql_mnesia"},
    {tc_logfile,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/3965/166906/odbc_mssql_mnesia.25.2/big/ct_run.test%40685aed4b4d42.2023-02-23_13.23.43/big_tests.tests.muc_light_http_api_SUITE.logs/run.2023-02-23_13.37.15/muc_light_http_api_suite.send_message_errors.40197.html"},
    {tc_group_properties,[{name,negative},parallel]},
    {tc_group_path,[]},
    {data_dir,
     "/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/muc_light_http_api_SUITE_data/"},
    {priv_dir,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/3965/166906/odbc_mssql_mnesia.25.2/big/ct_run.test%40685aed4b4d42.2023-02-23_13.23.43/big_tests.tests.muc_light_http_api_SUITE.logs/run.2023-02-23_13.37.15/log_private/"},
    {{saved_modules,mongooseim@localhost,<<"localhost">>},
     #{mod_adhoc => #{iqdisc => one_queue,report_commands_node => false},
       mod_amp => #{},
       mod_bosh =>
      #{backend => mnesia,inactivity => 30,max_pause => 120,
        max_wait => infinity,server_acks => false},
       mod_cache_users =>
      #{number_of_segments => 5,strategy => fifo,time_to_live => 2},
       mod_carboncopy => #{iqdisc => no_queue},
       mod_disco =>
      #{extra_domains => [],iqd...

Report log


mysql_redis_25 / mysql_redis / c67d1e8
Reports root/ big
OK: 4535 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / c67d1e8
Reports root/ big
OK: 4549 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@chrzaszcz chrzaszcz marked this pull request as ready for review February 23, 2023 14:38
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. I was building locally just to double check all links and layouts are correct, it all seems cool. Thanks for this work! 😄

@NelsonVides NelsonVides merged commit f8d16bb into master Feb 24, 2023
@NelsonVides NelsonVides deleted the c2s-migration-guide branch February 24, 2023 14:13
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants