Fix announcing session establishment feature #3970
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 83.54% // Head: 83.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3970 +/- ##
==========================================
+ Coverage 83.54% 83.56% +0.01%
==========================================
Files 538 538
Lines 34007 34009 +2
==========================================
+ Hits 28412 28419 +7
+ Misses 5595 5590 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
An XMPP client won't try the old session establishment step if it doesn't see it announced in the server features, even when the server is strictly waiting for it, so this would deadlock all connections.
NelsonVides
force-pushed
the
c2s/fix_compatible_session
branch
from
44ba059
to
62a6af8
Compare
|
small_tests_24 / small_tests / 62a6af8 small_tests_25 / small_tests / 62a6af8 ldap_mnesia_24 / ldap_mnesia / 62a6af8 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 62a6af8 pgsql_mnesia_24 / pgsql_mnesia / 62a6af8 dynamic_domains_mysql_redis_25 / mysql_redis / 62a6af8 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 62a6af8 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 62a6af8 ldap_mnesia_25 / ldap_mnesia / 62a6af8 graphql_server_SUITE:admin_http:clustering_http_tests:remove_node_test{error,{{badmatch,{error,econnrefused}},
[{rest_helper,fusco_request,7,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,185}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,114}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,121}]},
{graphql_server_SUITE,remove_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,210}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}graphql_server_SUITE:admin_http:clustering_http_tests:stop_node_test{error,{{badmatch,{error,econnrefused}},
[{rest_helper,fusco_request,7,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,185}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,114}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,121}]},
{graphql_server_SUITE,stop_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,215}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}internal_mnesia_25 / internal_mnesia / 62a6af8 riak_mnesia_24 / riak_mnesia / 62a6af8 pubsub_SUITE:dag+basic:subscribe_options_separate_request_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,491}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,481}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,471}]},
{pubsub_SUITE,'-subscribe_options_separate_request_test/1-fun-2-',2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,492}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 62a6af8 pgsql_mnesia_25 / pgsql_mnesia / 62a6af8 mysql_redis_25 / mysql_redis / 62a6af8 mssql_mnesia_25 / odbc_mssql_mnesia / 62a6af8 ldap_mnesia_25 / ldap_mnesia / 62a6af8 |
An XMPP client won't try the old session establishment step if it doesn't see it announced in the server features, even when the server is strictly waiting for it, so this would deadlock all connections.