Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding function checking the "to" jid #3971

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Adding function checking the "to" jid #3971

merged 3 commits into from
Feb 28, 2023

Conversation

JanuszJakubiec
Copy link
Contributor

Adding the check to ensure correctness of "to" jid.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 23, 2023 •
edited
Loading

small_tests_24 / small_tests / d719b9d
Reports root / small

small_tests_25 / small_tests / d719b9d
Reports root / small

ldap_mnesia_24 / ldap_mnesia / d719b9d
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d719b9d
Reports root/ big
OK: 4169 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / d719b9d
Reports root/ big
OK: 4142 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

mim_c2s_SUITE:basic:message_sent_to_malformed_jid_results_in_error 
{error,
  {thrown,
    {{timeout,stream_end},
     [{escalus_connection,get_stream_end,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,370}]},
      {escalus_connection,end_stream,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,508}]},
      {escalus_connection,stop,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,408}]},
      {escalus_client,stop,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
         {line,76}]},
      {lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
      {escalus_story,story,4,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
         {line,76}]},
      {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
      {test_server,run_test_case_eval1,6,
        [{file,"test_server.erl"},{line,1291}]}]}}}

Report log

ldap_mnesia_25 / ldap_mnesia / d719b9d
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d719b9d
Reports root/ big
OK: 4166 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / d719b9d
Reports root/ big
OK: 4548 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

mim_c2s_SUITE:basic:message_sent_to_malformed_jid_results_in_error 
{error,{thrown,{timeout,stream_end}}}

Report log

internal_mnesia_25 / internal_mnesia / d719b9d
Reports root/ big
OK: 2361 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / d719b9d
Reports root/ big
OK: 2720 / Failed: 1 / User-skipped: 662 / Auto-skipped: 0

mim_c2s_SUITE:basic:message_sent_to_malformed_jid_results_in_error 
{error,
  {thrown,
    {{timeout,stream_end},
     [{escalus_connection,get_stream_end,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,370}]},
      {escalus_connection,end_stream,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,508}]},
      {escalus_connection,stop,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,408}]},
      {escalus_client,stop,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
         {line,76}]},
      {lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
      {escalus_story,story,4,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
         {line,76}]},
      {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
      {test_server,run_test_case_eval1,6,
        [{file,"test_server.erl"},{line,1291}]}]}}}

Report log

mysql_redis_25 / mysql_redis / d719b9d
Reports root/ big
OK: 4534 / Failed: 1 / User-skipped: 111 / Auto-skipped: 0

mim_c2s_SUITE:basic:message_sent_to_malformed_jid_results_in_error 
{error,
  {thrown,
    {{timeout,stream_end},
     [{escalus_connection,get_stream_end,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,370}]},
      {escalus_connection,end_stream,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,508}]},
      {escalus_connection,stop,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,408}]},
      {escalus_client,stop,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
         {line,76}]},
      {lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
      {escalus_story,story,4,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
         {line,76}]},
      {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
      {test_server,run_test_case_eval1,6,
        [{file,"test_server.erl"},{line,1291}]}]}}}

Report log

riak_mnesia_24 / riak_mnesia / d719b9d
Reports root/ big
OK: 2559 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / d719b9d
Reports root/ big
OK: 4549 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / d719b9d
Reports root/ big
OK: 4546 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Feb 23, 2023 •
edited
Loading

Codecov Report

Base: 83.56% // Head: 83.56% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b7b20ca) compared to base (b9ca80e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3971   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files         538      538           
  Lines       34007    34016    +9     
=======================================
+ Hits        28417    28427   +10     
+ Misses       5590     5589    -1
Impacted Files Coverage Δ
src/c2s/mongoose_c2s.erl 87.69% <100.00%> (+0.24%) ⬆️
src/mam/mod_mam_muc_rdbms_arch_async.erl 82.85% <0.00%> (-2.86%) ⬇️
src/pubsub/node_pep.erl 77.77% <0.00%> (-1.86%) ⬇️
src/rdbms/mongoose_rdbms.erl 65.26% <0.00%> (-1.76%) ⬇️
src/mod_roster.erl 78.57% <0.00%> (-0.72%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/mongoose_xmpp_errors.erl 43.43% <0.00%> (+1.01%) ⬆️
src/domain/service_domain_db.erl 85.41% <0.00%> (+2.08%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 68.88% <0.00%> (+2.22%) ⬆️
src/cassandra/mongoose_cassandra_worker.erl 69.15% <0.00%> (+2.80%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 23, 2023 •
edited
Loading

small_tests_24 / small_tests / b96d539
Reports root / small

small_tests_25 / small_tests / b96d539
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b96d539
Reports root/ big
OK: 4174 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / b96d539
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b96d539
Reports root/ big
OK: 4174 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / b96d539
Reports root/ big
OK: 4146 / Failed: 2 / User-skipped: 114 / Auto-skipped: 0

mim_c2s_SUITE:basic:message_sent_to_malformed_jid_results_in_error 
{error,
  {thrown,
    {{timeout,stream_end},
     [{escalus_connection,get_stream_end,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,370}]},
      {escalus_connection,end_stream,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,508}]},
      {escalus_connection,stop,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,408}]},
      {escalus_client,stop,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
         {line,76}]},
      {lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
      {escalus_story,story,4,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
         {line,76}]},
      {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
      {test_server,run_test_case_eval1,6,
        [{file,"test_server.erl"},{line,1291}]}]}}}

Report log

mam_SUITE:rdbms_mnesia_muc_light:muc_light_chat_markers_are_not_archived_if_disabled 
{error,{test_case_failed,"Respond size is 2, 1 is expected."}}

Report log

ldap_mnesia_25 / ldap_mnesia / b96d539
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / b96d539
Reports root/ big
OK: 2365 / Failed: 1 / User-skipped: 683 / Auto-skipped: 0

mim_c2s_SUITE:basic:message_sent_to_malformed_jid_results_in_error 
{error,
  {thrown,
    {{timeout,stream_end},
     [{escalus_connection,get_stream_end,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,370}]},
      {escalus_connection,end_stream,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,508}]},
      {escalus_connection,stop,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,408}]},
      {escalus_client,stop,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
         {line,76}]},
      {lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
      {escalus_story,story,4,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
         {line,76}]},
      {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
      {test_server,run_test_case_eval1,6,
        [{file,"test_server.erl"},{line,1291}]}]}}}

Report log

pgsql_mnesia_24 / pgsql_mnesia / b96d539
Reports root/ big
OK: 4554 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b96d539
Reports root/ big
OK: 4171 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b96d539
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / b96d539
Reports root/ big
OK: 4554 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / b96d539
Reports root/ big
OK: 2564 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / b96d539
Reports root/ big
OK: 4555 / Failed: 2 / User-skipped: 111 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive 
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

vcard_SUITE:ro_full:retrieve_own_card 
{error,{test_case_failed,"Expected <<\"alice\">> got undefined\n"}}

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / b96d539
Reports root/ big
OK: 4549 / Failed: 2 / User-skipped: 100 / Auto-skipped: 0

mim_c2s_SUITE:basic:message_sent_to_malformed_jid_results_in_error 
{error,
  {thrown,
    {{timeout,stream_end},
     [{escalus_connection,get_stream_end,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,370}]},
      {escalus_connection,end_stream,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,508}]},
      {escalus_connection,stop,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,408}]},
      {escalus_client,stop,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
         {line,76}]},
      {lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
      {escalus_story,story,4,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
         {line,76}]},
      {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
      {test_server,run_test_case_eval1,6,
        [{file,"test_server.erl"},{line,1291}]}]}}}

Report log

pep_SUITE:pep_tests:publish_and_notify_test 
{error,{{assertion_failed,assert_many,false,[is_presence],[],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,109}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log

@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 23, 2023 •
edited
Loading

small_tests_24 / small_tests / 7294ef9
Reports root / small

small_tests_25 / small_tests / 7294ef9
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 7294ef9
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7294ef9
Reports root/ big
OK: 4174 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 7294ef9
Reports root/ big
OK: 4147 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

mim_c2s_SUITE:basic:message_sent_to_malformed_jid_results_in_error 
{error,
  {thrown,
    {{timeout,stream_end},
     [{escalus_connection,get_stream_end,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,370}]},
      {escalus_connection,end_stream,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,508}]},
      {escalus_connection,stop,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,408}]},
      {escalus_client,stop,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
         {line,76}]},
      {lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
      {escalus_story,story,4,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
         {line,76}]},
      {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
      {test_server,run_test_case_eval1,6,
        [{file,"test_server.erl"},{line,1291}]}]}}}

Report log

ldap_mnesia_25 / ldap_mnesia / 7294ef9
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 7294ef9
Reports root/ big
OK: 4554 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 7294ef9
Reports root/ big
OK: 4174 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 7294ef9
Reports root/ big
OK: 2366 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 7294ef9
Reports root/ big
OK: 4171 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 7294ef9
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 7294ef9
Reports root/ big
OK: 2563 / Failed: 1 / User-skipped: 654 / Auto-skipped: 0

mim_c2s_SUITE:basic:message_sent_to_malformed_jid_results_in_error 
{error,{thrown,{timeout,stream_end}}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 7294ef9
Reports root/ big
OK: 4553 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

mim_c2s_SUITE:basic:message_sent_to_malformed_jid_results_in_error 
{error,
  {thrown,
    {{timeout,stream_end},
     [{escalus_connection,get_stream_end,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,370}]},
      {escalus_connection,end_stream,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,508}]},
      {escalus_connection,stop,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,408}]},
      {escalus_client,stop,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
         {line,76}]},
      {lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
      {escalus_story,story,4,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
         {line,76}]},
      {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
      {test_server,run_test_case_eval1,6,
        [{file,"test_server.erl"},{line,1291}]}]}}}

Report log

mysql_redis_25 / mysql_redis / 7294ef9
Reports root/ big
OK: 4539 / Failed: 1 / User-skipped: 111 / Auto-skipped: 0

mim_c2s_SUITE:basic:message_sent_to_malformed_jid_results_in_error 
{error,
  {thrown,
    {{timeout,stream_end},
     [{escalus_connection,get_stream_end,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,370}]},
      {escalus_connection,end_stream,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,508}]},
      {escalus_connection,stop,1,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
         {line,408}]},
      {escalus_client,stop,2,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
         {line,76}]},
      {lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
      {escalus_story,story,4,
        [{file,
           "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
         {line,76}]},
      {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
      {test_server,run_test_case_eval1,6,
        [{file,"test_server.erl"},{line,1291}]}]}}}

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / 7294ef9
Reports root/ big
OK: 4551 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

@JanuszJakubiec JanuszJakubiec force-pushed the dont-crash-on-invalid-to-jid branch 2 times, most recently from 30e6bb8 to ee51d54 Compare February 24, 2023 08:09
@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 24, 2023 •
edited
Loading

small_tests_24 / small_tests / 30e6bb8
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 30e6bb8
Reports root/ big
OK: 4570 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 30e6bb8
Reports root/ big
OK: 2620 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 30e6bb8
Reports root/ big
OK: 2960 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 30e6bb8
Reports root/ big
OK: 4949 / Failed: 0 / User-skipped: 97 / Auto-skipped: 1

@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 24, 2023 •
edited
Loading

small_tests_24 / small_tests / ee51d54
Reports root / small

small_tests_25 / small_tests / ee51d54
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ee51d54
Reports root/ big
OK: 4174 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / ee51d54
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / ee51d54
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ee51d54
Reports root/ big
OK: 4174 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / ee51d54
Reports root/ big
OK: 4148 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ee51d54
Reports root/ big
OK: 4171 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / ee51d54
Reports root/ big
OK: 4554 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / ee51d54
Reports root/ big
OK: 2366 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / ee51d54
Reports root/ big
OK: 2564 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / ee51d54
Reports root/ big
OK: 4554 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ee51d54
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / ee51d54
Reports root/ big
OK: 4551 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / ee51d54
Reports root/ big
OK: 4540 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

@JanuszJakubiec JanuszJakubiec marked this pull request as ready for review February 24, 2023 08:39
chrzaszcz
chrzaszcz reviewed Feb 24, 2023
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments.

big_tests/tests/mim_c2s_SUITE.erl Outdated Show resolved Hide resolved
src/c2s/mongoose_c2s.erl Outdated Show resolved Hide resolved
@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 24, 2023 •
edited
Loading

small_tests_24 / small_tests / 03f6a86
Reports root / small

small_tests_25 / small_tests / 03f6a86
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 03f6a86
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 03f6a86
Reports root/ big
OK: 4174 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 03f6a86
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 03f6a86
Reports root/ big
OK: 4174 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 03f6a86
Reports root/ big
OK: 4554 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 03f6a86
Reports root/ big
OK: 4147 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive 
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 03f6a86
Reports root/ big
OK: 4171 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 03f6a86
Reports root/ big
OK: 2365 / Failed: 1 / User-skipped: 683 / Auto-skipped: 0

muc_http_api_SUITE:negative:kick_user_errors 
{error,{{timeout,ok,[{times,50,not_yet}]},
    [{mongoose_helper,do_wait_until,2,
              [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
               {line,371}]},
     {muc_http_api_SUITE,kick_user_errors,1,
               [{file,"/home/circleci/project/big_tests/tests/muc_http_api_SUITE.erl"},
                {line,325}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 03f6a86
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 03f6a86
Reports root/ big
OK: 2564 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 03f6a86
Reports root/ big
OK: 4551 / Failed: 2 / User-skipped: 111 / Auto-skipped: 4

graphql_domain_SUITE:domain_http:get_domains_after_deletion 
{error,{{assertEqual,[{module,graphql_domain_SUITE},
            {line,209},
            {expression,"ParsedResult"},
            {expected,[]},
            {value,[<<"second.example.com">>]}]},
    [{graphql_domain_SUITE,get_domains_after_deletion,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_domain_SUITE.erl"},
                {line,209}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

vcard_SUITE:ro_full:retrieve_own_card 
{error,{test_case_failed,"Expected <<\"alice\">> got undefined\n"}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 03f6a86
Reports root/ big
OK: 4554 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 03f6a86
Reports root/ big
OK: 4551 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 03f6a86
Reports root/ big
OK: 4148 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 03f6a86
Reports root/ big
OK: 2366 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 03f6a86
Reports root/ big
OK: 4539 / Failed: 1 / User-skipped: 111 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive 
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

chrzaszcz
chrzaszcz reviewed Feb 24, 2023
View reviewed changes
src/c2s/mongoose_c2s.erl Outdated Show resolved Hide resolved
@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 27, 2023 •
edited
Loading

small_tests_24 / small_tests / b7b20ca
Reports root / small

small_tests_25 / small_tests / b7b20ca
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b7b20ca
Reports root/ big
OK: 4174 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / b7b20ca
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / b7b20ca
Reports root/ big
OK: 2224 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b7b20ca
Reports root/ big
OK: 4174 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / b7b20ca
Reports root/ big
OK: 4554 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b7b20ca
Reports root/ big
OK: 4171 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / b7b20ca
Reports root/ big
OK: 4147 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

xep_0352_csi_SUITE:basic:alice_gets_buffered_messages_after_reconnection_with_sm 
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"Hi, Alice: 1">>],
     {xmlel,<<"message">>,
       [{<<"from">>,
         <<"bob_alice_gets_buffered_messages_after_reconnection_with_sm_2672@domain.example.com/escalus-default-resource">>},
        {<<"to">>,
         <<"alice_alice_gets_buffered_messages_after_reconnection_with_sm_2672@domain.example.com">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"Hi, Alice: 5">>}]}]},
     "<message from='bob_alice_gets_buffered_messages_after_reconnection_with_sm_2672@domain.example.com/escalus-default-resource' to='alice_alice_gets_buffered_messages_after_reconnection_with_sm_2672@domain.example.com' type='chat'><body>Hi, Alice: 5</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {xep_0352_csi_SUITE,'-then_client_receives_message/2-lc$^0/1-0-',2,
      [{file,
         "/home/circleci/project/big_tests/tests/xep_0352_csi_SUITE.erl"},
       {line,212}]},
    {xep_0352_csi_SUITE,
      alice_gets_buffered_messages_after_reconnection_with_sm,1,
      [{file,
         "/home/circleci/project/big_tests/tests/xep_0352_csi_SUITE.erl"},
       {line,126}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
     ...

Report log

riak_mnesia_24 / riak_mnesia / b7b20ca
Reports root/ big
OK: 2564 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / b7b20ca
Reports root/ big
OK: 2366 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b7b20ca
Reports root/ big
OK: 2726 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / b7b20ca
Reports root/ big
OK: 4554 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / b7b20ca
Reports root/ big
OK: 4540 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / b7b20ca
Reports root/ big
OK: 4551 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / b7b20ca
Reports root/ big
OK: 4148 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

chrzaszcz
chrzaszcz approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@chrzaszcz chrzaszcz merged commit 4aeab91 into master Feb 28, 2023
@chrzaszcz chrzaszcz deleted the dont-crash-on-invalid-to-jid branch February 28, 2023 08:58
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JanuszJakubiec @mongoose-im @chrzaszcz @jacekwegr