Fix minor c2s issues #3972
Fix minor c2s issues #3972
Conversation
NelsonVides
force-pushed
the
c2s/quickfixes
branch
from
bb13439
to
d4a16dd
Compare
Even if this doesn't seem correct from the RFC perspective, I have seen client code sending such presence.
NelsonVides
force-pushed
the
c2s/quickfixes
branch
from
d4a16dd
to
b048025
Compare
NelsonVides
force-pushed
the
c2s/quickfixes
branch
from
b048025
to
46f1e23
Compare
|
small_tests_24 / small_tests / 46f1e23 small_tests_25 / small_tests / 46f1e23 ldap_mnesia_24 / ldap_mnesia / 46f1e23 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 46f1e23 ldap_mnesia_25 / ldap_mnesia / 46f1e23 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 46f1e23 dynamic_domains_mysql_redis_25 / mysql_redis / 46f1e23 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 46f1e23 internal_mnesia_25 / internal_mnesia / 46f1e23 riak_mnesia_24 / riak_mnesia / 46f1e23 pubsub_SUITE:tree+basic:subscribe_options_separate_request_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,491}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,481}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,471}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 46f1e23 pgsql_mnesia_25 / pgsql_mnesia / 46f1e23 mysql_redis_25 / mysql_redis / 46f1e23 mssql_mnesia_25 / odbc_mssql_mnesia / 46f1e23 pgsql_mnesia_24 / pgsql_mnesia / 46f1e23 graphql_roster_SUITE:admin_roster_http:admin_decline_subscription_ask{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bob_admin_decline_subscription_ask_1294@localhost/res1">>,
escalus_tcp,<0.1741.1>,
[{event_manager,<0.1739.1>},
{server,<<"localhost">>},
{username,<<"bOb_admin_decline_subscription_ask_1294">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.1739.1>},
{server,<<"localhost">>},
{username,
<<"bOb_admin_decline_subscription_ask_1294">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_admin_decline_subscription_ask_1294">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_admin_decline_subscription_ask_1294">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"c267ea776d517b4f">>}]},
1],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{graphql_roster_SUITE,admin_decline_subscription_ask_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_roster_SUITE.erl"},
{line,255}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_b...pgsql_mnesia_24 / pgsql_mnesia / 46f1e23 |
Codecov ReportBase: 83.56% // Head: 83.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3972 +/- ##
==========================================
+ Coverage 83.56% 83.60% +0.03%
==========================================
Files 538 538
Lines 34007 34007
==========================================
+ Hits 28419 28431 +12
+ Misses 5588 5576 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Accept presence of type 'available', even if this doesn't seem correct from the RFC perspective, I have seen client code sending such presence.
Also fix the key c2s_state->c2s_data in the logger filters.