Deprecating riak #3981
Deprecating riak #3981
Conversation
|
small_tests_24 / small_tests / ee620df small_tests_25 / small_tests / ee620df ldap_mnesia_24 / ldap_mnesia / ee620df dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ee620df dynamic_domains_mysql_redis_25 / mysql_redis / ee620df ldap_mnesia_25 / ldap_mnesia / ee620df dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ee620df pgsql_mnesia_24 / pgsql_mnesia / ee620df internal_mnesia_25 / internal_mnesia / ee620df elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ee620df dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ee620df pgsql_mnesia_25 / pgsql_mnesia / ee620df mysql_redis_25 / mysql_redis / ee620df mssql_mnesia_25 / odbc_mssql_mnesia / ee620df |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3981 +/- ##
==========================================
- Coverage 83.57% 82.01% -1.56%
==========================================
Files 538 538
Lines 33975 33975
==========================================
- Hits 28394 27865 -529
- Misses 5581 6110 +529 see 18 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
small_tests_24 / small_tests / 848b062 small_tests_25 / small_tests / 848b062 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 848b062 ldap_mnesia_24 / ldap_mnesia / 848b062 dynamic_domains_mysql_redis_25 / mysql_redis / 848b062 metrics_c2s_SUITE:single:stanza_one{error,
{{xmppStanzaReceived,
{value,18320},
[{times,25,
{error,
{badmatch,{value,18321}},
[{metrics_helper,assert_counter,3,
[{file,
"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,36}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}pgsql_mnesia_24 / pgsql_mnesia / 848b062 ldap_mnesia_25 / ldap_mnesia / 848b062 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 848b062 internal_mnesia_25 / internal_mnesia / 848b062 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 848b062 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 848b062 pubsub_SUITE:dag+basic:subscribe_options_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,491}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,481}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,471}]},
{pubsub_SUITE,'-subscribe_options_test/1-fun-1-',3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,442}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}pgsql_mnesia_25 / pgsql_mnesia / 848b062 mssql_mnesia_25 / odbc_mssql_mnesia / 848b062 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mysql_redis_25 / mysql_redis / 848b062 |
JanuszJakubiec
force-pushed
the
riak_deprecation
branch
from
848b062
to
723c7fc
Compare
|
small_tests_24 / small_tests / 723c7fc small_tests_25 / small_tests / 723c7fc dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 723c7fc ldap_mnesia_24 / ldap_mnesia / 723c7fc pubsub_SUITE:tree+basic:subscribe_options_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,491}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,481}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,471}]},
{pubsub_SUITE,'-subscribe_options_test/1-fun-1-',3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,442}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}ldap_mnesia_25 / ldap_mnesia / 723c7fc dynamic_domains_mysql_redis_25 / mysql_redis / 723c7fc dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 723c7fc dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 723c7fc pgsql_mnesia_24 / pgsql_mnesia / 723c7fc internal_mnesia_25 / internal_mnesia / 723c7fc elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 723c7fc pgsql_mnesia_25 / pgsql_mnesia / 723c7fc mssql_mnesia_25 / odbc_mssql_mnesia / 723c7fc pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,{{assertion_failed,assert_many,false,[is_roster_set],[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-make_all_clients_friends/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,108}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{escalus_utils,distinct_pairs,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,60}]},
{escalus_story,make_all_clients_friends,1,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,106}]}]}}mysql_redis_25 / mysql_redis / 723c7fc mssql_mnesia_25 / odbc_mssql_mnesia / 723c7fc |
| @@ -156,9 +156,12 @@ Drawbacks are: | |||
| ### Medium | |||
|
|
|||
| * Add optional per-room processes to avoid the need of DB transactions and ensure message ordering (maybe "hard"?). | |||
| * Riak backend | |||
| * Riak(deprecated) backend | |||
There was a problem hiding this comment.
| * Riak(deprecated) backend | |
| * Riak (deprecated) backend |
doc/configuration/auth.md
Outdated
| @@ -7,7 +7,9 @@ The following methods are supported: | |||
| * [`anonymous`](../authentication-methods/anonymous.md) - allows anonymous connections, | |||
| * [`ldap`](../authentication-methods/ldap.md) - checks the user credentials in LDAP, | |||
| * [`jwt`](../authentication-methods/jwt.md) - authenticates the users with JSON Web Tokens, | |||
| * [`riak`](../authentication-methods/riak.md) - stores the user accounts in a Riak database, | |||
| * [`riak (deprecated)`](../authentication-methods/riak.md) - stores the user accounts in a Riak database, | |||
| !!! warning | |||
There was a problem hiding this comment.
I wouldn't break a list in two - I would move it below the list.
doc/configuration/auth.md
Outdated
| @@ -85,7 +90,7 @@ This option allows you to list the enabled ones in the order of preference (they | |||
|
|
|||
| ## Password-related options | |||
|
|
|||
| These options are common to the `http`, `rdbms`, `internal` and `riak` methods. | |||
| These options are common to the `http`, `rdbms`, `internal` and `riak(deprecated)` methods. | |||
There was a problem hiding this comment.
| These options are common to the `http`, `rdbms`, `internal` and `riak(deprecated)` methods. | |
| These options are common to the `http`, `rdbms`, `internal` and `riak` (deprecated) methods. |
doc/configuration/auth.md
Outdated
| @@ -156,5 +161,5 @@ See the links below for options related to the particular methods: | |||
| * [External method options](../authentication-methods/external.md#configuration-options) | |||
| * [LDAP method options](../authentication-methods/ldap.md#configuration-options) | |||
| * [JWT method options](../authentication-methods/jwt.md#configuration-options) | |||
| * [Riak method options](../authentication-methods/riak.md#configuration-options) | |||
| * [Riak(deprecated) method options](../authentication-methods/riak.md#configuration-options) | |||
There was a problem hiding this comment.
| * [Riak(deprecated) method options](../authentication-methods/riak.md#configuration-options) | |
| * [Riak (deprecated) method options](../authentication-methods/riak.md#configuration-options) |
| @@ -29,7 +29,7 @@ | |||
| * Redis | |||
| * Persistent: | |||
| * RDBMS: MySQL, PostgreSQL, generic ODBC | |||
| * NoSQL: Riak KV, Cassandra | |||
| * NoSQL: Riak KV(deprecated), Cassandra | |||
There was a problem hiding this comment.
| * NoSQL: Riak KV(deprecated), Cassandra | |
| * NoSQL: Riak KV (deprecated), Cassandra |
| @@ -38,10 +38,13 @@ There is no need to set up any backups for transient data since it naturally reb | |||
|
|
|||
| #### Persistent databases | |||
|
|
|||
| Both RDBMS/SQL (MySQL/PostgreSQL) and NoSQL (Riak KV) databases are supported. | |||
| Both RDBMS/SQL (MySQL/PostgreSQL) and NoSQL (Riak KV (deprecated)) databases are supported. | |||
There was a problem hiding this comment.
For clarity I would remove this (deprecated) comment and add Cassandra here.
doc/user-guide/Features.md
Outdated
| @@ -36,7 +36,7 @@ This modular architecture allows high customisability and easy access to the req | |||
|
|
|||
| MongooseIM enables authenticating users using external or internal [databases](../authentication-methods/rdbms.md) (Mnesia, RDBMS, NoSQL), [LDAP](../authentication-methods/ldap.md), [HTTP](../authentication-methods/http.md) or [external scripts](../authentication-methods/external.md). It also allows connecting [anonymous users](../authentication-methods/anonymous.md), when required. | |||
|
|
|||
| For storing persistent data, MongooseIM uses Mnesia (the distributed internal Erlang database), relational databases: MySQL, PostgreSQL or a NoSQL alternative: Riak KV. | |||
| For storing persistent data, MongooseIM uses Mnesia (the distributed internal Erlang database), relational databases: MySQL, PostgreSQL or a NoSQL alternative: Riak KV (deprecated). | |||
There was a problem hiding this comment.
| For storing persistent data, MongooseIM uses Mnesia (the distributed internal Erlang database), relational databases: MySQL, PostgreSQL or a NoSQL alternative: Riak KV (deprecated). | |
| For storing persistent data, MongooseIM uses Mnesia (the distributed internal Erlang database), relational databases: MySQL, PostgreSQL or NoSQL alternatives: Riak KV (deprecated) and Cassandra. |
JanuszJakubiec
force-pushed
the
riak_deprecation
branch
from
2ee39c1
to
8ef6826
Compare
|
small_tests_24 / small_tests / 2ee39c1 small_tests_25 / small_tests / 2ee39c1 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 2ee39c1 ldap_mnesia_24 / ldap_mnesia / 2ee39c1 metrics_c2s_SUITE:single:presence_direct_one{error,
{{xmppPresenceReceived,
{value,99},
[{times,25,
{error,
{badmatch,{value,100}},
[{metrics_helper,assert_counter,3,
[{file,
"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,36}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{metrics_c2s_SUITE,'-presence_direct_one/1-fun-0-',2,
[{file,
"/home/circleci/project/big_tests/tests/metrics_c2s_SUITE.erl"},
{line,143}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{metrics_c2s_SUITE,'-presence_direct_one/1-fun-0-',2,
[{file,
"/home/circleci/project/big_tests/tests/metrics_c2s_SUITE.erl"},
{line,143}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_...ldap_mnesia_25 / ldap_mnesia / 2ee39c1 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2ee39c1 pgsql_mnesia_24 / pgsql_mnesia / 2ee39c1 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 2ee39c1 rest_client_SUITE:roster:add_contact_and_invite{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.23818.2>,
[{event_manager,<0.23782.2>},
{server,<<"domain.example.com">>},
{username,<<"alicE_add_contact_and_invite_2673">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.23782.2>},
{server,<<"domain.example.com">>},
{username,<<"alicE_add_contact_and_invite_2673">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_add_contact_and_invite_2673">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_add_contact_and_invite_2673">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"7b6f7ffa4900e04e">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{rest_client_SUITE,'-add_contact_and_invite/1-fun-0-',2,
[{file,
"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,1188}]},
{escalus_story,story,4,
[{file,
"/...internal_mnesia_25 / internal_mnesia / 2ee39c1 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 2ee39c1 pgsql_mnesia_25 / pgsql_mnesia / 2ee39c1 mysql_redis_25 / mysql_redis / 2ee39c1 dynamic_domains_mysql_redis_25 / mysql_redis / 2ee39c1 mssql_mnesia_25 / odbc_mssql_mnesia / 2ee39c1 |
|
small_tests_24 / small_tests / 8ef6826 small_tests_25 / small_tests / 8ef6826 ldap_mnesia_24 / ldap_mnesia / 8ef6826 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8ef6826 ldap_mnesia_25 / ldap_mnesia / 8ef6826 dynamic_domains_mysql_redis_25 / mysql_redis / 8ef6826 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8ef6826 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8ef6826 internal_mnesia_25 / internal_mnesia / 8ef6826 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8ef6826 pgsql_mnesia_24 / pgsql_mnesia / 8ef6826 pgsql_mnesia_25 / pgsql_mnesia / 8ef6826 mysql_redis_25 / mysql_redis / 8ef6826 mssql_mnesia_25 / odbc_mssql_mnesia / 8ef6826 |
Deleting presets requiring Riak from CricleCI.
Marking Riak as deprecated in the docs.