Reworking mongoose transport #3982

DenysGonchar · 2023-03-08T22:15:16Z

This PR includes the following changes:

removal of WebSocket connection support for XMPP components (non-standard and not described behaviour)
removal of obsolete socket_type/0 callback from the mongoose_listener behaviour
replacement of ejabberd_socket and ejabberd_receiver modules with mongoose_transport implementation
introduction of spiral metrics for s2s and component connections
code clean-up of the related modules
documentation of the recently introduced metrics

mongoose-im · 2023-03-08T22:23:57Z

small_tests_24 / small_tests / 9812e88
Reports root / small

small_tests_25 / small_tests / 9812e88
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 9812e88
Reports root/ big
OK: 2215 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 9812e88
Reports root/ big
OK: 4173 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 9812e88
Reports root/ big
OK: 2215 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 9812e88
Reports root/ big
OK: 4146 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

rest_SUITE:admin:session_can_be_kicked

{error,{test_case_failed,[70,97,105,108,58,32,
              [60,60,
               "\"[email protected]/res1\"",
               62,62],
              32,105,110,32,
              [91,
               [[60,60,
               "\"[email protected]/res1\"",
               62,62],
              44,10,
              [32,
               [[[32,["  ",32,32],"  ",32,32],
                 32,
                 ["  ",32,32],
                 "  ",32,32],
                [32,["  ",32,32],"  ",32,32],
                32,
                ["  ",32,32],
                "  ",32,32],
               [[32,["  ",32,32],"  ",32,32],
                32,
                ["  ",32,32],
                "  ",32,32],
               [32,["  ",32,32],"  ",32,32],
               32,
               ["  ",32,32],
               "  ",32,32],
              [60,60,"\"[email protected]/res1\"",62,62],
              44,10,
              [32,
               [[[32,["  ",32,32],"  ",32,32],
                 32,
                 ["  ",32,32],
                 "  ",32,32],
                [32,["  ",32,32],"  ",32,32],
                32,
                ["  ",32,32],
                "  ",32,32],
               [[32,["  ",32,32],"  ",32,32],
                32,
                ["  ",32,32],
                "  ",32,32],
               [32,["  ",32,32],"  ",32,32],
               32,
               ["  ",32,32],
               "  ",32,32],
            ...

Report log

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 9812e88
Reports root/ big
OK: 4173 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 9812e88
Reports root/ big
OK: 4169 / Failed: 1 / User-skipped: 91 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive

{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

internal_mnesia_25 / internal_mnesia / 9812e88
Reports root/ big
OK: 2357 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 9812e88
Reports root/ big
OK: 4545 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 9812e88
Reports root/ big
OK: 2717 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 9812e88
Reports root/ big
OK: 4545 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 9812e88
Reports root/ big
OK: 2555 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 9812e88
Reports root/ big
OK: 4529 / Failed: 2 / User-skipped: 111 / Auto-skipped: 0

graphql_session_SUITE:admin_session:admin_session_cli:admin_kick_user_session

{error,
  {function_clause,
    [{graphql_helper,get_error,
       [1,
        {{<<"200">>,<<"OK">>},
         #{<<"data">> =>
           #{<<"session">> =>
               #{<<"kickUserSession">> =>
                 #{<<"code">> => null,
                   <<"jid">> =>
                     <<"alice_admin_kick_user_session_1219@localhost/res1">>,
                   <<"kicked">> => true,
                   <<"message">> => <<"Session kicked">>}}}}}],
       []},
     {graphql_helper,get_err_msg,2,
       [{file,
          "/home/circleci/project/big_tests/tests/graphql_helper.erl"},
        {line,227}]},
     {graphql_session_SUITE,admin_kick_user_session_story,3,
       [{file,
          "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
        {line,441}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

push_integration_SUITE:pubsub_less:pm_notifications_with_inbox:inbox_msg_reset_unread_count_apns

{error,
  {{assertion_failed,assert_many,false,
     [is_presence,is_message,is_message],
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_inbox_msg_reset_unread_count_apns_2842@localhost/res1">>},
         {<<"to">>,
        <<"bob_inbox_msg_reset_unread_count_apns_2842@localhost">>},
         {<<"type">>,<<"chat">>},
         {<<"id">>,<<"4c96ee9560d2b650cf4ce528b56f2e83">>}],
        [{xmlel,<<"body">>,[],[{xmlcdata,<<"FIRST MESSAGE">>}]},
         {xmlel,<<"delay">>,
           [{<<"xmlns">>,<<"urn:xmpp:delay">>},
          {<<"stamp">>,<<"2023-03-08T22:37:05.647115Z">>},
          {<<"from">>,<<"localhost">>}],
           [{xmlcdata,<<"Offline Storage">>}]}]},
      {xmlel,<<"presence">>,
        [{<<"from">>,
        <<"bob_inbox_msg_reset_unread_count_apns_2842@localhost/res1">>},
         {<<"to">>,
        <<"bob_inbox_msg_reset_unread_count_apns_2842@localhost/res1">>}],
        []}],
     "   <message from='alice_inbox_msg_reset_unread_count_apns_2842@localhost/res1' to='bob_inbox_msg_reset_unread_count_apns_2842@localhost' type='chat' id='4c96ee9560d2b650cf4ce528b56f2e83'><body>FIRST MESSAGE</body><delay xmlns='urn:xmpp:delay' stamp='2023-03-08T22:37:05.647115Z' from='localhost'>Offline Storage</delay></message>   <presence from='bob_inbox_msg_reset_unread_count_apns_2842@localhost/res1' to='bob_inbox_msg_reset_unread_count_apns_2842@localhost/res1'/>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tes...

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / 9812e88
Reports root/ big
OK: 4541 / Failed: 1 / User-skipped: 100 / Auto-skipped: 0

push_integration_SUITE:pubsub_less:pm_notifications_with_inbox:inbox_msg_reset_unread_count_apns

{error,
  {{assertion_failed,assert_many,false,
     [is_presence,is_message,is_message],
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_inbox_msg_reset_unread_count_apns_3693@localhost/res1">>},
         {<<"to">>,
        <<"bob_inbox_msg_reset_unread_count_apns_3693@localhost">>},
         {<<"type">>,<<"chat">>},
         {<<"id">>,<<"03cc88f4fb9dbf1e4f3289a22373f85c">>}],
        [{xmlel,<<"body">>,[],[{xmlcdata,<<"FIRST MESSAGE">>}]},
         {xmlel,<<"delay">>,
           [{<<"xmlns">>,<<"urn:xmpp:delay">>},
          {<<"stamp">>,<<"2023-03-08T22:40:50.023870Z">>},
          {<<"from">>,<<"localhost">>}],
           [{xmlcdata,<<"Offline Storage">>}]}]},
      {xmlel,<<"presence">>,
        [{<<"from">>,
        <<"bob_inbox_msg_reset_unread_count_apns_3693@localhost/res1">>},
         {<<"to">>,
        <<"bob_inbox_msg_reset_unread_count_apns_3693@localhost/res1">>}],
        []}],
     "   <message from='alice_inbox_msg_reset_unread_count_apns_3693@localhost/res1' to='bob_inbox_msg_reset_unread_count_apns_3693@localhost' type='chat' id='03cc88f4fb9dbf1e4f3289a22373f85c'><body>FIRST MESSAGE</body><delay xmlns='urn:xmpp:delay' stamp='2023-03-08T22:40:50.023870Z' from='localhost'>Offline Storage</delay></message>   <presence from='bob_inbox_msg_reset_unread_count_apns_3693@localhost/res1' to='bob_inbox_msg_reset_unread_count_apns_3693@localhost/res1'/>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tes...

Report log

codecov · 2023-03-08T22:26:14Z

Codecov Report

Patch coverage: 68.86% and project coverage change: +0.10 🎉

Comparison is base (c9e7309) 83.55% compared to head (65fce48) 83.65%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3982      +/-   ##
==========================================
+ Coverage   83.55%   83.65%   +0.10%     
==========================================
  Files         538      536       -2     
  Lines       33975    33896      -79     
==========================================
- Hits        28387    28356      -31     
+ Misses       5588     5540      -48

Impacted Files	Coverage Δ
src/c2s/mongoose_c2s_listener.erl	`91.17% <ø> (+2.60%)`	⬆️
src/ejabberd.erl	`55.00% <ø> (ø)`
src/ejabberd_cowboy.erl	`77.41% <ø> (+1.22%)`	⬆️
src/ejabberd_sup.erl	`85.71% <ø> (ø)`
src/mod_bosh_socket.erl	`78.32% <ø> (ø)`
src/mongoose_listener.erl	`70.00% <ø> (-2.73%)`	⬇️
src/ejabberd_s2s_out.erl	`61.42% <23.52%> (-1.86%)`	⬇️
src/ejabberd_service.erl	`67.10% <56.25%> (-0.43%)`	⬇️
src/mongoose_transport.erl	`73.61% <73.61%> (+56.95%)`	⬆️
src/ejabberd_s2s_in.erl	`79.03% <77.27%> (+0.98%)`	⬆️
... and 8 more

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mongoose-im · 2023-03-08T23:02:26Z

small_tests_24 / small_tests / 6ac2c48
Reports root / small

small_tests_25 / small_tests / 6ac2c48
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6ac2c48
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 6ac2c48
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 6ac2c48
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6ac2c48
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 6ac2c48
Reports root/ big
OK: 4152 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6ac2c48
Reports root/ big
OK: 4175 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

muc_light_http_api_SUITE:end_per_suite

{error,
 {{unregistering_failed,
   {amount,1},
   {unregistered_items,
  [{{<<"_send_message_to_room_2483">>,
     [{escalus_event_mgr,<0.16490.2>},
    {tc_name,send_message_to_room},
    {escalus_cleaner,<0.16489.2>},
    {watchdog,<0.16488.2>},
    {mim_data_dir,
     "/home/circleci/project/big_tests/tests/muc_light_http_api_SUITE_data"},
    {preset,"odbc_mssql_mnesia"},
    {tc_logfile,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/3982/168546/odbc_mssql_mnesia.25.2/big/ct_run.test%40894bc85cbaf2.2023-03-08_22.59.48/big_tests.tests.muc_light_http_api_SUITE.logs/run.2023-03-08_23.11.12/muc_light_http_api_suite.send_message_to_room.193410.html"},
    {tc_group_properties,[{name,positive},parallel]},
    {tc_group_path,[]},
    {data_dir,
     "/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/muc_light_http_api_SUITE_data/"},
    {priv_dir,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/3982/168546/odbc_mssql_mnesia.25.2/big/ct_run.test%40894bc85cbaf2.2023-03-08_22.59.48/big_tests.tests.muc_light_http_api_SUITE.logs/run.2023-03-08_23.11.12/log_private/"},
    {{saved_modules,mongooseim@localhost,<<"test type">>},
     #{mod_adhoc => #{iqdisc => one_queue,report_commands_node => false},
       mod_amp => #{},
       mod_bosh =>
      #{backend => mnesia,inactivity => 30,max_pause => 120,
        max_wait => infinity,server_acks => false},
       mod_cache_users =>
      #{number_of_segments => 5,strategy => fifo,time_to_live => 2},
       mod_carboncopy => #{iqdisc => no_queue},
       mod_disco =>
      #{extra_domains => []...

Report log

pgsql_mnesia_24 / pgsql_mnesia / 6ac2c48
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6ac2c48
Reports root/ big
OK: 2720 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 6ac2c48
Reports root/ big
OK: 2360 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 6ac2c48
Reports root/ big
OK: 2558 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 6ac2c48
Reports root/ big
OK: 4536 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 6ac2c48
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 6ac2c48
Reports root/ big
OK: 4547 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

mongoose-im · 2023-03-09T00:12:44Z

small_tests_24 / small_tests / ba87b61
Reports root / small

small_tests_25 / small_tests / ba87b61
Reports root / small

ldap_mnesia_24 / ldap_mnesia / ba87b61
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ba87b61
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / ba87b61
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ba87b61
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / ba87b61
Reports root/ big
OK: 4152 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / ba87b61
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ba87b61
Reports root/ big
OK: 4175 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / ba87b61
Reports root/ big
OK: 2360 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ba87b61
Reports root/ big
OK: 2727 / Failed: 1 / User-skipped: 663 / Auto-skipped: 0

pubsub_SUITE:dag+node_config:disable_persist_items_test

{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,491}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,481}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,471}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / ba87b61
Reports root/ big
OK: 2558 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / ba87b61
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / ba87b61
Reports root/ big
OK: 4536 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / ba87b61
Reports root/ big
OK: 4547 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

…aviour

…igated later

…on channels

mongoose-im · 2023-03-09T01:10:14Z

small_tests_24 / small_tests / 758c9bc
Reports root / small

small_tests_25 / small_tests / 758c9bc
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 758c9bc
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 758c9bc
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 758c9bc
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 758c9bc
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 758c9bc
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 758c9bc
Reports root/ big
OK: 4152 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 758c9bc
Reports root/ big
OK: 4175 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 758c9bc
Reports root/ big
OK: 2360 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 758c9bc
Reports root/ big
OK: 2720 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 758c9bc
Reports root/ big
OK: 2558 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 758c9bc
Reports root/ big
OK: 4536 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 758c9bc
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 758c9bc
Reports root/ big
OK: 4547 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

chrzaszcz

After a quick look:

Missing migration guide information about each changed/added/removed metric. Explain reasons for the changed metrics.
Missing information about the websockets support for components. It should be explicit in the migration guide that options are removed, especially the options enabled by default. Motivation for the removal is necessary. It would also help the reviewer understand the reason for the removal.

chrzaszcz

Github approved for me...

NelsonVides

I have two minor comments, one of them is just redundant whitespace, but the other scratches a bit on the idea of the websocket rework, so probably it can be done elsewhere and not here.
Apart from that, absolutely awesome PR 😄

NelsonVides · 2023-03-09T09:18:51Z

src/mod_websockets.erl

@@ -202,7 +161,7 @@ handle_text(Text, #ws_state{ parser = undefined } = State) ->
 handle_text(Text, #ws_state{parser = Parser} = State) ->
    case exml_stream:parse(Parser, Text) of
    {ok, NewParser, Elements} ->
-        mongoose_metrics:update(global, [data, xmpp, received, c2s, websocket, raw], byte_size(Text)),
+        mongoose_metrics:update(global, [data, xmpp, received, c2s, websocket], byte_size(Text)),
        State1 = State#ws_state{ parser = NewParser },
        case maybe_start_fsm(Elements, State1) of


I think that this maybe_start_fsm could be moved to the websocket init part, and simply assume the fsm is started for the duration of the websocket connection. That would remove checking this condition on every single stanza, and also, simplify some code. Also, it could be renamed to c2s instead of fsm 😛

let's make it in a context of another task. this task is about mongoose_transport rework and mod_websocket is changed only to break it's dependency with mongoose_transport.

big_tests/tests/service_mongoose_system_metrics_SUITE.erl

NelsonVides · 2023-03-09T11:00:47Z

Oh, also, why does codecov reports so bad coverage for the newly extended mongoose_transport module? 🤔

mongoose-im · 2023-03-10T11:52:45Z

small_tests_24 / small_tests / 59d9826
Reports root / small

small_tests_25 / small_tests / 59d9826
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 59d9826
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 59d9826
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 59d9826
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 59d9826
Reports root/ big
OK: 4152 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 59d9826
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 59d9826
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 59d9826
Reports root/ big
OK: 4175 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 59d9826
Reports root/ big
OK: 2360 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 59d9826
Reports root/ big
OK: 2558 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 59d9826
Reports root/ big
OK: 2720 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 59d9826
Reports root/ big
OK: 4536 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 59d9826
Reports root/ big
OK: 4555 / Failed: 1 / User-skipped: 100 / Auto-skipped: 0

disco_and_caps_SUITE:disco_with_caps:user_can_query_friend_resources

{error,{{assertion_failed,assert_many,false,[is_roster_set],[],[]},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_story,'-make_all_clients_friends/1-fun-0-',2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,108}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,make_all_clients_friends,1,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,106}]}]}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 59d9826
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mongoose-im · 2023-03-10T11:56:10Z

small_tests_24 / small_tests / 141cf58
Reports root / small

small_tests_25 / small_tests / 141cf58
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 141cf58
Reports root/ big
OK: 2217 / Failed: 1 / User-skipped: 825 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[{[global,data,xmpp,c2s,message,processing_time],
          expected_change,
          {before_story,[{n,0},
                   {mean,0},
                   {min,0},
                   {max,0},
                   {median,0},
                   {50,0},
                   {75,0},
                   {90,0},
                   {95,0},
                   {99,0},
                   {999,0}]},
          {after_story,[{n,0},
                  {mean,0},
                  {min,0},
                  {max,0},
                  {median,0},
                  {50,0},
                  {75,0},
                  {90,0},
                  {95,0},
                  {99,0},
                  {999,0}]}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_serve...

Report log

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 141cf58
Reports root/ big
OK: 4177 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[{[global,data,xmpp,c2s,message,processing_time],
          expected_change,
          {before_story,[{n,0},
                   {mean,0},
                   {min,0},
                   {max,0},
                   {median,0},
                   {50,0},
                   {75,0},
                   {90,0},
                   {95,0},
                   {99,0},
                   {999,0}]},
          {after_story,[{n,0},
                  {mean,0},
                  {min,0},
                  {max,0},
                  {median,0},
                  {50,0},
                  {75,0},
                  {90,0},
                  {95,0},
                  {99,0},
                  {999,0}]}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_serve...

Report log

ldap_mnesia_25 / ldap_mnesia / 141cf58
Reports root/ big
OK: 2217 / Failed: 1 / User-skipped: 825 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[{[global,data,xmpp,c2s,message,processing_time],
          expected_change,
          {before_story,[{n,0},
                   {mean,0},
                   {min,0},
                   {max,0},
                   {median,0},
                   {50,0},
                   {75,0},
                   {90,0},
                   {95,0},
                   {99,0},
                   {999,0}]},
          {after_story,[{n,0},
                  {mean,0},
                  {min,0},
                  {max,0},
                  {median,0},
                  {50,0},
                  {75,0},
                  {90,0},
                  {95,0},
                  {99,0},
                  {999,0}]}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_serve...

Report log

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 141cf58
Reports root/ big
OK: 4177 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[{[global,data,xmpp,c2s,message,processing_time],
          expected_change,
          {before_story,[{n,0},
                   {mean,0},
                   {min,0},
                   {max,0},
                   {median,0},
                   {50,0},
                   {75,0},
                   {90,0},
                   {95,0},
                   {99,0},
                   {999,0}]},
          {after_story,[{n,0},
                  {mean,0},
                  {min,0},
                  {max,0},
                  {median,0},
                  {50,0},
                  {75,0},
                  {90,0},
                  {95,0},
                  {99,0},
                  {999,0}]}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_serve...

Report log

pgsql_mnesia_24 / pgsql_mnesia / 141cf58
Reports root/ big
OK: 4549 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[{[global,data,xmpp,c2s,message,processing_time],
          expected_change,
          {before_story,[{n,0},
                   {mean,0},
                   {min,0},
                   {max,0},
                   {median,0},
                   {50,0},
                   {75,0},
                   {90,0},
                   {95,0},
                   {99,0},
                   {999,0}]},
          {after_story,[{n,0},
                  {mean,0},
                  {min,0},
                  {max,0},
                  {median,0},
                  {50,0},
                  {75,0},
                  {90,0},
                  {95,0},
                  {99,0},
                  {999,0}]}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_serve...

Report log

dynamic_domains_mysql_redis_25 / mysql_redis / 141cf58
Reports root/ big
OK: 4151 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[{[global,data,xmpp,c2s,message,processing_time],
          expected_change,
          {before_story,[{n,0},
                   {mean,0},
                   {min,0},
                   {max,0},
                   {median,0},
                   {50,0},
                   {75,0},
                   {90,0},
                   {95,0},
                   {99,0},
                   {999,0}]},
          {after_story,[{n,0},
                  {mean,0},
                  {min,0},
                  {max,0},
                  {median,0},
                  {50,0},
                  {75,0},
                  {90,0},
                  {95,0},
                  {99,0},
                  {999,0}]}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_serve...

Report log

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 141cf58
Reports root/ big
OK: 2719 / Failed: 1 / User-skipped: 662 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[{[global,data,xmpp,c2s,message,processing_time],
          expected_change,
          {before_story,[{n,0},
                   {mean,0},
                   {min,0},
                   {max,0},
                   {median,0},
                   {50,0},
                   {75,0},
                   {90,0},
                   {95,0},
                   {99,0},
                   {999,0}]},
          {after_story,[{n,0},
                  {mean,0},
                  {min,0},
                  {max,0},
                  {median,0},
                  {50,0},
                  {75,0},
                  {90,0},
                  {95,0},
                  {99,0},
                  {999,0}]}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_serve...

Report log

internal_mnesia_25 / internal_mnesia / 141cf58
Reports root/ big
OK: 2359 / Failed: 1 / User-skipped: 683 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[{[global,data,xmpp,c2s,message,processing_time],
          expected_change,
          {before_story,[{n,0},
                   {mean,0},
                   {min,0},
                   {max,0},
                   {median,0},
                   {50,0},
                   {75,0},
                   {90,0},
                   {95,0},
                   {99,0},
                   {999,0}]},
          {after_story,[{n,0},
                  {mean,0},
                  {min,0},
                  {max,0},
                  {median,0},
                  {50,0},
                  {75,0},
                  {90,0},
                  {95,0},
                  {99,0},
                  {999,0}]}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_serve...

Report log

riak_mnesia_24 / riak_mnesia / 141cf58
Reports root/ big
OK: 2557 / Failed: 1 / User-skipped: 654 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[{[global,data,xmpp,c2s,message,processing_time],
          expected_change,
          {before_story,[{n,0},
                   {mean,0},
                   {min,0},
                   {max,0},
                   {median,0},
                   {50,0},
                   {75,0},
                   {90,0},
                   {95,0},
                   {99,0},
                   {999,0}]},
          {after_story,[{n,0},
                  {mean,0},
                  {min,0},
                  {max,0},
                  {median,0},
                  {50,0},
                  {75,0},
                  {90,0},
                  {95,0},
                  {99,0},
                  {999,0}]}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_serve...

Report log

mysql_redis_25 / mysql_redis / 141cf58
Reports root/ big
OK: 4535 / Failed: 1 / User-skipped: 111 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[{[global,data,xmpp,c2s,message,processing_time],
          expected_change,
          {before_story,[{n,0},
                   {mean,0},
                   {min,0},
                   {max,0},
                   {median,0},
                   {50,0},
                   {75,0},
                   {90,0},
                   {95,0},
                   {99,0},
                   {999,0}]},
          {after_story,[{n,0},
                  {mean,0},
                  {min,0},
                  {max,0},
                  {median,0},
                  {50,0},
                  {75,0},
                  {90,0},
                  {95,0},
                  {99,0},
                  {999,0}]}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_serve...

Report log

pgsql_mnesia_25 / pgsql_mnesia / 141cf58
Reports root/ big
OK: 4549 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[{[global,data,xmpp,c2s,message,processing_time],
          expected_change,
          {before_story,[{n,0},
                   {mean,0},
                   {min,0},
                   {max,0},
                   {median,0},
                   {50,0},
                   {75,0},
                   {90,0},
                   {95,0},
                   {99,0},
                   {999,0}]},
          {after_story,[{n,0},
                  {mean,0},
                  {min,0},
                  {max,0},
                  {median,0},
                  {50,0},
                  {75,0},
                  {90,0},
                  {95,0},
                  {99,0},
                  {999,0}]}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_serve...

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / 141cf58
Reports root/ big
OK: 4545 / Failed: 2 / User-skipped: 100 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[{[global,data,xmpp,c2s,message,processing_time],
          expected_change,
          {before_story,[{n,0},
                   {mean,0},
                   {min,0},
                   {max,0},
                   {median,0},
                   {50,0},
                   {75,0},
                   {90,0},
                   {95,0},
                   {99,0},
                   {999,0}]},
          {after_story,[{n,0},
                  {mean,0},
                  {min,0},
                  {max,0},
                  {median,0},
                  {50,0},
                  {75,0},
                  {90,0},
                  {95,0},
                  {99,0},
                  {999,0}]}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_serve...

Report log

muc_http_api_SUITE:negative:kick_user_errors

{error,{{timeout,ok,[{times,50,not_yet}]},
    [{mongoose_helper,do_wait_until,2,
              [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
               {line,371}]},
     {muc_http_api_SUITE,kick_user_errors,1,
               [{file,"/home/circleci/project/big_tests/tests/muc_http_api_SUITE.erl"},
                {line,325}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

NelsonVides

Quick doc changes, one is important, the other is only a suggestion :)

doc/migrations/6.0.0_6.1.0.md

DenysGonchar · 2023-03-10T12:02:45Z

Oh, also, why does codecov reports so bad coverage for the newly extended mongoose_transport module? 🤔

taking into account that it's just a codecov/patch job failed, I would say that I have changed a lot of uncovered codelines.

…n guides

mongoose-im · 2023-03-10T15:11:27Z

small_tests_24 / small_tests / 97e3c2b
Reports root / small

small_tests_25 / small_tests / 97e3c2b
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 97e3c2b
Reports root/ big
OK: 2217 / Failed: 1 / User-skipped: 825 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[]},
    [{escalus_mongooseim,metric_type,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,100}]},
     {escalus_mongooseim,read_metric_initial_value,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,60}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
     {escalus_mongooseim,maybe_read_initial_metric_values,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,38}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,68}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 97e3c2b
Reports root/ big
OK: 4177 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[]},
    [{escalus_mongooseim,metric_type,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,100}]},
     {escalus_mongooseim,read_metric_initial_value,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,60}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
     {escalus_mongooseim,maybe_read_initial_metric_values,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,38}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,68}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

ldap_mnesia_25 / ldap_mnesia / 97e3c2b
Reports root/ big
OK: 2217 / Failed: 1 / User-skipped: 825 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[]},
    [{escalus_mongooseim,metric_type,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,100}]},
     {escalus_mongooseim,read_metric_initial_value,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,60}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_mongooseim,maybe_read_initial_metric_values,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,38}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,68}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 97e3c2b
Reports root/ big
OK: 4177 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[]},
    [{escalus_mongooseim,metric_type,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,100}]},
     {escalus_mongooseim,read_metric_initial_value,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,60}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_mongooseim,maybe_read_initial_metric_values,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,38}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,68}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mysql_redis_25 / mysql_redis / 97e3c2b
Reports root/ big
OK: 4151 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[]},
    [{escalus_mongooseim,metric_type,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,100}]},
     {escalus_mongooseim,read_metric_initial_value,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,60}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_mongooseim,maybe_read_initial_metric_values,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,38}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,68}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 97e3c2b
Reports root/ big
OK: 4174 / Failed: 1 / User-skipped: 91 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[]},
    [{escalus_mongooseim,metric_type,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,100}]},
     {escalus_mongooseim,read_metric_initial_value,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,60}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_mongooseim,maybe_read_initial_metric_values,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,38}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,68}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_mnesia_24 / pgsql_mnesia / 97e3c2b
Reports root/ big
OK: 4549 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[]},
    [{escalus_mongooseim,metric_type,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,100}]},
     {escalus_mongooseim,read_metric_initial_value,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,60}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
     {escalus_mongooseim,maybe_read_initial_metric_values,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,38}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,68}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

internal_mnesia_25 / internal_mnesia / 97e3c2b
Reports root/ big
OK: 2359 / Failed: 1 / User-skipped: 683 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[]},
    [{escalus_mongooseim,metric_type,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,100}]},
     {escalus_mongooseim,read_metric_initial_value,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,60}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_mongooseim,maybe_read_initial_metric_values,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,38}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,68}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 97e3c2b
Reports root/ big
OK: 2737 / Failed: 2 / User-skipped: 662 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[]},
    [{escalus_mongooseim,metric_type,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,100}]},
     {escalus_mongooseim,read_metric_initial_value,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,60}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_mongooseim,maybe_read_initial_metric_values,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,38}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,68}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pubsub_SUITE:tree+basic:subscribe_options_test

{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,491}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,481}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,471}]},
     {pubsub_SUITE,'-subscribe_options_test/1-fun-1-',3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
            {line,442}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / 97e3c2b
Reports root/ big
OK: 4534 / Failed: 2 / User-skipped: 111 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[]},
    [{escalus_mongooseim,metric_type,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,100}]},
     {escalus_mongooseim,read_metric_initial_value,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,60}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_mongooseim,maybe_read_initial_metric_values,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,38}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,68}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

sm_SUITE:parallel_unacknowledged_message_hook:unacknowledged_message_hook_filter

{error,{{badmatch,false},
    [{escalus_session,stream_resumption,2,
              [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
               {line,259}]},
     {escalus_connection,connection_step,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,161}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_connection,start,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,145}]},
     {sm_helper,connect_spec,3,
          [{file,"/home/circleci/project/big_tests/tests/sm_helper.erl"},
           {line,151}]},
     {sm_SUITE,unacknowledged_message_hook_filter,1,
           [{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
          {line,744}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / 97e3c2b
Reports root/ big
OK: 2557 / Failed: 1 / User-skipped: 654 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[]},
    [{escalus_mongooseim,metric_type,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,100}]},
     {escalus_mongooseim,read_metric_initial_value,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,60}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
     {escalus_mongooseim,maybe_read_initial_metric_values,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,38}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,68}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 97e3c2b
Reports root/ big
OK: 4549 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[]},
    [{escalus_mongooseim,metric_type,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,100}]},
     {escalus_mongooseim,read_metric_initial_value,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,60}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_mongooseim,maybe_read_initial_metric_values,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,38}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,68}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / 97e3c2b
Reports root/ big
OK: 4546 / Failed: 1 / User-skipped: 100 / Auto-skipped: 0

mim_c2s_SUITE:basic:two_users_can_log_and_chat

{error,{{badmatch,[]},
    [{escalus_mongooseim,metric_type,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,100}]},
     {escalus_mongooseim,read_metric_initial_value,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,60}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_mongooseim,maybe_read_initial_metric_values,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,38}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,68}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mongoose-im · 2023-03-14T09:52:01Z

small_tests_24 / small_tests / 32df936
Reports root / small

small_tests_25 / small_tests / 32df936
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 32df936
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 32df936
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 32df936
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 32df936
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 32df936
Reports root/ big
OK: 4152 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 32df936
Reports root/ big
OK: 4175 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 32df936
Reports root/ big
OK: 2720 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 32df936
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 32df936
Reports root/ big
OK: 2360 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 32df936
Reports root/ big
OK: 4536 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 32df936
Reports root/ big
OK: 2558 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 32df936
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 32df936
Reports root/ big
OK: 4547 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

chrzaszcz

Looks ok, nice to see the legacy modules removed.
There are some untested lines in mongoose_transport, but I assume they were also untested before, as most of them were moved from the legacy modules.

big_tests/tests/component_SUITE.erl

big_tests/tests/s2s_SUITE.erl

chrzaszcz · 2023-03-13T17:33:47Z

big_tests/tests/s2s_SUITE.erl

+    % ct:pal("Node = ~p, ConnectionType = ~p~nAllS2SConnections(~p): ~p",
+    %        [maps:get(node, RPCSpec), Type, length(AllS2SConnections), AllS2SConnections]),


Is this needed?

I would rather leave it for now, s2s is one of the topics for the next sprint

doc/migrations/6.0.0_6.1.0.md

src/mongoose_transport.erl

mongoose-im · 2023-03-14T18:17:59Z

small_tests_24 / small_tests / 2a186b4
Reports root / small

small_tests_25 / small_tests / 2a186b4
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 2a186b4
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 2a186b4
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 2a186b4
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2a186b4
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 2a186b4
Reports root/ big
OK: 4152 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 2a186b4
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 2a186b4
Reports root/ big
OK: 4175 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 2a186b4
Reports root/ big
OK: 2360 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 2a186b4
Reports root/ big
OK: 2558 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 2a186b4
Reports root/ big
OK: 2720 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 2a186b4
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 2a186b4
Reports root/ big
OK: 4536 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 2a186b4
Reports root/ big
OK: 4547 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

mongoose-im · 2023-03-15T02:30:38Z

small_tests_24 / small_tests / c75eb3c
Reports root / small

ldap_mnesia_24 / ldap_mnesia / c75eb3c
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c75eb3c
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / c75eb3c
Reports root/ big
OK: 4551 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

small_tests_25 / small_tests / c75eb3c
Reports root / small

riak_mnesia_24 / riak_mnesia / c75eb3c
Reports root/ big
OK: 2559 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c75eb3c
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / c75eb3c
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / c75eb3c
Reports root/ big
OK: 4152 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c75eb3c
Reports root/ big
OK: 4175 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / c75eb3c
Reports root/ big
OK: 2361 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c75eb3c
Reports root/ big
OK: 2720 / Failed: 1 / User-skipped: 662 / Auto-skipped: 0

graphql_session_SUITE:admin_session:admin_session_cli:admin_count_users_with_status

{error,
  {{assertEqual,
     [{module,graphql_session_SUITE},
      {line,586},
      {expression,"Count"},
      {expected,1},
      {value,0}]},
   [{graphql_session_SUITE,assert_count_users_with_status,4,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,586}]},
    {graphql_session_SUITE,admin_count_users_with_status_story,3,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,397}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / c75eb3c
Reports root/ big
OK: 4537 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / c75eb3c
Reports root/ big
OK: 4548 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / c75eb3c
Reports root/ big
OK: 4551 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / c75eb3c
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c75eb3c
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / c75eb3c
Reports root/ big
OK: 4152 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c75eb3c
Reports root/ big
OK: 4175 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / c75eb3c
Reports root/ big
OK: 2361 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / c75eb3c
Reports root/ big
OK: 4551 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / c75eb3c
Reports root/ big
OK: 4537 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / c75eb3c
Reports root/ big
OK: 4548 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

mongoose-im · 2023-03-15T10:23:49Z

small_tests_24 / small_tests / 65fce48
Reports root / small

small_tests_25 / small_tests / 65fce48
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 65fce48
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 65fce48
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 65fce48
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 65fce48
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 65fce48
Reports root/ big
OK: 4175 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 65fce48
Reports root/ big
OK: 4152 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 65fce48
Reports root/ big
OK: 4551 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 65fce48
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 65fce48
Reports root/ big
OK: 2361 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 65fce48
Reports root/ big
OK: 4551 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 65fce48
Reports root/ big
OK: 2559 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 65fce48
Reports root/ big
OK: 4537 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 65fce48
Reports root/ big
OK: 4548 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

chrzaszcz

Looks good 👍

chrzaszcz · 2023-03-15T11:30:31Z

doc/operation-and-maintenance/MongooseIM-metrics.md

+| `[global, data, xmpp, sent, xml_stanza_size]` | histogram | A size (in bytes) of a sent stanza before encryption. |
+| `[global, data, xmpp, received, c2s, tcp]` | spiral | A size (in bytes) of unencrypted data received from a client via TCP channel. |
+| `[global, data, xmpp, sent, c2s, tcp]` | spiral | A size (in bytes) of unencrypted data sent to a client via TCP channel. |
+| `[global, data, xmpp, received, c2s, tls]` | spiral | A size (in bytes) of a data received from a client via TLS channel after decryption. |


It's still "a data" in all these lines.

DenysGonchar force-pushed the reworking_mongoose_transport branch from 9812e88 to 6ac2c48 Compare March 8, 2023 22:53

DenysGonchar added 15 commits March 9, 2023 02:01

removing support of weboskets connnection for xmpp components

01d584a

cleaning up ignore_xref list for mod_bosh_socket

a2824b9

removing obsolete socket_type callback from the mongoose_listener beh…

3f5e047

…aviour

cleaning up ejabberd_socket & ejabberd_receiver

e2f56a3

removing ejabberd_socket module

6aac010

removing ejabberd_receiver module

b522278

adding spiral metrics for s2s and component connections

5eb2d62

some extra s2s testing

60124b9

reversing the last commit. s2s connections managment should be invest…

1abf603

…igated later

adding data.xmpp.*.xml_stanza_size calculation for mongoose_transport

4e734a7

removing some dead code

a155f16

extending ignore_xref lists for ejabberd_service & mongoose_transport

820932b

fix of the vcard_map in vcard_simple_SUITE

ef933da

removing the .raw suffix of connection spiral metrics

2c965bc

adding a description of newly introduced metrics for various connecti…

758c9bc

…on channels

DenysGonchar force-pushed the reworking_mongoose_transport branch from a138e12 to 758c9bc Compare March 9, 2023 01:01

DenysGonchar marked this pull request as ready for review March 9, 2023 01:03

DenysGonchar requested review from chrzaszcz and NelsonVides March 9, 2023 01:03

DenysGonchar added the waiting-for-review label Mar 9, 2023

chrzaszcz approved these changes Mar 9, 2023

View reviewed changes

chrzaszcz requested changes Mar 9, 2023

View reviewed changes

NelsonVides reviewed Mar 9, 2023

View reviewed changes

renaming and describing stanza processing time metric

5410f3e

NelsonVides reviewed Mar 10, 2023

View reviewed changes

doc/migrations/6.0.0_6.1.0.md Outdated Show resolved Hide resolved

doc/migrations/6.0.0_6.1.0.md Outdated Show resolved Hide resolved

DenysGonchar added 2 commits March 10, 2023 15:58

adding notes on removed metrics in migration guide

27afc1d

adding information about 'mod_websockets.service' removal in migratio…

fcc015b

…n guides

DenysGonchar force-pushed the reworking_mongoose_transport branch from 141cf58 to 97e3c2b Compare March 10, 2023 15:01

minor changes according to code review comments

32df936

DenysGonchar force-pushed the reworking_mongoose_transport branch from 97e3c2b to 32df936 Compare March 14, 2023 09:43

chrzaszcz reviewed Mar 14, 2023

View reviewed changes

DenysGonchar added 3 commits March 15, 2023 00:44

adding testing for 'data.xmpp.c2s.message.processing_time' metric

c2ac9de

throw an error if DB name is misspelled

6f63b63

splitting component_SUITE:register_two_components/1 test case into two

aafd006

DenysGonchar force-pushed the reworking_mongoose_transport branch from 2a186b4 to c75eb3c Compare March 15, 2023 02:15

DenysGonchar added 2 commits March 15, 2023 11:14

fixing incorrect indentation and typos

00f9551

updating migration guide with code review proposals

65fce48

DenysGonchar force-pushed the reworking_mongoose_transport branch from c75eb3c to 65fce48 Compare March 15, 2023 10:15

chrzaszcz approved these changes Mar 15, 2023

View reviewed changes

chrzaszcz merged commit d8874a1 into master Mar 15, 2023

chrzaszcz deleted the reworking_mongoose_transport branch March 15, 2023 11:34

jacekwegr added this to the 6.1.0 milestone Apr 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reworking mongoose transport #3982

Reworking mongoose transport #3982

DenysGonchar commented Mar 8, 2023 •

edited

Loading

mongoose-im commented Mar 8, 2023 •

edited

Loading

codecov bot commented Mar 8, 2023 •

edited

Loading

mongoose-im commented Mar 8, 2023 •

edited

Loading

mongoose-im commented Mar 9, 2023 •

edited

Loading

mongoose-im commented Mar 9, 2023 •

edited

Loading

chrzaszcz left a comment

chrzaszcz left a comment

NelsonVides left a comment

NelsonVides Mar 9, 2023

DenysGonchar Mar 10, 2023

NelsonVides commented Mar 9, 2023

mongoose-im commented Mar 10, 2023 •

edited

Loading

mongoose-im commented Mar 10, 2023 •

edited

Loading

NelsonVides left a comment

DenysGonchar commented Mar 10, 2023 •

edited

Loading

mongoose-im commented Mar 10, 2023 •

edited

Loading

mongoose-im commented Mar 14, 2023 •

edited

Loading

chrzaszcz left a comment

chrzaszcz Mar 13, 2023

DenysGonchar Mar 14, 2023

mongoose-im commented Mar 14, 2023 •

edited

Loading

mongoose-im commented Mar 15, 2023 •

edited

Loading

mongoose-im commented Mar 15, 2023 •

edited

Loading

chrzaszcz left a comment

chrzaszcz Mar 15, 2023

		% ct:pal("Node = ~p, ConnectionType = ~p~nAllS2SConnections(~p): ~p",
		% [maps:get(node, RPCSpec), Type, length(AllS2SConnections), AllS2SConnections]),

Reworking mongoose transport #3982

Reworking mongoose transport #3982

Conversation

DenysGonchar commented Mar 8, 2023 • edited Loading

mongoose-im commented Mar 8, 2023 • edited Loading

codecov bot commented Mar 8, 2023 • edited Loading

Codecov Report

mongoose-im commented Mar 8, 2023 • edited Loading

mongoose-im commented Mar 9, 2023 • edited Loading

mongoose-im commented Mar 9, 2023 • edited Loading

chrzaszcz left a comment

Choose a reason for hiding this comment

chrzaszcz left a comment

Choose a reason for hiding this comment

NelsonVides left a comment

Choose a reason for hiding this comment

NelsonVides Mar 9, 2023

Choose a reason for hiding this comment

DenysGonchar Mar 10, 2023

Choose a reason for hiding this comment

NelsonVides commented Mar 9, 2023

mongoose-im commented Mar 10, 2023 • edited Loading

mongoose-im commented Mar 10, 2023 • edited Loading

NelsonVides left a comment

Choose a reason for hiding this comment

DenysGonchar commented Mar 10, 2023 • edited Loading

mongoose-im commented Mar 10, 2023 • edited Loading

mongoose-im commented Mar 14, 2023 • edited Loading

chrzaszcz left a comment

Choose a reason for hiding this comment

chrzaszcz Mar 13, 2023

Choose a reason for hiding this comment

DenysGonchar Mar 14, 2023

Choose a reason for hiding this comment

mongoose-im commented Mar 14, 2023 • edited Loading

mongoose-im commented Mar 15, 2023 • edited Loading

mongoose-im commented Mar 15, 2023 • edited Loading

chrzaszcz left a comment

Choose a reason for hiding this comment

chrzaszcz Mar 15, 2023

Choose a reason for hiding this comment

DenysGonchar commented Mar 8, 2023 •

edited

Loading

mongoose-im commented Mar 8, 2023 •

edited

Loading

codecov bot commented Mar 8, 2023 •

edited

Loading

mongoose-im commented Mar 8, 2023 •

edited

Loading

mongoose-im commented Mar 9, 2023 •

edited

Loading

mongoose-im commented Mar 9, 2023 •

edited

Loading

mongoose-im commented Mar 10, 2023 •

edited

Loading

mongoose-im commented Mar 10, 2023 •

edited

Loading

DenysGonchar commented Mar 10, 2023 •

edited

Loading

mongoose-im commented Mar 10, 2023 •

edited

Loading

mongoose-im commented Mar 14, 2023 •

edited

Loading

mongoose-im commented Mar 14, 2023 •

edited

Loading

mongoose-im commented Mar 15, 2023 •

edited

Loading

mongoose-im commented Mar 15, 2023 •

edited

Loading