-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add small tests for arm64 #3986
Conversation
26aa2f9
to
ff4b39a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ff4b39a
to
b55247e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
b55247e
to
562e724
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3986 +/- ##
==========================================
- Coverage 83.56% 83.54% -0.02%
==========================================
Files 538 538
Lines 33975 33975
==========================================
- Hits 28391 28386 -5
- Misses 5584 5589 +5 see 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
562e724
to
ec88630
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ec88630
to
72f1ded
Compare
This comment was marked as outdated.
This comment was marked as outdated.
72f1ded
to
00c2a6d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
4c7ed72
to
e50df22
Compare
This comment was marked as outdated.
This comment was marked as outdated.
dabd0ea
to
d65952a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
small_tests_24 / small_tests / d65952a small_tests_25 / small_tests / d65952a ldap_mnesia_24 / ldap_mnesia / d65952a ldap_mnesia_25 / ldap_mnesia / d65952a dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d65952a dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d65952a dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d65952a muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_mysql_redis_25 / mysql_redis / d65952a pgsql_mnesia_24 / pgsql_mnesia / d65952a elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / d65952a internal_mnesia_25 / internal_mnesia / d65952a riak_mnesia_24 / riak_mnesia / d65952a pgsql_mnesia_25 / pgsql_mnesia / d65952a mssql_mnesia_25 / odbc_mssql_mnesia / d65952a muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mysql_redis_25 / mysql_redis / d65952a graphql_session_SUITE:admin_session:admin_session_cli:admin_kick_user_session{error,
{function_clause,
[{graphql_helper,get_error,
[1,
{{<<"200">>,<<"OK">>},
#{<<"data">> =>
#{<<"session">> =>
#{<<"kickUserSession">> =>
#{<<"code">> => null,
<<"jid">> =>
<<"alice_admin_kick_user_session_1177@localhost/res1">>,
<<"kicked">> => true,
<<"message">> => <<"Session kicked">>}}}}}],
[]},
{graphql_helper,get_err_msg,2,
[{file,
"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,227}]},
{graphql_session_SUITE,admin_kick_user_session_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
{line,441}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} |
d65952a
to
f7041f7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
f7041f7
to
ee7de83
Compare
small_tests_24 / small_tests / ee7de83 small_tests_25 / small_tests / ee7de83 ldap_mnesia_24 / ldap_mnesia / ee7de83 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ee7de83 ldap_mnesia_25 / ldap_mnesia / ee7de83 dynamic_domains_mysql_redis_25 / mysql_redis / ee7de83 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ee7de83 pgsql_mnesia_24 / pgsql_mnesia / ee7de83 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ee7de83 internal_mnesia_25 / internal_mnesia / ee7de83 mysql_redis_25 / mysql_redis / ee7de83 pgsql_mnesia_25 / pgsql_mnesia / ee7de83 riak_mnesia_24 / riak_mnesia / ee7de83 mssql_mnesia_25 / odbc_mssql_mnesia / ee7de83 |
ee7de83
to
541f6c1
Compare
small_tests_24 / small_tests / 541f6c1 small_tests_25 / small_tests / 541f6c1 small_tests_25_arm64 / small_tests / 541f6c1 ldap_mnesia_24 / ldap_mnesia / 541f6c1 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 541f6c1 ldap_mnesia_25 / ldap_mnesia / 541f6c1 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 541f6c1 dynamic_domains_mysql_redis_25 / mysql_redis / 541f6c1 internal_mnesia_25 / internal_mnesia / 541f6c1 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 541f6c1 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 541f6c1 pgsql_mnesia_24 / pgsql_mnesia / 541f6c1 mysql_redis_25 / mysql_redis / 541f6c1 riak_mnesia_24 / riak_mnesia / 541f6c1 pgsql_mnesia_25 / pgsql_mnesia / 541f6c1 small_tests_25_arm64 / small_tests / 541f6c1 mssql_mnesia_25 / odbc_mssql_mnesia / 541f6c1 small_tests_25_arm64 / small_tests / 541f6c1 |
541f6c1
to
67d51c8
Compare
small_tests_24 / small_tests / 67d51c8 small_tests_25_arm64 / small_tests / 67d51c8 small_tests_25 / small_tests / 67d51c8 ldap_mnesia_24 / ldap_mnesia / 67d51c8 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 67d51c8 dynamic_domains_mysql_redis_25 / mysql_redis / 67d51c8 service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>],
[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>,<<"example4.com">>]}}} dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 67d51c8 ldap_mnesia_25 / ldap_mnesia / 67d51c8 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 67d51c8 pgsql_mnesia_24 / pgsql_mnesia / 67d51c8 internal_mnesia_25 / internal_mnesia / 67d51c8 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 67d51c8 riak_mnesia_24 / riak_mnesia / 67d51c8 pgsql_mnesia_25 / pgsql_mnesia / 67d51c8 mssql_mnesia_25 / odbc_mssql_mnesia / 67d51c8 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,{{assertion_failed,assert_many,false,[is_presence],[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-make_all_clients_friends/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,109}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{escalus_utils,distinct_pairs,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,60}]},
{escalus_story,make_all_clients_friends,1,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,106}]}]}} mysql_redis_25 / mysql_redis / 67d51c8 dynamic_domains_mysql_redis_25 / mysql_redis / 67d51c8 mssql_mnesia_25 / odbc_mssql_mnesia / 67d51c8 |
It should be enough to have the small test logs. Big tests don't need to be compiled for small tests to succeed.
It can be taken, leading to unexpected failures. Just use any free port (passing '0' works like this).
Only the machine executor is available, leading to the following solution: 1. Start the main docker image, and the redis image needed by tests, joined by host networking. 2. Run small tests in the main docker image. 3. Collect and publish test results on the machine (not in docker) to simplify environment configuration. When CircleCI finally supports docker arm64 executors, this job can be simplified.
67d51c8
to
4797cf8
Compare
small_tests_24 / small_tests / 4797cf8 small_tests_25 / small_tests / 4797cf8 small_tests_25_arm64 / small_tests / 4797cf8 ldap_mnesia_24 / ldap_mnesia / 4797cf8 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 4797cf8 ldap_mnesia_25 / ldap_mnesia / 4797cf8 dynamic_domains_mysql_redis_25 / mysql_redis / 4797cf8 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 4797cf8 pgsql_mnesia_24 / pgsql_mnesia / 4797cf8 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 4797cf8 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 4797cf8 internal_mnesia_25 / internal_mnesia / 4797cf8 mysql_redis_25 / mysql_redis / 4797cf8 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} riak_mnesia_24 / riak_mnesia / 4797cf8 pgsql_mnesia_25 / pgsql_mnesia / 4797cf8 mssql_mnesia_25 / odbc_mssql_mnesia / 4797cf8 mysql_redis_25 / mysql_redis / 4797cf8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine
Run the small test job on the arm64 architecture. Details in commit messages.