Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wait_for_room_archive_size into given_fresh_room_with_messages in muc_SUITE #3999

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Add wait_for_room_archive_size into given_fresh_room_with_messages in muc_SUITE #3999

merged 1 commit into from
Apr 4, 2023

Conversation

arcusfelis
Copy link
Contributor

This PR addresses failed testcase muc_SUITE:hibernated_room_can_be_queried_for_archive

Proposed changes include:

  • Waiting for archive size for the room. Similar strategy is already implemented in mam_SUITE, but not in muc_SUITE for MAM tests.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Apr 3, 2023 •
edited
Loading

small_tests_24 / small_tests / 4bd3789
Reports root / small

small_tests_25 / small_tests / 4bd3789
Reports root / small

small_tests_25_arm64 / small_tests / 4bd3789
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 4bd3789
Reports root/ big
OK: 2218 / Failed: 1 / User-skipped: 827 / Auto-skipped: 0

muc_SUITE:hibernation:room_with_participants_and_messages_is_hibernated 
{error,{{room_archive_size,1,[{times,200,0}]},
    [{mongoose_helper,do_wait_until,2,
              [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
               {line,371}]},
     {mam_helper,wait_for_room_archive_size,3,
           [{file,"/home/circleci/project/big_tests/tests/mam_helper.erl"},
            {line,795}]},
     {muc_SUITE,given_fresh_room_with_messages_is_hibernated,4,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4363}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,room_with_participants_and_messages_is_hibernated,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4116}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 4bd3789
Reports root/ big
OK: 4180 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 4bd3789
Reports root/ big
OK: 4154 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 4bd3789
Reports root/ big
OK: 2218 / Failed: 1 / User-skipped: 827 / Auto-skipped: 0

muc_SUITE:hibernation:room_with_participants_and_messages_is_hibernated 
{error,{{room_archive_size,1,[{times,200,0}]},
    [{mongoose_helper,do_wait_until,2,
              [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
               {line,371}]},
     {mam_helper,wait_for_room_archive_size,3,
           [{file,"/home/circleci/project/big_tests/tests/mam_helper.erl"},
            {line,795}]},
     {muc_SUITE,given_fresh_room_with_messages_is_hibernated,4,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4363}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,room_with_participants_and_messages_is_hibernated,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4116}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 4bd3789
Reports root/ big
OK: 4180 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 4bd3789
Reports root/ big
OK: 4553 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 4bd3789
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 664 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 4bd3789
Reports root/ big
OK: 4177 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 4bd3789
Reports root/ big
OK: 2360 / Failed: 1 / User-skipped: 685 / Auto-skipped: 0

muc_SUITE:hibernation:room_with_participants_and_messages_is_hibernated 
{error,{{room_archive_size,1,[{times,200,0}]},
    [{mongoose_helper,do_wait_until,2,
              [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
               {line,371}]},
     {mam_helper,wait_for_room_archive_size,3,
           [{file,"/home/circleci/project/big_tests/tests/mam_helper.erl"},
            {line,795}]},
     {muc_SUITE,given_fresh_room_with_messages_is_hibernated,4,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4363}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,room_with_participants_and_messages_is_hibernated,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4116}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 4bd3789
Reports root/ big
OK: 4553 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 4bd3789
Reports root/ big
OK: 4539 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 4bd3789
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Apr 3, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (3698656) 82.12% compared to head (4c6bfcf) 82.19%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3999      +/-   ##
==========================================
+ Coverage   82.12%   82.19%   +0.06%     
==========================================
  Files         535      535              
  Lines       33842    33842              
==========================================
+ Hits        27794    27816      +22     
+ Misses       6048     6026      -22

see 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arcusfelis arcusfelis force-pushed the mu-fix-muc-wait-for-archive-size branch from 4bd3789 to 4c6bfcf Compare April 3, 2023 17:26
@mongoose-im
Copy link
Collaborator

mongoose-im commented Apr 3, 2023 •
edited
Loading

small_tests_24 / small_tests / 4c6bfcf
Reports root / small

small_tests_25 / small_tests / 4c6bfcf
Reports root / small

small_tests_25_arm64 / small_tests / 4c6bfcf
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 4c6bfcf
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 827 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 4c6bfcf
Reports root/ big
OK: 4180 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 4c6bfcf
Reports root/ big
OK: 4154 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 4c6bfcf
Reports root/ big
OK: 4180 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 4c6bfcf
Reports root/ big
OK: 4553 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 4c6bfcf
Reports root/ big
OK: 4177 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 4c6bfcf
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 664 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 4c6bfcf
Reports root/ big
OK: 2361 / Failed: 0 / User-skipped: 685 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 4c6bfcf
Reports root/ big
OK: 2212 / Failed: 2 / User-skipped: 827 / Auto-skipped: 5

bosh_SUITE:essential_https:accept_higher_hold_value 
{error,
  {{assertEqual,
     [{module,bosh_SUITE},
      {line,260},
      {expression,"get_bosh_sessions ( )"},
      {expected,[]},
      {value,
        [{bosh_session,<<"1b2134388d76e1ea1d98e5593d5441b696702dea">>,
           <9325.9745.0>}]}]},
   [{bosh_SUITE,accept_higher_hold_value,1,
      [{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
       {line,260}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mod_ping_SUITE:server_ping_kill:server_ping_pong 
{error,{{badmatch,[{[<<"localhost">>,mod_ping,ping_response],
          {expected_diff,5},
          {before_story,5},
          {after_story,9}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 4c6bfcf
Reports root/ big
OK: 4553 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 4c6bfcf
Reports root/ big
OK: 4539 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 4c6bfcf
Reports root/ big
OK: 4544 / Failed: 1 / User-skipped: 100 / Auto-skipped: 5

bosh_SUITE:essential:accept_higher_hold_value 
{error,
  {{assertEqual,
     [{module,bosh_SUITE},
      {line,260},
      {expression,"get_bosh_sessions ( )"},
      {expected,[]},
      {value,
        [{bosh_session,<<"f5baac8a9e1c6129617b05b85680a321389ed88c">>,
           <9325.10110.0>}]}]},
   [{bosh_SUITE,accept_higher_hold_value,1,
      [{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
       {line,260}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

ldap_mnesia_25 / ldap_mnesia / 4c6bfcf
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 827 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 4c6bfcf
Reports root/ big
OK: 4550 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

chrzaszcz
chrzaszcz approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit 0ef1f00 into master Apr 4, 2023
@chrzaszcz chrzaszcz deleted the mu-fix-muc-wait-for-archive-size branch April 4, 2023 09:00
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@arcusfelis @mongoose-im @chrzaszcz @jacekwegr