Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable provenance to make the docker manifest backwards-compatible #4009

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Apr 14, 2023

By default buildx creates OCI manifests, which cause a bug when you try to:

  • Inspect the docker manifest - even in the latest docker version
  • Pull the docker image in older docker - reproduced in 17.x

See docker/buildx#1509 for details.

Tested with latest docker:

root@ip-10-2-0-4:/home/ubuntu# docker manifest inspect mongooseim/mongooseim:PR-4008
no such manifest: docker.io/mongooseim/mongooseim:PR-4008
root@ip-10-2-0-4:/home/ubuntu# docker manifest inspect mongooseim/mongooseim:PR-4009
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 1491,
         "digest": "sha256:a419ed034140ccd982fc704f9df433b723aba17c50353ff0093d184144b26693",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 1491,
         "digest": "sha256:ee5bcade3181fd7c0b0c33ec1deff1564623c113b6539815ae321e6e835244d0",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      }
   ]
}

docker pull also works for PR-4009 in Docker 17.x

By default buildx creates OCI manifests, which cause a bug when you try to:
- Inspect the docker manifest - even in the latest docker version
- Pull the docker image in older docker - reproduced in 17.x

See docker/buildx#1509 for details.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Apr 14, 2023

small_tests_24 / small_tests / a26dee5
Reports root / small


small_tests_25 / small_tests / a26dee5
Reports root / small


small_tests_25_arm64 / small_tests / a26dee5
Reports root / small


ldap_mnesia_24 / ldap_mnesia / a26dee5
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a26dee5
Reports root/ big
OK: 4184 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / a26dee5
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / a26dee5
Reports root/ big
OK: 4184 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / a26dee5
Reports root/ big
OK: 4181 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / a26dee5
Reports root/ big
OK: 4158 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / a26dee5
Reports root/ big
OK: 4557 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / a26dee5
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 668 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / a26dee5
Reports root/ big
OK: 2361 / Failed: 0 / User-skipped: 689 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / a26dee5
Reports root/ big
OK: 4557 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / a26dee5
Reports root/ big
OK: 4543 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / a26dee5
Reports root/ big
OK: 4554 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0


small_tests_25 / small_tests / a26dee5
Reports root / small

@chrzaszcz chrzaszcz marked this pull request as ready for review April 14, 2023 14:26
Copy link
Collaborator

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine on old docker versions

@DenysGonchar DenysGonchar merged commit 0c9c1e7 into master Apr 18, 2023
@DenysGonchar DenysGonchar deleted the fix-docker-manifest branch April 18, 2023 09:00
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants