Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read node_id from discovery_nodes table in RDBMS #4042

Merged
merged 25 commits into from
Jun 29, 2023

Fix shadowed variable NodeBin

b83dc98
Select commit
Loading
Failed to load commit list.
Merged

Read node_id from discovery_nodes table in RDBMS #4042

Fix shadowed variable NodeBin
b83dc98
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 29, 2023 in 0s

82.21% (+0.01%) compared to 712a164

View this Pull Request on Codecov

82.21% (+0.01%) compared to 712a164

Details

Codecov Report

Patch coverage: 83.47% and project coverage change: +0.01 🎉

Comparison is base (712a164) 82.20% compared to head (b83dc98) 82.21%.

Additional details and impacted files
@@               Coverage Diff                @@
##           feature/cets    #4042      +/-   ##
================================================
+ Coverage         82.20%   82.21%   +0.01%     
================================================
  Files               539      541       +2     
  Lines             33952    34012      +60     
================================================
+ Hits              27909    27962      +53     
- Misses             6043     6050       +7     
Impacted Files Coverage Δ
src/mam/mod_mam_muc.erl 75.46% <ø> (ø)
src/mam/mod_mam_pm.erl 89.60% <ø> (ø)
src/ejabberd_app.erl 89.77% <73.33%> (-3.98%) ⬇️
src/mongoose_start_node_id.erl 75.00% <75.00%> (ø)
src/mongoose_cets_discovery_rdbms.erl 82.92% <82.92%> (+7.92%) ⬆️
src/ejabberd_local.erl 76.66% <100.00%> (-0.39%) ⬇️
src/ejabberd_sup.erl 78.57% <100.00%> (+0.52%) ⬆️
src/mam/mod_mam_utils.erl 89.05% <100.00%> (ø)
src/mongoose_node_num.erl 100.00% <100.00%> (ø)
src/mongoose_node_num_mnesia.erl 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.