Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xep attributes for 178 and add for 220 #4057

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

pawlooss1
Copy link
Member

This PR updates XEP-0178 version. It's still partial since we support only client-server SASL EXTERNAL.
It also adds an attribute for XEP-0220 which was already fully supported and implemented in ejabberd_s2s_in and ejabberd_s2s_out. I decided to put it only in one module to avoid mess. In feature/cets branch there's ongoing refactor of diaback, so this attribute should be only in newly introduced module after merge.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 13, 2023

small_tests_24 / small_tests / 99435ba
Reports root / small


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 99435ba
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_25_arm64 / small_tests / 99435ba
Reports root / small


small_tests_25 / small_tests / 99435ba
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 99435ba
Reports root/ big
OK: 2250 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 99435ba
Reports root/ big
OK: 4212 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 99435ba
Reports root/ big
OK: 2250 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 99435ba
Reports root/ big
OK: 4186 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 99435ba
Reports root/ big
OK: 4212 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0

mam_SUITE:rdbms_async_pool_muc_all:muc06:muc_message_with_stanzaid
{failed,
  {mam_SUITE,end_per_testcase,
    {'EXIT',
      {{room_archive_size,0,[{times,200,1}],ok},
       [{mongoose_helper,do_wait_until,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
           {line,357}]},
        {mam_helper,wait_for_room_archive_size,3,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,789}]},
        {mam_helper,clean_room_archive,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,733}]},
        {mam_helper,destroy_room,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,726}]},
        {mam_SUITE,end_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
           {line,954}]},
        {test_server,do_end_per_testcase,4,
          [{file,"test_server.erl"},{line,1626}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1334}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1223}]}]}}}}

Report log


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 99435ba
Reports root/ big
OK: 4209 / Failed: 0 / User-skipped: 85 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 99435ba
Reports root/ big
OK: 4595 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 99435ba
Reports root/ big
OK: 2395 / Failed: 1 / User-skipped: 680 / Auto-skipped: 0

mod_global_distrib_SUITE:hosts_refresher:test_host_refreshing
{error,
  {{trees_for_connections_present,true,[{times,50,false}],ok},
   [{mongoose_helper,do_wait_until,2,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,357}]},
    {mod_global_distrib_SUITE,test_host_refreshing,1,
      [{file,
         "/home/circleci/project/big_tests/tests/mod_global_distrib_SUITE.erl"},
       {line,384}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


pgsql_mnesia_25 / pgsql_mnesia / 99435ba
Reports root/ big
OK: 4595 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 99435ba
Reports root/ big
OK: 4581 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 99435ba
Reports root/ big
OK: 4592 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0

mam_SUITE:rdbms_async_pool_muc_all:muc06:muc_message_with_stanzaid
{failed,
  {mam_SUITE,end_per_testcase,
    {'EXIT',
      {{room_archive_size,0,[{times,200,1}],ok},
       [{mongoose_helper,do_wait_until,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
           {line,357}]},
        {mam_helper,wait_for_room_archive_size,3,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,789}]},
        {mam_helper,clean_room_archive,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,733}]},
        {mam_helper,destroy_room,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,726}]},
        {mam_SUITE,end_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
           {line,954}]},
        {test_server,do_end_per_testcase,4,
          [{file,"test_server.erl"},{line,1626}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1334}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1223}]}]}}}}

Report log


internal_mnesia_25 / internal_mnesia / 99435ba
Reports root/ big
OK: 2396 / Failed: 0 / User-skipped: 680 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (d87eb4c) 83.87% compared to head (99435ba) 83.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4057      +/-   ##
==========================================
- Coverage   83.87%   83.87%   -0.01%     
==========================================
  Files         526      526              
  Lines       33133    33133              
==========================================
- Hits        27790    27789       -1     
- Misses       5343     5344       +1     
Impacted Files Coverage Δ
src/ejabberd_s2s_out.erl 64.43% <ø> (ø)
src/sasl/cyrsasl_external.erl 88.60% <ø> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pawlooss1 pawlooss1 marked this pull request as ready for review July 13, 2023 11:59
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Contributor

@JanuszJakubiec JanuszJakubiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JanuszJakubiec JanuszJakubiec merged commit 802340a into master Jul 14, 2023
4 checks passed
@JanuszJakubiec JanuszJakubiec deleted the update-xep-178 branch July 14, 2023 10:16
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants