Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing GH Actions condition for metrics uploading to GA4 #4061

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

DenysGonchar
Copy link
Collaborator

@DenysGonchar DenysGonchar commented Jul 19, 2023

Minor fix to GH Actions.

here is a reference to the corresponding example in docs
https://docs.github.com/en/actions/learn-github-actions/expressions#example-of-failure-with-conditions

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 19, 2023

small_tests_25 / small_tests / 5333917
Reports root


small_tests_24 / small_tests / 5333917
Reports root / small


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 5333917
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_25_arm64 / small_tests / 5333917
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 5333917
Reports root/ big
OK: 2254 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5333917
Reports root/ big
OK: 4216 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5333917
Reports root/ big
OK: 4216 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5333917
Reports root/ big
OK: 4213 / Failed: 0 / User-skipped: 85 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 5333917
Reports root/ big
OK: 4599 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 5333917
Reports root/ big
OK: 2400 / Failed: 0 / User-skipped: 680 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 5333917
Reports root/ big
OK: 4599 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 5333917
Reports root/ big
OK: 4596 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 5333917
Reports root/ big
OK: 4585 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 5333917
Reports root/ big
OK: 2253 / Failed: 1 / User-skipped: 826 / Auto-skipped: 0

mod_global_distrib_SUITE:hosts_refresher:test_host_refreshing
{error,
  {{trees_for_connections_present,true,[{times,50,false}],ok},
   [{mongoose_helper,do_wait_until,2,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,357}]},
    {mod_global_distrib_SUITE,test_host_refreshing,1,
      [{file,
         "/home/circleci/project/big_tests/tests/mod_global_distrib_SUITE.erl"},
       {line,384}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


small_tests_25 / small_tests / 5333917
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 5333917
Reports root/ big
OK: 2253 / Failed: 1 / User-skipped: 826 / Auto-skipped: 0

pubsub_SUITE:dag+basic:request_all_items_test
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,444}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,434}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,424}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log


ldap_mnesia_25 / ldap_mnesia / 5333917
Reports root/ big
OK: 2254 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5530aed) 83.87% compared to head (5333917) 83.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4061   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         526      526           
  Lines       33159    33159           
=======================================
  Hits        27812    27812           
  Misses       5347     5347           

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@chrzaszcz chrzaszcz merged commit 1805ab6 into master Jul 19, 2023
@chrzaszcz chrzaszcz deleted the fixing-reporting-to-ga4 branch July 19, 2023 13:16
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants