-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing GH Actions condition for metrics uploading to GA4 #4061
Conversation
small_tests_25 / small_tests / 5333917 small_tests_24 / small_tests / 5333917 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 5333917 small_tests_25_arm64 / small_tests / 5333917 ldap_mnesia_24 / ldap_mnesia / 5333917 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5333917 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5333917 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5333917 pgsql_mnesia_24 / pgsql_mnesia / 5333917 internal_mnesia_25 / internal_mnesia / 5333917 pgsql_mnesia_25 / pgsql_mnesia / 5333917 mssql_mnesia_25 / odbc_mssql_mnesia / 5333917 mysql_redis_25 / mysql_redis / 5333917 ldap_mnesia_25 / ldap_mnesia / 5333917 mod_global_distrib_SUITE:hosts_refresher:test_host_refreshing{error,
{{trees_for_connections_present,true,[{times,50,false}],ok},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,357}]},
{mod_global_distrib_SUITE,test_host_refreshing,1,
[{file,
"/home/circleci/project/big_tests/tests/mod_global_distrib_SUITE.erl"},
{line,384}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} small_tests_25 / small_tests / 5333917 ldap_mnesia_25 / ldap_mnesia / 5333917 pubsub_SUITE:dag+basic:request_all_items_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} ldap_mnesia_25 / ldap_mnesia / 5333917 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #4061 +/- ##
=======================================
Coverage 83.87% 83.87%
=======================================
Files 526 526
Lines 33159 33159
=======================================
Hits 27812 27812
Misses 5347 5347 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👌
Minor fix to GH Actions.
here is a reference to the corresponding example in docs
https://docs.github.com/en/actions/learn-github-actions/expressions#example-of-failure-with-conditions