CETS backend for mod_muc #4066

arcusfelis · 2023-07-20T21:56:57Z

This PR addresses MIM-1933

Proposed changes include:

Add a (configurable) backend support for online MUC rooms.
Subscription to Mnesia events is replaced with a hook.
node_cleanup_for_host_type hook introduced.
CETS backend. One table per host_type.
Test for node_cleanup added.

Kicking logic for one of the rooms in handle_conflict could be done in a separate PR (easier to review, slightly different concerns when implementing and reviewing - i.e. would need new tests, because of new functionality).

Just one function in mongoose_muc_online_mnesia so far

Because we don't really need to

…e testcase

codecov · 2023-07-21T13:38:26Z

Codecov Report

Patch coverage: 90.00% and no project coverage change.

Comparison is base (5f98eeb) 83.95% compared to head (b3bede2) 83.95%.

Additional details and impacted files

@@              Coverage Diff              @@
##           feature/cets    #4066   +/-   ##
=============================================
  Coverage         83.95%   83.95%           
=============================================
  Files               543      546    +3     
  Lines             33454    33519   +65     
=============================================
+ Hits              28087    28142   +55     
- Misses             5367     5377   +10

Files Changed	Coverage Δ
src/mod_muc_mnesia.erl	`63.38% <ø> (ø)`
src/mod_muc_room.erl	`78.33% <ø> (-0.51%)`	⬇️
src/mod_muc.erl	`75.67% <70.58%> (-0.04%)`	⬇️
src/muc/mongoose_muc_online_cets.erl	`89.18% <89.18%> (ø)`
src/muc/mongoose_muc_online_mnesia.erl	`96.15% <96.15%> (ø)`
src/hooks/mongoose_hooks.erl	`94.94% <100.00%> (+0.03%)`	⬆️
src/mongoose_cleaner.erl	`63.63% <100.00%> (+3.63%)`	⬆️
src/muc/mongoose_muc_online_backend.erl	`100.00% <100.00%> (ø)`

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

And retry

mongoose-im · 2023-08-01T07:35:35Z

small_tests_24 / small_tests / 09a83fe
Reports root / small

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 09a83fe
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

small_tests_25_arm64 / small_tests / 09a83fe
Reports root / small

small_tests_25 / small_tests / 09a83fe
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 09a83fe
Reports root/ big
OK: 4220 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 09a83fe
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 830 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 09a83fe
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 830 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 09a83fe
Reports root/ big
OK: 4194 / Failed: 0 / User-skipped: 110 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 09a83fe
Reports root/ big
OK: 4605 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 09a83fe
Reports root/ big
OK: 4220 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 09a83fe
Reports root/ big
OK: 4217 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0

pgsql_cets_25 / pgsql_cets / 09a83fe
Reports root/ big
OK: 4581 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 09a83fe
Reports root/ big
OK: 4591 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

mam_SUITE:rdbms_async_cache_muc_all:muc06:muc_message_with_stanzaid

{failed,
  {mam_SUITE,end_per_testcase,
    {'EXIT',
      {{room_archive_size,0,[{times,200,1}],ok},
       [{mongoose_helper,do_wait_until,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
           {line,358}]},
        {mam_helper,wait_for_room_archive_size,3,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,789}]},
        {mam_helper,clean_room_archive,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,733}]},
        {mam_helper,destroy_room,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,726}]},
        {mam_SUITE,end_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
           {line,954}]},
        {test_server,do_end_per_testcase,4,
          [{file,"test_server.erl"},{line,1626}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1334}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1223}]}]}}}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 09a83fe
Reports root/ big
OK: 4604 / Failed: 1 / User-skipped: 91 / Auto-skipped: 0

mod_global_distrib_SUITE:hosts_refresher:test_host_refreshing

{error,
  {{trees_for_connections_present,true,[{times,50,false}],ok},
   [{mongoose_helper,do_wait_until,2,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,358}]},
    {mod_global_distrib_SUITE,test_host_refreshing,1,
      [{file,
         "/home/circleci/project/big_tests/tests/mod_global_distrib_SUITE.erl"},
       {line,384}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

internal_mnesia_25 / internal_mnesia / 09a83fe
Reports root/ big
OK: 2401 / Failed: 1 / User-skipped: 684 / Auto-skipped: 2

metrics_c2s_SUITE:single:presence_one

{error,
  {{xmppPresenceReceived,
     {value,141},
     [{times,25,
        {error,
          {badmatch,{value,142}},
          [{metrics_helper,assert_counter,3,
             [{file,
              "/home/circleci/project/big_tests/tests/metrics_helper.erl"},
            {line,36}]},
           {mongoose_helper,do_wait_until,2,
             [{file,
              "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
            {line,360}]},
           {metrics_c2s_SUITE,'-presence_one/1-fun-0-',1,
             [{file,
              "/home/circleci/project/big_tests/tests/metrics_c2s_SUITE.erl"},
            {line,125}]},
           {escalus_story,story,4,
             [{file,
              "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
            {line,72}]},
           {test_server,ts_tc,3,
             [{file,"test_server.erl"},{line,1782}]},
           {test_server,run_test_case_eval1,6,
             [{file,"test_server.erl"},{line,1291}]},
           {test_server,run_test_case_eval,9,
             [{file,"test_server.erl"},{line,1223}]}]}}],
     ok},
   [{mongoose_helper,do_wait_until,2,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,358}]},
    {metrics_c2s_SUITE,'-presence_one/1-fun-0-',1,
      [{file,
         "/home/circleci/project/big_tests/tests/metrics_c2s_SUITE.erl"},
       {line,125}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_test...

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / 09a83fe
Reports root/ big
OK: 4601 / Failed: 1 / User-skipped: 94 / Auto-skipped: 0

muc_SUITE:register:user_unregisters_nick

{error,
  {{assertion_failed,assert,is_iq_result,
     [{xmlel,<<"iq">>,
        [{<<"type">>,<<"set">>},
         {<<"id">>,<<"d2f82dd8b8b6c039b0308dfbaf7eab08">>},
         {<<"to">>,<<"muc.localhost">>}],
        [{xmlel,<<"query">>,
           [{<<"xmlns">>,<<"jabber:iq:register">>}],
           [{xmlel,<<"x">>,
            [{<<"xmlns">>,<<"jabber:x:data">>},
             {<<"type">>,<<"submit">>}],
            [{xmlel,<<"field">>,
               [{<<"type">>,<<"hidden">>},
                {<<"var">>,<<"FORM_TYPE">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,<<"jabber:iq:register">>}]}]},
             {xmlel,<<"field">>,
               [{<<"type">>,<<"text-single">>},
                {<<"var">>,<<"nick">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,
                     <<"thirdwitch1room-ece75af22c">>}]}]}]}]}]}],
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"muc.localhost">>},
        {<<"to">>,<<"alice_user_unregisters_nick_2689@localhost/res1">>},
        {<<"type">>,<<"error">>},
        {<<"id">>,<<"d2f82dd8b8b6c039b0308dfbaf7eab08">>}],
       [{xmlel,<<"query">>,
          [{<<"xmlns">>,<<"jabber:iq:register">>}],
          [{xmlel,<<"x">>,
             [{<<"xmlns">>,<<"jabber:x:data">>},
            {<<"type">>,<<"submit">>}],
             [{xmlel,<<"field">>,
              [{<<"type">>,<<"hidden">>},
               {<<"var">>,<<"FORM_TYPE">>}],
              [{xmlel,<<"value">>,[],
                 [{xmlcdata...

Report log

internal_mnesia_25 / internal_mnesia / 09a83fe
Reports root/ big
OK: 2404 / Failed: 0 / User-skipped: 684 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 09a83fe
Reports root/ big
OK: 4605 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 09a83fe
Reports root/ big
OK: 4602 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0

pawlooss1

Great work 👍 I left a question so I can understand one thing better. Also, I will have another look on this PR once you push new tests to satisfy CI

pawlooss1 · 2023-08-01T11:54:22Z

src/muc/mongoose_muc_online_cets.erl

+    Tab = table_name(HostType),
+    Pattern = {'_', '$1'},
+    Guard = {'==', {node, '$1'}, Node},
+    ets:select_delete(Tab, [{Pattern, [Guard], [true]}]),


It's strange that I didn't come up with this question in one of the earlier reviews 😅 I understand that for lookups and reads we can use straight ets API but why is it safe to use it for deleting items? On the other hand in room_destroyed function there is a call for cets API - cets:delete_object. What's the difference?

node_cleanup is called on all nodes in the cluster, so it is just data removal from the local table - no need for it to be replicated. And it is actually a lot of data removal to replicate, so we skip it.

Also, there is a chance we could move node_cleanup into CETS's handle_down callback function - to avoid race conditions in node down detection. But it is another topic :)

so, we skip replication step here, like it is done with mnesia backends

mongoose-im · 2023-08-01T13:39:15Z

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / db8b3e0
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

small_tests_24 / small_tests / db8b3e0
Reports root / small

small_tests_25 / small_tests / db8b3e0
Reports root / small

small_tests_25_arm64 / small_tests / db8b3e0
Reports root / small

ldap_mnesia_24 / ldap_mnesia / db8b3e0
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 830 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / db8b3e0
Reports root/ big
OK: 4220 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

mam_SUITE:rdbms_async_cache_muc_all:muc_configurable_archiveid:muc_only_stanzaid

{failed,
  {mam_SUITE,end_per_testcase,
    {'EXIT',
      {{room_archive_size,0,[{times,200,1}],ok},
       [{mongoose_helper,do_wait_until,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
           {line,358}]},
        {mam_helper,wait_for_room_archive_size,3,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,789}]},
        {mam_helper,clean_room_archive,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,733}]},
        {mam_helper,destroy_room,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,726}]},
        {mam_SUITE,end_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
           {line,965}]},
        {test_server,do_end_per_testcase,4,
          [{file,"test_server.erl"},{line,1627}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1335}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1224}]}]}}}}

Report log

ldap_mnesia_25 / ldap_mnesia / db8b3e0
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 830 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / db8b3e0
Reports root/ big
OK: 4220 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / db8b3e0
Reports root/ big
OK: 4605 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / db8b3e0
Reports root/ big
OK: 4217 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / db8b3e0
Reports root/ big
OK: 2404 / Failed: 0 / User-skipped: 684 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / db8b3e0
Reports root/ big
OK: 4193 / Failed: 1 / User-skipped: 110 / Auto-skipped: 0

graphql_session_SUITE:admin_session:admin_session_cli:admin_kick_user_session

{error,
  {function_clause,
    [{graphql_helper,get_error,
       [1,
        {{<<"200">>,<<"OK">>},
         #{<<"data">> =>
           #{<<"session">> =>
               #{<<"kickUserSession">> =>
                 #{<<"code">> => null,
                   <<"jid">> =>
                     <<"[email protected]/res1">>,
                   <<"kicked">> => true,
                   <<"message">> => <<"Session kicked">>}}}}}],
       []},
     {graphql_helper,get_err_msg,2,
       [{file,
          "/home/circleci/project/big_tests/tests/graphql_helper.erl"},
        {line,227}]},
     {graphql_session_SUITE,admin_kick_user_session_story,3,
       [{file,
          "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
        {line,441}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_cets_25 / pgsql_cets / db8b3e0
Reports root/ big
OK: 4581 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / db8b3e0
Reports root/ big
OK: 4591 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / db8b3e0
Reports root/ big
OK: 4605 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / db8b3e0
Reports root/ big
OK: 4601 / Failed: 1 / User-skipped: 94 / Auto-skipped: 0

mod_ping_SUITE:server_ping_kill:server_ping_pong

{error,{{badmatch,[{[<<"localhost">>,mod_ping,ping_response],
          {expected_diff,5},
          {before_story,5},
          {after_story,9}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mysql_redis_25 / mysql_redis / db8b3e0
Reports root/ big
OK: 4194 / Failed: 0 / User-skipped: 110 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / db8b3e0
Reports root/ big
OK: 4602 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0

chrzaszcz

Looks good, I only added minor comments

src/muc/mongoose_muc_online_backend.erl

…ackend

mongoose-im · 2023-08-02T07:55:13Z

small_tests_24 / small_tests / b3bede2
Reports root / small

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b3bede2
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

small_tests_25 / small_tests / b3bede2
Reports root / small

small_tests_25_arm64 / small_tests / b3bede2
Reports root / small

ldap_mnesia_24 / ldap_mnesia / b3bede2
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 830 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b3bede2
Reports root/ big
OK: 4220 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / b3bede2
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 830 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / b3bede2
Reports root/ big
OK: 4194 / Failed: 0 / User-skipped: 110 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b3bede2
Reports root/ big
OK: 4216 / Failed: 1 / User-skipped: 87 / Auto-skipped: 0

muc_SUITE:register:user_submits_registration_form_twice

{error,
  {{assertion_failed,assert,is_iq_result,
     [{xmlel,<<"iq">>,
        [{<<"type">>,<<"set">>},
         {<<"id">>,<<"c5a146637cc0360b70c15f16d7bc3d83">>},
         {<<"to">>,<<"groupchats.domain.example.com">>}],
        [{xmlel,<<"query">>,
           [{<<"xmlns">>,<<"jabber:iq:register">>}],
           [{xmlel,<<"x">>,
            [{<<"xmlns">>,<<"jabber:x:data">>},
             {<<"type">>,<<"submit">>}],
            [{xmlel,<<"field">>,
               [{<<"type">>,<<"hidden">>},
                {<<"var">>,<<"FORM_TYPE">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,<<"jabber:iq:register">>}]}]},
             {xmlel,<<"field">>,
               [{<<"type">>,<<"text-single">>},
                {<<"var">>,<<"nick">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,
                     <<"thirdwitchroom-ac87205789">>}]}]}]}]}]}],
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"groupchats.domain.example.com">>},
        {<<"to">>,
         <<"alice_user_submits_registration_form_twice_2511@domain.example.com/res1">>},
        {<<"type">>,<<"error">>},
        {<<"id">>,<<"c5a146637cc0360b70c15f16d7bc3d83">>}],
       [{xmlel,<<"query">>,
          [{<<"xmlns">>,<<"jabber:iq:register">>}],
          [{xmlel,<<"x">>,
             [{<<"xmlns">>,<<"jabber:x:data">>},
            {<<"type">>,<<"submit">>}],
             [{xmlel,<<"field">>,
              [{<<"type">>,<<"hidden">>},
               {<<"var">>,<<"FORM_TYPE">>}],
...

Report log

pgsql_mnesia_24 / pgsql_mnesia / b3bede2
Reports root/ big
OK: 4605 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b3bede2
Reports root/ big
OK: 4220 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / b3bede2
Reports root/ big
OK: 2404 / Failed: 0 / User-skipped: 684 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / b3bede2
Reports root/ big
OK: 4591 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

pgsql_cets_25 / pgsql_cets / b3bede2
Reports root/ big
OK: 4581 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / b3bede2
Reports root/ big
OK: 4605 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / b3bede2
Reports root/ big
OK: 4602 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b3bede2
Reports root/ big
OK: 4217 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0

arcusfelis marked this pull request as draft July 20, 2023 21:57

arcusfelis added the WIP 🚧 label Jul 20, 2023

This comment was marked as outdated.

Sign in to view

arcusfelis added 14 commits July 21, 2023 13:36

Change register_room output

2067224

Move muc_registered record into mod_muc_mnesia

cad94b6

Add mongoose_muc_online_backend support

106e13f

Just one function in mongoose_muc_online_mnesia so far

Move mnesia:create_table into the backend module

5efe813

Move register_room into mongoose_muc_online_mnesia

566ba24

Move find_room_pid into mongoose_muc_online_mnesia

e83128c

Move get_online_rooms function

20864d1

Remove clean_table_from_bad_node/1

4bb0321

Move node_cleanup into mongoose_muc_online_mnesia

077582c

Run node_cleanup for each host type

a166de5

Don't execute node_cleanup in MUC on start

5e41c46

Because we don't really need to

Add mongoose_cleanup_SUITE:cleaner_runs_hook_on_nodedown_for_host_typ…

1934ca0

…e testcase

Define default online_backend in tests

7d0da40

Fix graphql_muc_SUITE tests

e1d2037

arcusfelis force-pushed the mu-cets-muc-legacy branch from b1bc341 to e1d2037 Compare July 21, 2023 13:28

This comment was marked as outdated.

Sign in to view

arcusfelis added 2 commits July 21, 2023 16:40

Improve output spec of the start_room function

36161ef

Add CETS backend for mongoose_muc_online

b645f81

This comment was marked as outdated.

Sign in to view

arcusfelis added 2 commits July 31, 2023 14:45

Fix dialyzer

7ca84d8

Fix unload_muc in tests

5b11bf6

This comment was marked as outdated.

Sign in to view

arcusfelis force-pushed the mu-cets-muc-legacy branch from ac50890 to 660d2b0 Compare July 31, 2023 19:13

This comment was marked as outdated.

Sign in to view

arcusfelis added 4 commits August 1, 2023 09:26

Use cets:insert_new/2

4f6a4f8

And retry

Implement clear_table function for tests

579b730

Use mongoose_muc_online_backend in muc_helper:destroy_room

8a49ce3

Add ignore_xref for mongoose_muc_online_backend:clear_table/1

09a83fe

arcusfelis force-pushed the mu-cets-muc-legacy branch from 65dcec3 to 09a83fe Compare August 1, 2023 07:26

arcusfelis removed the WIP 🚧 label Aug 1, 2023

arcusfelis marked this pull request as ready for review August 1, 2023 08:19

pawlooss1 self-requested a review August 1, 2023 11:05

pawlooss1 reviewed Aug 1, 2023

View reviewed changes

Add tests for mongoose_muc_online_backend:node_cleanup/2

db8b3e0

chrzaszcz approved these changes Aug 2, 2023

View reviewed changes

src/muc/mongoose_muc_online_backend.erl Outdated Show resolved Hide resolved

src/muc/mongoose_muc_online_backend.erl Show resolved Hide resolved

arcusfelis added 2 commits August 2, 2023 09:42

Use jid:lserver() in specs for mud muc backends

7fc4538

Use mongoose_backend:call instead of tracked in mongoose_muc_online_b…

b3bede2

…ackend

pawlooss1 approved these changes Aug 2, 2023

View reviewed changes

chrzaszcz merged commit 3407849 into feature/cets Aug 2, 2023
4 checks passed

chrzaszcz deleted the mu-cets-muc-legacy branch August 2, 2023 08:43

chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CETS backend for mod_muc #4066

CETS backend for mod_muc #4066

arcusfelis commented Jul 20, 2023 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

codecov bot commented Jul 21, 2023 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Aug 1, 2023 •

edited

Loading

pawlooss1 left a comment

pawlooss1 Aug 1, 2023

arcusfelis Aug 1, 2023 •

edited

Loading

arcusfelis Aug 1, 2023

pawlooss1 Aug 2, 2023

mongoose-im commented Aug 1, 2023 •

edited

Loading

chrzaszcz left a comment

mongoose-im commented Aug 2, 2023 •

edited

Loading

CETS backend for mod_muc #4066

CETS backend for mod_muc #4066

Conversation

arcusfelis commented Jul 20, 2023 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

codecov bot commented Jul 21, 2023 • edited Loading

Codecov Report

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Aug 1, 2023 • edited Loading

pawlooss1 left a comment

Choose a reason for hiding this comment

pawlooss1 Aug 1, 2023

Choose a reason for hiding this comment

arcusfelis Aug 1, 2023 • edited Loading

Choose a reason for hiding this comment

arcusfelis Aug 1, 2023

Choose a reason for hiding this comment

pawlooss1 Aug 2, 2023

Choose a reason for hiding this comment

mongoose-im commented Aug 1, 2023 • edited Loading

chrzaszcz left a comment

Choose a reason for hiding this comment

mongoose-im commented Aug 2, 2023 • edited Loading

arcusfelis commented Jul 20, 2023 •

edited

Loading

codecov bot commented Jul 21, 2023 •

edited

Loading

mongoose-im commented Aug 1, 2023 •

edited

Loading

arcusfelis Aug 1, 2023 •

edited

Loading

mongoose-im commented Aug 1, 2023 •

edited

Loading

mongoose-im commented Aug 2, 2023 •

edited

Loading