Metrics/init

[NelsonVides]

The goal is that the whole metrics system can be initialised early and without any dependencies, on hooks, session manager, or other subsystems. It should be such subsystems the ones that register the metrics they consider necessary, and metrics one of the first things to be initialised by the system.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4333abe) 83.88% compared to head (8485ebb) 83.88%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4070   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files         526      526           
  Lines       33172    33181    +9     
=======================================
+ Hits        27826    27834    +8     
- Misses       5346     5347    +1     

Files Changed	Coverage Δ
src/ejabberd_app.erl	93.82% <100.00%> (+0.07%)	⬆️
src/ejabberd_sm.erl	88.56% <100.00%> (-0.25%)	⬇️
src/metrics/mongoose_metrics.erl	92.92% <100.00%> (+0.18%)	⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chrzaszcz]

Looks good

[mongoose-im]

small_tests_24 / small_tests / 8485ebb
Reports root / small

---

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8485ebb
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

---

small_tests_25 / small_tests / 8485ebb
Reports root / small

---

small_tests_25_arm64 / small_tests / 8485ebb
Reports root / small

---

ldap_mnesia_24 / ldap_mnesia / 8485ebb
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 827 / Auto-skipped: 0

---

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8485ebb
Reports root/ big
OK: 4221 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0

---

ldap_mnesia_25 / ldap_mnesia / 8485ebb
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 827 / Auto-skipped: 0

---

dynamic_domains_mysql_redis_25 / mysql_redis / 8485ebb
Reports root/ big
OK: 4195 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0

---

pgsql_mnesia_24 / pgsql_mnesia / 8485ebb
Reports root/ big
OK: 4604 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

mam_SUITE:rdbms_async_pool_muc_all:muc_configurable_archiveid:muc_no_elements

{failed,
  {mam_SUITE,end_per_testcase,
    {'EXIT',
      {{room_archive_size,0,[{times,200,1}],ok},
       [{mongoose_helper,do_wait_until,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
           {line,357}]},
        {mam_helper,wait_for_room_archive_size,3,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,789}]},
        {mam_helper,clean_room_archive,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,733}]},
        {mam_helper,destroy_room,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,726}]},
        {mam_SUITE,end_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
           {line,962}]},
        {test_server,do_end_per_testcase,4,
          [{file,"test_server.erl"},{line,1627}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1335}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1224}]}]}}}}

Report log

---

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8485ebb
Reports root/ big
OK: 4221 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0

---

internal_mnesia_25 / internal_mnesia / 8485ebb
Reports root/ big
OK: 2404 / Failed: 0 / User-skipped: 681 / Auto-skipped: 0

---

mssql_mnesia_25 / odbc_mssql_mnesia / 8485ebb
Reports root/ big
OK: 4601 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0

---

pgsql_mnesia_25 / pgsql_mnesia / 8485ebb
Reports root/ big
OK: 4604 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

---

mysql_redis_25 / mysql_redis / 8485ebb
Reports root/ big
OK: 4590 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0

---

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8485ebb
Reports root/ big
OK: 4218 / Failed: 0 / User-skipped: 85 / Auto-skipped: 0

[chrzaszcz]

👌