Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xep 0280 #4083

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Update xep 0280 #4083

merged 4 commits into from
Aug 10, 2023

Conversation

pawlooss1
Copy link
Member

This PR addresses MIM-1966 issue. It updates XEP version to the latest version. Implementation change which is introduced: messages of type normal containing chat markers are now eligible for carbons delivery (see https://xmpp.org/extensions/xep-0280.html#recommended-rules). I added a test of this new logic and a few for other logic which was not covered yet.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 7, 2023 •
edited
Loading

small_tests_24 / small_tests / 5c0b358
Reports root / small

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 5c0b358
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

small_tests_25 / small_tests / 5c0b358
Reports root / small

small_tests_25_arm64 / small_tests / 5c0b358
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 5c0b358
Reports root/ big
OK: 2263 / Failed: 0 / User-skipped: 827 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5c0b358
Reports root/ big
OK: 4226 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 5c0b358
Reports root/ big
OK: 2263 / Failed: 0 / User-skipped: 827 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5c0b358
Reports root/ big
OK: 4226 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 5c0b358
Reports root/ big
OK: 4200 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 5c0b358
Reports root/ big
OK: 4609 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 5c0b358
Reports root/ big
OK: 2409 / Failed: 0 / User-skipped: 681 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 5c0b358
Reports root/ big
OK: 4609 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5c0b358
Reports root/ big
OK: 4223 / Failed: 0 / User-skipped: 85 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 5c0b358
Reports root/ big
OK: 4595 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 5c0b358
Reports root/ big
OK: 4606 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.52% 🎉

Comparison is base (257371d) 83.37% compared to head (24b86c8) 83.90%.
Report is 12 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4083      +/-   ##
==========================================
+ Coverage   83.37%   83.90%   +0.52%     
==========================================
  Files         551      551              
  Lines       33544    33546       +2     
==========================================
+ Hits        27967    28146     +179     
+ Misses       5577     5400     -177
Files Changed Coverage Δ
src/mod_carboncopy.erl 90.22% <100.00%> (+0.14%) ⬆️

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 9, 2023 •
edited
Loading

small_tests_24 / small_tests / 1026905
Reports root / small

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 1026905
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

small_tests_25 / small_tests / 1026905
Reports root / small

small_tests_25_arm64 / small_tests / 1026905
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 1026905
Reports root/ big
OK: 2266 / Failed: 0 / User-skipped: 827 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1026905
Reports root/ big
OK: 4229 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 1026905
Reports root/ big
OK: 2266 / Failed: 0 / User-skipped: 827 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 1026905
Reports root/ big
OK: 4203 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1026905
Reports root/ big
OK: 4229 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 1026905
Reports root/ big
OK: 4226 / Failed: 0 / User-skipped: 85 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 1026905
Reports root/ big
OK: 4612 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 1026905
Reports root/ big
OK: 2412 / Failed: 0 / User-skipped: 681 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 1026905
Reports root/ big
OK: 4612 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 1026905
Reports root/ big
OK: 4598 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 1026905
Reports root/ big
OK: 4609 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 9, 2023 •
edited
Loading

small_tests_24 / small_tests / 4003a26
Reports root / small

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 4003a26
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

small_tests_25 / small_tests / 4003a26
Reports root / small

small_tests_25_arm64 / small_tests / 4003a26
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 4003a26
Reports root/ big
OK: 4230 / Failed: 0 / User-skipped: 84 / Auto-skipped: 3

carboncopy_SUITE:muc:init_per_group 
{'EXIT',
  {undef,
    [{muc_helper,load_muc,[],[]},
     {carboncopy_SUITE,init_per_group,2,
       [{file,
          "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
        {line,53}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1380}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1224}]}]}}

Report log

ldap_mnesia_24 / ldap_mnesia / 4003a26
Reports root/ big
OK: 2267 / Failed: 0 / User-skipped: 831 / Auto-skipped: 3

carboncopy_SUITE:muc:init_per_group 
{'EXIT',
  {undef,
    [{muc_helper,load_muc,[],[]},
     {carboncopy_SUITE,init_per_group,2,
       [{file,
          "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
        {line,53}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1380}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1224}]}]}}

Report log

ldap_mnesia_25 / ldap_mnesia / 4003a26
Reports root/ big
OK: 2267 / Failed: 0 / User-skipped: 831 / Auto-skipped: 3

carboncopy_SUITE:muc:init_per_group 
{'EXIT',
  {undef,
    [{muc_helper,load_muc,[],[]},
     {carboncopy_SUITE,init_per_group,2,
       [{file,
          "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
        {line,53}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1379}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 4003a26
Reports root/ big
OK: 4230 / Failed: 0 / User-skipped: 84 / Auto-skipped: 3

carboncopy_SUITE:muc:init_per_group 
{'EXIT',
  {undef,
    [{muc_helper,load_muc,[],[]},
     {carboncopy_SUITE,init_per_group,2,
       [{file,
          "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
        {line,53}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1379}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_mnesia_24 / pgsql_mnesia / 4003a26
Reports root/ big
OK: 4615 / Failed: 0 / User-skipped: 91 / Auto-skipped: 3

carboncopy_SUITE:muc:init_per_group 
{'EXIT',
  {undef,
    [{muc_helper,load_muc,[],[]},
     {carboncopy_SUITE,init_per_group,2,
       [{file,
          "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
        {line,53}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1380}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1224}]}]}}

Report log

internal_mnesia_25 / internal_mnesia / 4003a26
Reports root/ big
OK: 2413 / Failed: 0 / User-skipped: 685 / Auto-skipped: 3

carboncopy_SUITE:muc:init_per_group 
{'EXIT',
  {undef,
    [{muc_helper,load_muc,[],[]},
     {carboncopy_SUITE,init_per_group,2,
       [{file,
          "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
        {line,53}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1379}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_cets_25 / pgsql_cets / 4003a26
Reports root/ big
OK: 4585 / Failed: 0 / User-skipped: 121 / Auto-skipped: 3

carboncopy_SUITE:muc:init_per_group 
{'EXIT',
  {undef,
    [{muc_helper,load_muc,[],[]},
     {carboncopy_SUITE,init_per_group,2,
       [{file,
          "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
        {line,53}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1379}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 4003a26
Reports root/ big
OK: 4227 / Failed: 0 / User-skipped: 87 / Auto-skipped: 3

carboncopy_SUITE:muc:init_per_group 
{'EXIT',
  {undef,
    [{muc_helper,load_muc,[],[]},
     {carboncopy_SUITE,init_per_group,2,
       [{file,
          "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
        {line,53}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1379}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / 4003a26
Reports root/ big
OK: 4595 / Failed: 0 / User-skipped: 111 / Auto-skipped: 3

carboncopy_SUITE:muc:init_per_group 
{'EXIT',
  {undef,
    [{muc_helper,load_muc,[],[]},
     {carboncopy_SUITE,init_per_group,2,
       [{file,
          "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
        {line,53}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1379}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 4003a26
Reports root/ big
OK: 4615 / Failed: 0 / User-skipped: 91 / Auto-skipped: 3

carboncopy_SUITE:muc:init_per_group 
{'EXIT',
  {undef,
    [{muc_helper,load_muc,[],[]},
     {carboncopy_SUITE,init_per_group,2,
       [{file,
          "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
        {line,53}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1379}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / 4003a26
Reports root/ big
OK: 4612 / Failed: 0 / User-skipped: 94 / Auto-skipped: 3

carboncopy_SUITE:muc:init_per_group 
{'EXIT',
  {undef,
    [{muc_helper,load_muc,[],[]},
     {carboncopy_SUITE,init_per_group,2,
       [{file,
          "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
        {line,53}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1379}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mysql_redis_25 / mysql_redis / 4003a26
Reports root/ big
OK: 4197 / Failed: 1 / User-skipped: 116 / Auto-skipped: 3

carboncopy_SUITE:muc:init_per_group 
{'EXIT',
  {undef,
    [{muc_helper,load_muc,[],[]},
     {carboncopy_SUITE,init_per_group,2,
       [{file,
          "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
        {line,53}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1379}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

graphql_last_SUITE:admin_cli:admin_last_configured:admin_last:admin_count_active_users 
{error,{{assertEqual,[{module,graphql_last_SUITE},
            {line,312},
            {expression,"get_ok_value ( p ( countActiveUsers ) , Res1 )"},
            {expected,2},
            {value,1}]},
    [{graphql_last_SUITE,admin_count_active_users_story,3,
               [{file,"/home/circleci/project/big_tests/tests/graphql_last_SUITE.erl"},
                {line,312}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 9, 2023 •
edited
Loading

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / d4ff17d
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

small_tests_24 / small_tests / d4ff17d
Reports root / small

small_tests_25_arm64 / small_tests / d4ff17d
Reports root / small

small_tests_25 / small_tests / d4ff17d
Reports root / small

ldap_mnesia_24 / ldap_mnesia / d4ff17d
Reports root/ big
OK: 2270 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d4ff17d
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / d4ff17d
Reports root/ big
OK: 4201 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / d4ff17d
Reports root/ big
OK: 2270 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / d4ff17d
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d4ff17d
Reports root/ big
OK: 4230 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / d4ff17d
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / d4ff17d
Reports root/ big
OK: 2416 / Failed: 0 / User-skipped: 685 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / d4ff17d
Reports root/ big
OK: 4598 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

pgsql_cets_25 / pgsql_cets / d4ff17d
Reports root/ big
OK: 4588 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d4ff17d
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / d4ff17d
Reports root/ big
OK: 4615 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0

@pawlooss1 pawlooss1 marked this pull request as ready for review August 9, 2023 13:25
chrzaszcz
chrzaszcz approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 and I only added minor comments.

big_tests/tests/carboncopy_helper.erl Outdated Show resolved Hide resolved
big_tests/tests/carboncopy_helper.erl Outdated Show resolved Hide resolved
@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 10, 2023 •
edited
Loading

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 24b86c8
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

small_tests_24 / small_tests / 24b86c8
Reports root / small

small_tests_25_arm64 / small_tests / 24b86c8
Reports root / small

small_tests_25 / small_tests / 24b86c8
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 24b86c8
Reports root/ big
OK: 2264 / Failed: 1 / User-skipped: 831 / Auto-skipped: 5

bosh_SUITE:essential:accept_higher_hold_value 
{error,
  {{assertEqual,
     [{module,bosh_SUITE},
      {line,260},
      {expression,"get_bosh_sessions ( )"},
      {expected,[]},
      {value,
        [{bosh_session,<<"ce266ae8bfbf3658deb6c29d31c6f3164af31889">>,
           <8854.9677.0>}]}]},
   [{bosh_SUITE,accept_higher_hold_value,1,
      [{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
       {line,260}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 24b86c8
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 24b86c8
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 24b86c8
Reports root/ big
OK: 4201 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 24b86c8
Reports root/ big
OK: 2270 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 24b86c8
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 24b86c8
Reports root/ big
OK: 4230 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 24b86c8
Reports root/ big
OK: 2415 / Failed: 1 / User-skipped: 685 / Auto-skipped: 0

mod_global_distrib_SUITE:hosts_refresher:test_host_refreshing 
{error,
  {{trees_for_connections_present,true,[{times,100,false}],ok},
   [{mongoose_helper,do_wait_until,2,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,358}]},
    {mod_global_distrib_SUITE,test_host_refreshing,1,
      [{file,
         "/home/circleci/project/big_tests/tests/mod_global_distrib_SUITE.erl"},
       {line,384}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / 24b86c8
Reports root/ big
OK: 4598 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

pgsql_cets_25 / pgsql_cets / 24b86c8
Reports root/ big
OK: 4588 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 24b86c8
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 24b86c8
Reports root/ big
OK: 4615 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 24b86c8
Reports root/ big
OK: 2270 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 24b86c8
Reports root/ big
OK: 2416 / Failed: 0 / User-skipped: 685 / Auto-skipped: 0

chrzaszcz
chrzaszcz approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@chrzaszcz chrzaszcz merged commit 23aa906 into master Aug 10, 2023
4 checks passed
@chrzaszcz chrzaszcz deleted the update-xep-0280 branch August 10, 2023 13:18
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pawlooss1 @mongoose-im @chrzaszcz