Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating XEP-0060 Publish-Subscribe #4092

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Updating XEP-0060 Publish-Subscribe #4092

merged 5 commits into from
Aug 15, 2023

Conversation

JanuszJakubiec
Copy link
Contributor

Include a feature of http://jabber.org/protocol/pubsub#rsm in disco#info response.

Check preconditions when accepting publish-options along with a publish request. We have two node types which advertise support for the publish-options feature.
In node push the preconditions are not checked. This node type is supporting xep-0163.
In node pep the changes are implemented, and the publish-options are being checked.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 96.87% and project coverage change: +0.04% 🎉

Comparison is base (dec621e) 83.85% compared to head (ea8e8ce) 83.90%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4092      +/-   ##
==========================================
+ Coverage   83.85%   83.90%   +0.04%     
==========================================
  Files         551      551              
  Lines       33568    33594      +26     
==========================================
+ Hits        28149    28186      +37     
+ Misses       5419     5408      -11     
Files Changed Coverage Δ
src/event_pusher/mod_event_pusher_push.erl 94.68% <ø> (ø)
src/pubsub/mod_pubsub.erl 75.82% <94.44%> (+0.51%) ⬆️
src/pubsub/node_pep.erl 82.25% <100.00%> (+2.62%) ⬆️
src/pubsub/node_push.erl 90.00% <100.00%> (-3.11%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@JanuszJakubiec JanuszJakubiec marked this pull request as ready for review August 15, 2023 10:31
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 15, 2023

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ea8e8ce
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_24 / small_tests / ea8e8ce
Reports root / small


small_tests_25 / small_tests / ea8e8ce
Reports root / small


small_tests_25_arm64 / small_tests / ea8e8ce
Reports root / small


ldap_mnesia_24 / ldap_mnesia / ea8e8ce
Reports root/ big
OK: 2274 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / ea8e8ce
Reports root/ big
OK: 4201 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ea8e8ce
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / ea8e8ce
Reports root/ big
OK: 2274 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ea8e8ce
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / ea8e8ce
Reports root/ big
OK: 2420 / Failed: 0 / User-skipped: 685 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ea8e8ce
Reports root/ big
OK: 4230 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / ea8e8ce
Reports root/ big
OK: 4622 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


pgsql_cets_25 / pgsql_cets / ea8e8ce
Reports root/ big
OK: 4592 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / ea8e8ce
Reports root/ big
OK: 4622 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / ea8e8ce
Reports root/ big
OK: 4619 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / ea8e8ce
Reports root/ big
OK: 4602 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@NelsonVides NelsonVides merged commit e6b9cc2 into master Aug 15, 2023
4 checks passed
@NelsonVides NelsonVides deleted the pubsub_update branch August 15, 2023 16:18
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants