-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch ejabberd_sm #4096
Patch ejabberd_sm #4096
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4096 +/- ##
==========================================
+ Coverage 83.84% 83.87% +0.03%
==========================================
Files 551 551
Lines 33557 33558 +1
==========================================
+ Hits 28135 28147 +12
+ Misses 5422 5411 -11
☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 492085d small_tests_24 / small_tests / 492085d small_tests_25 / small_tests / 492085d small_tests_25_arm64 / small_tests / 492085d ldap_mnesia_24 / ldap_mnesia / 492085d dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 492085d ldap_mnesia_25 / ldap_mnesia / 492085d dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 492085d dynamic_domains_mysql_redis_25 / mysql_redis / 492085d dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 492085d pgsql_mnesia_24 / pgsql_mnesia / 492085d pgsql_cets_25 / pgsql_cets / 492085d internal_mnesia_25 / internal_mnesia / 492085d pubsub_SUITE:tree+basic:subscribe_options_test{error,{{badmatch,{{<<"pubsub#deliver">>,<<"boolean">>,<<"false">>},
<<"pubsub#deliver">>}},
[{pubsub_tools,'-verify_form_values/2-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,606}]},
{lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
{pubsub_SUITE,'-subscribe_options_test/1-fun-1-',3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,377}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mysql_redis_25 / mysql_redis / 492085d pgsql_mnesia_25 / pgsql_mnesia / 492085d mssql_mnesia_25 / odbc_mssql_mnesia / 492085d internal_mnesia_25 / internal_mnesia / 492085d |
elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / e8a2cc8 small_tests_24 / small_tests / e8a2cc8 small_tests_25 / small_tests / e8a2cc8 small_tests_25_arm64 / small_tests / e8a2cc8 ldap_mnesia_24 / ldap_mnesia / e8a2cc8 dynamic_domains_mysql_redis_25 / mysql_redis / e8a2cc8 ldap_mnesia_25 / ldap_mnesia / e8a2cc8 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / e8a2cc8 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / e8a2cc8 pgsql_mnesia_24 / pgsql_mnesia / e8a2cc8 mysql_redis_25 / mysql_redis / e8a2cc8 internal_mnesia_25 / internal_mnesia / e8a2cc8 pgsql_cets_25 / pgsql_cets / e8a2cc8 mam_SUITE:rdbms_async_cache_muc_all:muc06:muc_message_with_stanzaid{failed,
{mam_SUITE,end_per_testcase,
{'EXIT',
{{room_archive_size,0,[{times,200,1}],ok},
[{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,358}]},
{mam_helper,wait_for_room_archive_size,3,
[{file,
"/home/circleci/project/big_tests/tests/mam_helper.erl"},
{line,789}]},
{mam_helper,clean_room_archive,1,
[{file,
"/home/circleci/project/big_tests/tests/mam_helper.erl"},
{line,733}]},
{mam_helper,destroy_room,1,
[{file,
"/home/circleci/project/big_tests/tests/mam_helper.erl"},
{line,726}]},
{mam_SUITE,end_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
{line,954}]},
{test_server,do_end_per_testcase,4,
[{file,"test_server.erl"},{line,1626}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1334}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}}} pgsql_mnesia_25 / pgsql_mnesia / e8a2cc8 mssql_mnesia_25 / odbc_mssql_mnesia / e8a2cc8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🔥
This PR addresses a couple of tweaks. (MIM-2001)
Proposed changes include: