Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch ejabberd_sm #4096

Merged
merged 2 commits into from
Aug 13, 2023
Merged

Patch ejabberd_sm #4096

merged 2 commits into from
Aug 13, 2023

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Aug 12, 2023

This PR addresses a couple of tweaks. (MIM-2001)

Proposed changes include:

  • One less get_sessions/2 on open_session in SM
  • Disconnect both present and not sessions in disconnect_removed_user

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (4704292) 83.84% compared to head (e8a2cc8) 83.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4096      +/-   ##
==========================================
+ Coverage   83.84%   83.87%   +0.03%     
==========================================
  Files         551      551              
  Lines       33557    33558       +1     
==========================================
+ Hits        28135    28147      +12     
+ Misses       5422     5411      -11     
Files Changed Coverage Δ
src/ejabberd_sm.erl 88.44% <100.00%> (+0.04%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 12, 2023

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 492085d
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_24 / small_tests / 492085d
Reports root / small


small_tests_25 / small_tests / 492085d
Reports root / small


small_tests_25_arm64 / small_tests / 492085d
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 492085d
Reports root/ big
OK: 2262 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 492085d
Reports root/ big
OK: 4225 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 492085d
Reports root/ big
OK: 2262 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 492085d
Reports root/ big
OK: 4225 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 492085d
Reports root/ big
OK: 4193 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 492085d
Reports root/ big
OK: 4222 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 492085d
Reports root/ big
OK: 4610 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


pgsql_cets_25 / pgsql_cets / 492085d
Reports root/ big
OK: 4580 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 492085d
Reports root/ big
OK: 2407 / Failed: 1 / User-skipped: 685 / Auto-skipped: 0

pubsub_SUITE:tree+basic:subscribe_options_test
{error,{{badmatch,{{<<"pubsub#deliver">>,<<"boolean">>,<<"false">>},
           <<"pubsub#deliver">>}},
    [{pubsub_tools,'-verify_form_values/2-fun-0-',2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,606}]},
     {lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
     {pubsub_SUITE,'-subscribe_options_test/1-fun-1-',3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
            {line,377}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mysql_redis_25 / mysql_redis / 492085d
Reports root/ big
OK: 4590 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 492085d
Reports root/ big
OK: 4610 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 492085d
Reports root/ big
OK: 4607 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 492085d
Reports root/ big
OK: 2408 / Failed: 0 / User-skipped: 685 / Auto-skipped: 0

@arcusfelis arcusfelis changed the title Patch jeabberd_sm Patch ejabberd_sm Aug 13, 2023
@arcusfelis arcusfelis closed this Aug 13, 2023
@arcusfelis arcusfelis reopened this Aug 13, 2023
@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 13, 2023

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / e8a2cc8
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_24 / small_tests / e8a2cc8
Reports root / small


small_tests_25 / small_tests / e8a2cc8
Reports root / small


small_tests_25_arm64 / small_tests / e8a2cc8
Reports root / small


ldap_mnesia_24 / ldap_mnesia / e8a2cc8
Reports root/ big
OK: 2270 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / e8a2cc8
Reports root/ big
OK: 4201 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / e8a2cc8
Reports root/ big
OK: 2270 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / e8a2cc8
Reports root/ big
OK: 4230 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / e8a2cc8
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / e8a2cc8
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / e8a2cc8
Reports root/ big
OK: 4598 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / e8a2cc8
Reports root/ big
OK: 2416 / Failed: 0 / User-skipped: 685 / Auto-skipped: 0


pgsql_cets_25 / pgsql_cets / e8a2cc8
Reports root/ big
OK: 4588 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

mam_SUITE:rdbms_async_cache_muc_all:muc06:muc_message_with_stanzaid
{failed,
  {mam_SUITE,end_per_testcase,
    {'EXIT',
      {{room_archive_size,0,[{times,200,1}],ok},
       [{mongoose_helper,do_wait_until,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
           {line,358}]},
        {mam_helper,wait_for_room_archive_size,3,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,789}]},
        {mam_helper,clean_room_archive,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,733}]},
        {mam_helper,destroy_room,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,726}]},
        {mam_SUITE,end_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
           {line,954}]},
        {test_server,do_end_per_testcase,4,
          [{file,"test_server.erl"},{line,1626}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1334}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1223}]}]}}}}

Report log


pgsql_mnesia_25 / pgsql_mnesia / e8a2cc8
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / e8a2cc8
Reports root/ big
OK: 4615 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0

@arcusfelis arcusfelis marked this pull request as ready for review August 13, 2023 10:18
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🔥

@NelsonVides NelsonVides merged commit 61be25e into master Aug 13, 2023
4 checks passed
@NelsonVides NelsonVides deleted the patch-sm branch August 13, 2023 10:23
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants