Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky sm tests by making sid's unique #4103

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Fix flaky sm tests by making sid's unique #4103

merged 1 commit into from
Aug 17, 2023

Commits on Aug 17, 2023

  1. Fix flaky sm tests by making sid's unique 

    Sid's should be created for different Pids - otherwise the timestamp
alone does not guarantee uniqueness.

The sm tests started failing on fast machines, which could generate a
lot of sid's in a single microsecond. On Apple M1 the small tests were
failing all the time.

To fix this, spawn a new process when generating a sid in the tests.
Forward incoming messages to the test process, because some tests need
to check them.
    @chrzaszcz
    chrzaszcz committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    8b6f494 View commit details
    Browse the repository at this point in the history