Wait for async writer to flush messages before removing archive

[arcusfelis]

This PR addresses "MIM-2006" - more robust MAM tests.

test failing

Test: mam_SUITE:muc_no_elements
Group: rdbms_async_cache

Reason:

=== WARNING: end_per_testcase crashed!
Reason: {room_archive_size,0,[{times,200,1}],ok}
Line: [{mongoose_helper,do_wait_until,358},
              {mam_helper,wait_for_room_archive_size,789},
              {mam_helper,clean_room_archive,733},
              {mam_helper,destroy_room,726},
              {mam_SUITE,end_per_testcase,...

Proposed changes include:

• Wait for async writer to flush messages before removing archive
• Remove unused mam_helper:set_wait_for_parallel_writer/2

[mongoose-im]

small_tests_25 / small_tests / 8e60c2d
Reports root

---

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8e60c2d
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

---

small_tests_24 / small_tests / 8e60c2d
Reports root / small

---

small_tests_25_arm64 / small_tests / 8e60c2d
Reports root / small

---

ldap_mnesia_24 / ldap_mnesia / 8e60c2d
Reports root/ big
OK: 2270 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0

---

ldap_mnesia_25 / ldap_mnesia / 8e60c2d
Reports root/ big
OK: 2270 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0

---

dynamic_domains_mysql_redis_25 / mysql_redis / 8e60c2d
Reports root/ big
OK: 4201 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0

---

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8e60c2d
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

---

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8e60c2d
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

---

internal_mnesia_25 / internal_mnesia / 8e60c2d
Reports root/ big
OK: 2416 / Failed: 0 / User-skipped: 685 / Auto-skipped: 0

---

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8e60c2d
Reports root/ big
OK: 4230 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0

---

pgsql_cets_25 / pgsql_cets / 8e60c2d
Reports root/ big
OK: 4588 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

---

mysql_redis_25 / mysql_redis / 8e60c2d
Reports root/ big
OK: 4598 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

---

pgsql_mnesia_24 / pgsql_mnesia / 8e60c2d
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

---

pgsql_mnesia_25 / pgsql_mnesia / 8e60c2d
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

---

mssql_mnesia_25 / odbc_mssql_mnesia / 8e60c2d
Reports root/ big
OK: 4615 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0

---

small_tests_25 / small_tests / 8e60c2d
Reports root / small

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (f9dce47) 83.89% compared to head (8e60c2d) 83.87%.
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4104      +/-   ##
==========================================
- Coverage   83.89%   83.87%   -0.02%     
==========================================
  Files         551      551              
  Lines       33568    33568              
==========================================
- Hits        28161    28155       -6     
- Misses       5407     5413       +6     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[NelsonVides]

Cool 🔥