Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put xep list as JSON in the online docs #4133

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Put xep list as JSON in the online docs #4133

merged 1 commit into from
Oct 2, 2023

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Sep 29, 2023

It can be consumed by MongooseKeeper and any future services. JSON is chosen as it is easily human- and machine-readable.

Tested manually - format of doc/supported-xeps.json after make xeplist:

[
  {
    "url" : "https://xmpp.org/extensions/xep-0004.html",
    "xep" : "0004",
    "modules" : [
      "mongoose_data_forms"
    ],
    "version" : "2.13.1",
    "status" : "complete",
    "name" : "Data Forms"
  },
  {
    "url" : "https://xmpp.org/extensions/xep-0012.html",
    "xep" : "0012",
    "modules" : [
      "mod_last"
    ],
    "version" : "2.0",
    "status" : "complete",
    "name" : "Last Activity"
  },
  (...)
]

Also tested for a proto-xep (we could add such annotations in a separate PR):

  {
    "url" : "https://xmpp.org/extensions/inbox/muc-light.html",
    "xep" : "muc-light",
    "modules" : [
      "mod_muc_light"
    ],
    "version" : "0.0.1",
    "status" : "complete",
    "name" : "Multi-User Chat Light"
  }
]

It can be consumed by MongooseKeeper and any future services.
JSON is chosen as it is easily human- and machine-readable.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 29, 2023

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b2bccb9
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_24 / small_tests / b2bccb9
Reports root / small


small_tests_25_arm64 / small_tests / b2bccb9
Reports root / small


small_tests_25 / small_tests / b2bccb9
Reports root / small


ldap_mnesia_24 / ldap_mnesia / b2bccb9
Reports root/ big
OK: 2276 / Failed: 0 / User-skipped: 860 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / b2bccb9
Reports root/ big
OK: 2276 / Failed: 0 / User-skipped: 860 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b2bccb9
Reports root/ big
OK: 4236 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / b2bccb9
Reports root/ big
OK: 4204 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b2bccb9
Reports root/ big
OK: 4236 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b2bccb9
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / b2bccb9
Reports root/ big
OK: 2422 / Failed: 0 / User-skipped: 714 / Auto-skipped: 0


pgsql_cets_25 / pgsql_cets / b2bccb9
Reports root/ big
OK: 4623 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / b2bccb9
Reports root/ big
OK: 4625 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / b2bccb9
Reports root/ big
OK: 4604 / Failed: 1 / User-skipped: 139 / Auto-skipped: 0

carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_dropped_client_doesnt_create_duplicate_carbons_572@localhost">>},
         {<<"to">>,
        <<"alice_dropped_client_doesnt_create_duplicate_carbons_572@localhost/res2">>},
         {<<"xmlns">>,<<"jabber:client">>},
         {<<"type">>,<<"chat">>}],
        [{xmlel,<<"sent">>,
           [{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
           [{xmlel,<<"forwarded">>,
            [{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
            [{xmlel,<<"message">>,
               [{<<"from">>,
                 <<"alice_dropped_client_doesnt_create_duplicate_carbons_572@localhost/res1">>},
                {<<"to">>,
                 <<"bob_dropped_client_doesnt_create_duplicate_carbons_572@localhost/res1">>},
                {<<"type">>,<<"chat">>},
                {<<"xmlns">>,<<"jabber:client">>}],
               [{xmlel,<<"body">>,[],
                  [{xmlcdata,
                     <<"And pious action">>}]}]}]}]}]}]},
   [{carboncopy_SUITE,
      '-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
      [{file,
         "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
       {line,189}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_serv...

Report log


pgsql_mnesia_25 / pgsql_mnesia / b2bccb9
Reports root/ big
OK: 4625 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / b2bccb9
Reports root/ big
OK: 4622 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / b2bccb9
Reports root/ big
OK: 4604 / Failed: 1 / User-skipped: 139 / Auto-skipped: 0

carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_dropped_client_doesnt_create_duplicate_carbons_564@localhost">>},
         {<<"to">>,
        <<"alice_dropped_client_doesnt_create_duplicate_carbons_564@localhost/res2">>},
         {<<"xmlns">>,<<"jabber:client">>},
         {<<"type">>,<<"chat">>}],
        [{xmlel,<<"sent">>,
           [{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
           [{xmlel,<<"forwarded">>,
            [{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
            [{xmlel,<<"message">>,
               [{<<"from">>,
                 <<"alice_dropped_client_doesnt_create_duplicate_carbons_564@localhost/res1">>},
                {<<"to">>,
                 <<"bob_dropped_client_doesnt_create_duplicate_carbons_564@localhost/res1">>},
                {<<"type">>,<<"chat">>},
                {<<"xmlns">>,<<"jabber:client">>}],
               [{xmlel,<<"body">>,[],
                  [{xmlcdata,
                     <<"And pious action">>}]}]}]}]}]}]},
   [{carboncopy_SUITE,
      '-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
      [{file,
         "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
       {line,189}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_serv...

Report log

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dd13079) 83.94% compared to head (b2bccb9) 83.95%.
Report is 42 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4133   +/-   ##
=======================================
  Coverage   83.94%   83.95%           
=======================================
  Files         553      553           
  Lines       33661    33661           
=======================================
+ Hits        28257    28259    +2     
+ Misses       5404     5402    -2     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrzaszcz chrzaszcz marked this pull request as ready for review October 2, 2023 12:10
Copy link
Member

@pawlooss1 pawlooss1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pawlooss1 pawlooss1 merged commit 8f2266b into master Oct 2, 2023
4 checks passed
@pawlooss1 pawlooss1 deleted the json-xep-list branch October 2, 2023 12:25
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants