-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put xep list as JSON in the online docs #4133
Conversation
It can be consumed by MongooseKeeper and any future services. JSON is chosen as it is easily human- and machine-readable.
elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b2bccb9 small_tests_24 / small_tests / b2bccb9 small_tests_25_arm64 / small_tests / b2bccb9 small_tests_25 / small_tests / b2bccb9 ldap_mnesia_24 / ldap_mnesia / b2bccb9 ldap_mnesia_25 / ldap_mnesia / b2bccb9 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b2bccb9 dynamic_domains_mysql_redis_25 / mysql_redis / b2bccb9 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b2bccb9 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b2bccb9 internal_mnesia_25 / internal_mnesia / b2bccb9 pgsql_cets_25 / pgsql_cets / b2bccb9 pgsql_mnesia_24 / pgsql_mnesia / b2bccb9 mysql_redis_25 / mysql_redis / b2bccb9 carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_572@localhost">>},
{<<"to">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_572@localhost/res2">>},
{<<"xmlns">>,<<"jabber:client">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"sent">>,
[{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
[{xmlel,<<"forwarded">>,
[{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_572@localhost/res1">>},
{<<"to">>,
<<"bob_dropped_client_doesnt_create_duplicate_carbons_572@localhost/res1">>},
{<<"type">>,<<"chat">>},
{<<"xmlns">>,<<"jabber:client">>}],
[{xmlel,<<"body">>,[],
[{xmlcdata,
<<"And pious action">>}]}]}]}]}]}]},
[{carboncopy_SUITE,
'-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
[{file,
"/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
{line,189}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_serv... pgsql_mnesia_25 / pgsql_mnesia / b2bccb9 mssql_mnesia_25 / odbc_mssql_mnesia / b2bccb9 mysql_redis_25 / mysql_redis / b2bccb9 carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_564@localhost">>},
{<<"to">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_564@localhost/res2">>},
{<<"xmlns">>,<<"jabber:client">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"sent">>,
[{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
[{xmlel,<<"forwarded">>,
[{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_564@localhost/res1">>},
{<<"to">>,
<<"bob_dropped_client_doesnt_create_duplicate_carbons_564@localhost/res1">>},
{<<"type">>,<<"chat">>},
{<<"xmlns">>,<<"jabber:client">>}],
[{xmlel,<<"body">>,[],
[{xmlcdata,
<<"And pious action">>}]}]}]}]}]}]},
[{carboncopy_SUITE,
'-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
[{file,
"/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
{line,189}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_serv... |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4133 +/- ##
=======================================
Coverage 83.94% 83.95%
=======================================
Files 553 553
Lines 33661 33661
=======================================
+ Hits 28257 28259 +2
+ Misses 5404 5402 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
It can be consumed by MongooseKeeper and any future services. JSON is chosen as it is easily human- and machine-readable.
Tested manually - format of
doc/supported-xeps.json
aftermake xeplist
:Also tested for a proto-xep (we could add such annotations in a separate PR):