Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper backend based on preset in amp_big_SUITE #4137

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Oct 4, 2023

This PR addresses "MIM-2063 amp_big_SUITE would stop working in pgsql_cets backend, if we disable mnesia application".

Proposed changes include:

  • Just use mongoose_helper:mnesia_or_rdbms_backend/2 helper.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 4, 2023

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 3db336d
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_24 / small_tests / 3db336d
Reports root / small


small_tests_25 / small_tests / 3db336d
Reports root / small


small_tests_25_arm64 / small_tests / 3db336d
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 3db336d
Reports root/ big
OK: 2303 / Failed: 0 / User-skipped: 864 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 3db336d
Reports root/ big
OK: 2303 / Failed: 0 / User-skipped: 864 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 3db336d
Reports root/ big
OK: 4235 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 3db336d
Reports root/ big
OK: 4267 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 3db336d
Reports root/ big
OK: 4267 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 3db336d
Reports root/ big
OK: 4264 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 3db336d
Reports root/ big
OK: 2453 / Failed: 0 / User-skipped: 714 / Auto-skipped: 0


pgsql_cets_25 / pgsql_cets / 3db336d
Reports root/ big
OK: 4654 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 3db336d
Reports root/ big
OK: 4656 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 3db336d
Reports root/ big
OK: 4636 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 3db336d
Reports root/ big
OK: 4656 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 3db336d
Reports root/ big
OK: 4653 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2ea4207) 84.08% compared to head (3db336d) 84.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4137      +/-   ##
==========================================
- Coverage   84.08%   84.07%   -0.02%     
==========================================
  Files         558      558              
  Lines       34016    34016              
==========================================
- Hits        28604    28600       -4     
- Misses       5412     5416       +4     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arcusfelis arcusfelis marked this pull request as ready for review October 4, 2023 13:02
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit 7d05a65 into master Oct 6, 2023
4 checks passed
@chrzaszcz chrzaszcz deleted the use-proper-backend-amp-big-suite branch October 6, 2023 09:06
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants