-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log internal-server-errors in mod_privacy #4139
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4139 +/- ##
==========================================
- Coverage 84.08% 84.03% -0.06%
==========================================
Files 558 558
Lines 34016 34030 +14
==========================================
- Hits 28604 28596 -8
- Misses 5412 5434 +22
☔ View full report in Codecov by Sentry. |
Otherwise you will not see anything in logs, in Mnesia is not started, but mod_privacy is configured with Mnesia backend
9139193
to
3780cf6
Compare
elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 3780cf6 small_tests_24 / small_tests / 3780cf6 small_tests_25 / small_tests / 3780cf6 small_tests_25_arm64 / small_tests / 3780cf6 ldap_mnesia_25 / ldap_mnesia / 3780cf6 ldap_mnesia_24 / ldap_mnesia / 3780cf6 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 3780cf6 dynamic_domains_mysql_redis_25 / mysql_redis / 3780cf6 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 3780cf6 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 3780cf6 muc_SUITE:register:user_changes_nick{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"cb6837086ec94af2d257a073ee5899a4">>},
{<<"to">>,<<"groupchats.domain.example.com">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitch1room-9f7e156235">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"groupchats.domain.example.com">>},
{<<"to">>,
<<"[email protected]/res1">>},
{<<"type">>,<<"error">>},
{<<"id">>,<<"cb6837086ec94af2d257a073ee5899a4">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xm... muc_SUITE:register:user_submits_registration_form{error,
{thrown,
{timeout,
[{escalus_connection,receive_stanza,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,303}]},
{muc_SUITE,'-user_submits_registration_form/1-fun-0-',1,
[{file,
"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,2759}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}} muc_SUITE:register:user_submits_registration_form_twice{error,
{thrown,
{timeout,
[{escalus_connection,receive_stanza,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,303}]},
{muc_SUITE,'-user_submits_registration_form_twice/1-fun-0-',1,
[{file,
"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,2773}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}} muc_SUITE:register:user_unregisters_nick_twice{error,
{thrown,
{timeout,
[{escalus_connection,receive_stanza,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,303}]},
{muc_SUITE,'-user_unregisters_nick_twice/1-fun-0-',1,
[{file,
"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,2804}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}} muc_SUITE:register:user_asks_for_registration_form{error,
{thrown,
{timeout,
[{escalus_connection,receive_stanza,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,303}]},
{muc_SUITE,get_nick,1,
[{file,
"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,5116}]},
{muc_SUITE,'-user_asks_for_registration_form/1-fun-0-',1,
[{file,
"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,2750}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}} muc_SUITE:register:user_unregisters_nick{error,
{thrown,
{timeout,
[{escalus_connection,receive_stanza,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,303}]},
{muc_SUITE,get_nick,1,
[{file,
"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,5116}]},
{muc_SUITE,'-user_unregisters_nick/1-fun-0-',1,
[{file,
"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,2795}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}} internal_mnesia_25 / internal_mnesia / 3780cf6 pgsql_cets_25 / pgsql_cets / 3780cf6 mysql_redis_25 / mysql_redis / 3780cf6 pgsql_mnesia_24 / pgsql_mnesia / 3780cf6 pgsql_mnesia_25 / pgsql_mnesia / 3780cf6 mssql_mnesia_25 / odbc_mssql_mnesia / 3780cf6 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 3780cf6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Log internal-server-errors in mod_privacy.
Otherwise you will not see anything in logs, in Mnesia is not started, but mod_privacy is configured with Mnesia backend.
This PR addresses "Nothing in logs, code just ignores
Reason
variable, which is returned from mod_privacy_backend.Proposed changes include:
Coverage for the patch is low, because we usually do not test logging.