Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Unable to restart VM after applying CETS preset" #4143

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Oct 9, 2023

This PR addresses "MIM-2071 Unable to restart VM after applying CETS preset"

Proposed changes include:

  • Disable strict check that mnesia is running for mod_register and ejabberd_auth_anon (they are still not supported by CETS though).
  • Configure mod_stream_management with the proper backend in the templates.

It makes it impossible to start in the default configuration
Changing default configuration could be a separate issue
(Or we rather add CETS backends for these two modules - sounds easier)
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 9, 2023

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / a54298f
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_25 / small_tests / a54298f
Reports root / small


small_tests_26_arm64 / small_tests / a54298f
Reports root / small


small_tests_26 / small_tests / a54298f
Reports root / small


ldap_mnesia_25 / ldap_mnesia / a54298f
Reports root/ big
OK: 2303 / Failed: 0 / User-skipped: 865 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / a54298f
Reports root/ big
OK: 4268 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / a54298f
Reports root/ big
OK: 4236 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / a54298f
Reports root/ big
OK: 2303 / Failed: 0 / User-skipped: 865 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / a54298f
Reports root/ big
OK: 4268 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / a54298f
Reports root/ big
OK: 4265 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / a54298f
Reports root/ big
OK: 2453 / Failed: 0 / User-skipped: 715 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / a54298f
Reports root/ big
OK: 4655 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / a54298f
Reports root/ big
OK: 4637 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / a54298f
Reports root/ big
OK: 4657 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / a54298f
Reports root/ big
OK: 4657 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / a54298f
Reports root/ big
OK: 4654 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (507fcd5) 84.08% compared to head (a54298f) 84.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4143      +/-   ##
==========================================
- Coverage   84.08%   84.07%   -0.02%     
==========================================
  Files         560      560              
  Lines       34015    34017       +2     
==========================================
- Hits        28601    28599       -2     
- Misses       5414     5418       +4     
Files Coverage Δ
src/auth/ejabberd_auth_anonymous.erl 68.85% <100.00%> (+0.51%) ⬆️
src/mod_register.erl 76.09% <100.00%> (+0.11%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arcusfelis arcusfelis marked this pull request as ready for review October 9, 2023 11:01
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@chrzaszcz chrzaszcz merged commit 27f7362 into master Oct 9, 2023
4 checks passed
@chrzaszcz chrzaszcz deleted the fix-live-start branch October 9, 2023 11:07
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants